Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Obs AI Assistant] Use sparse_vector instead of text_expansion query #202313

Closed
sorenlouv opened this issue Nov 29, 2024 · 1 comment · Fixed by #202891
Closed

[Obs AI Assistant] Use sparse_vector instead of text_expansion query #202313

sorenlouv opened this issue Nov 29, 2024 · 1 comment · Fixed by #202891
Assignees
@sorenlouv
Labels
Team:Obs AI Assistant Observability AI Assistant

Comments

@sorenlouv
Copy link
Member

When querying search connectors we use the text expansion query

kibana/x-pack/plugins/observability_solution/observability_ai_assistant/server/service/knowledge_base_service/recall_from_search_connectors.ts

Lines 158 to 164 in 648c323

text_expansion: {
[vectorField]: {
model_text: text,
model_id: modelId,
boost,
},
},

The text expansion query was deprecated in 8.15 and was replaced by sparse vector query.
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 29, 2024
@sorenlouv sorenlouv added Team:Obs AI Assistant Observability AI Assistant and removed needs-team Issues missing a team label labels Nov 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

@sorenlouv sorenlouv self-assigned this Dec 4, 2024
@sorenlouv sorenlouv mentioned this issue Dec 4, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 7, 2025
@sorenlouv
[Obs AI Assistant] Use sparse_vector instead of text_expansion (e…
c7c6119 
…lastic#202891)

Closes elastic#202313

The [text expansion
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)
was deprecated in 8.15 and is being replaced by [sparse vector
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).

(cherry picked from commit 30c7ce6)
kibanamachine added a commit that referenced this issue Jan 7, 2025
@kibanamachine @sorenlouv
[8.x] [Obs AI Assistant] Use `sparse_vector` instead of &#x…
b2d1a03 
…60;text_expansion` (#202891) (#205758)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Obs AI Assistant] Use `sparse_vector` instead of
`text_expansion`
(#202891)](#202891)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2025-01-07T14:35:38Z","message":"[Obs
AI Assistant] Use `sparse_vector` instead of `text_expansion`
(#202891)\n\nCloses #202313\n\nThe [text
expansion\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)\nwas
deprecated in 8.15 and is being replaced by [sparse
vector\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).","sha":"30c7ce6a15b7c0491657351866bce87e8b3befd0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:Obs
AI Assistant","ci:project-deploy-observability"],"title":"[Obs AI
Assistant] Use `sparse_vector` instead of
`text_expansion`","number":202891,"url":"https://github.com/elastic/kibana/pull/202891","mergeCommit":{"message":"[Obs
AI Assistant] Use `sparse_vector` instead of `text_expansion`
(#202891)\n\nCloses #202313\n\nThe [text
expansion\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)\nwas
deprecated in 8.15 and is being replaced by [sparse
vector\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).","sha":"30c7ce6a15b7c0491657351866bce87e8b3befd0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202891","number":202891,"mergeCommit":{"message":"[Obs
AI Assistant] Use `sparse_vector` instead of `text_expansion`
(#202891)\n\nCloses #202313\n\nThe [text
expansion\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)\nwas
deprecated in 8.15 and is being replaced by [sparse
vector\nquery](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).","sha":"30c7ce6a15b7c0491657351866bce87e8b3befd0"}}]}]
BACKPORT-->

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this issue Jan 7, 2025
@sorenlouv @kowalczyk-krzysztof
[Obs AI Assistant] Use sparse_vector instead of text_expansion (e…
c8543a3 
…lastic#202891)

Closes elastic#202313

The [text expansion
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)
was deprecated in 8.15 and is being replaced by [sparse vector
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).
crespocarlos pushed a commit to crespocarlos/kibana that referenced this issue Jan 8, 2025
@sorenlouv @crespocarlos
[Obs AI Assistant] Use sparse_vector instead of text_expansion (e…
eeabda4 
…lastic#202891)

Closes elastic#202313

The [text expansion
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)
was deprecated in 8.15 and is being replaced by [sparse vector
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@sorenlouv @CAWilson94
[Obs AI Assistant] Use sparse_vector instead of text_expansion (e…
56e442e 
…lastic#202891)

Closes elastic#202313

The [text expansion
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)
was deprecated in 8.15 and is being replaced by [sparse vector
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@sorenlouv @viduni94
[Obs AI Assistant] Use sparse_vector instead of text_expansion (e…
a316756 
…lastic#202891)

Closes elastic#202313

The [text expansion
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-text-expansion-query.html)
was deprecated in 8.15 and is being replaced by [sparse vector
query](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-sparse-vector-query.html).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorenlouv sorenlouv

Labels
Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Obs AI Assistant] Use sparse_vector instead of text_expansion sorenlouv/kibana
2 participants
@sorenlouv @elasticmachine