Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search:Connectors:New connector page]Issues with Connector input field #197622

Closed
L1nBra opened this issue Oct 24, 2024 · 1 comment · Fixed by #201590
Closed

[Search:Connectors:New connector page]Issues with Connector input field #197622

L1nBra opened this issue Oct 24, 2024 · 1 comment · Fixed by #201590
Assignees
Labels
defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A

Comments

@L1nBra
Copy link

L1nBra commented Oct 24, 2024

Description
For the user, especially using assistive technology, it should be clear where he/she is at the moment, how to interact with the element. User shouldn't be confused by duplicate, strange announcements or strange sentence structures.

Preconditions
Stateful Connectors -> New connector page is opened.
Use Screen Reader (NVDA).

Steps to reproduce

1.Navigate to Connector field while using only keyboard by pressing Tab key.
2.Observe Screen Reader announcement.
3.Navigate through the opened list.
4.Observe Screen Reader announcement.
5.Press Enter on any connector to select it.
6.Observe Screen Reader announcement.
7.Delete selection from the field by pressing Tab key.
8.Observe the field.

NVDA Speech Viewer + UI element
step 2
Image

step4
Image

step6
Image

step8
Image

Actual Result

  • Step2: duplicate announcement of the dialog and its' information.
  • Step4: before each option in the list, "34 results available" are announced (total items in the list). After announcing option name, screen reader separately announces "dot" (because in html dot symbol is separately written), example: "Customized connector ."(the dot here is announced). Self managed, Tech preview badges are announced as well and after "not checked" announcement, the name of the option is announced again.
  • Step6: after selecting option from the list, list is not present anymore on the screen. Screen reader still announces all available options according to the selection present in the Connector input field and it announces instructions how to move through the options, select them, but if user press up/down arrow keys, Enter key - nothing happens (because list is not present below the field at the moment).
  • Step8: after deleting selected entry from Connector field when pressing Backspace key - list doesn't appear below the field.

Expected Result

  • Step2: dialog with it's information is announced only one time.
  • Step4: total number or results are not announced before each option - they are announced only one time (something like this when announcing the list: "list with 34 items"). Dot is not announced by the screen reader (should not be added separately in html between comas (".")). Clear announcement of list option - option is not duplicated, either badges are not announced or at least the sentence structure should be different (now it is not clear what exactly user is checking, what is not checked. Is it Self managed or Customized connector).
  • Step6: announcement should be clear and only about the Connector field with the selection present in it - no announcement about instructions of list (because now user expects changes with up/down arrow keys, Enter key - but nothing happens).
  • Step8: list appears below the Connector field (because if you delete entry by pressing x button in Connector field - list appears).

Meta Issue

Kibana Version: 8.16.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 129.0.6668.101 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 24, 2024
@L1nBra L1nBra added WCAG A Team:Search defect-level-2 Serious UX disruption with workaround labels Oct 24, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 24, 2024
@L1nBra L1nBra added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Oct 30, 2024
@L1nBra L1nBra changed the title [Stateful:Connectors:New connector page]Issues with Connector input field [Search:Connectors:New connector page]Issues with Connector input field Nov 7, 2024
@JoseLuisGJ JoseLuisGJ self-assigned this Nov 22, 2024
@JoseLuisGJ JoseLuisGJ linked a pull request Nov 25, 2024 that will close this issue
JoseLuisGJ added a commit that referenced this issue Nov 26, 2024
## Summary

This PR fixes some a11y and responsive related issues like:

- elastic/search-team#8666
- #197622

Some of the improvements are:
- The custom dropdown content truncates the connector name content when
there is not enough space
- The `EuiComoBox` wrapping Flex item it slightly bigger compared with
the connectors name and it gets full width when reaching the `"l"`
breakpoint in order to better display its content in different
resolutions
- The badges now are display horizontally when there are more than one.
- Each `EuiComboBoxOptionOption` now has a custom `aria-label` where
users can get a better info using screen reader informing for instance
"Slack, Tech preview" This should fix the redundancy described in this
issue #197622
- Deleting the selection either pressing Space or Backspace displays the
dropdown content options



https://github.com/user-attachments/assets/c4494908-2849-4f95-84e9-25a60a5a05ab

![CleanShot 2024-11-25 at 15 25
36@2x](https://github.com/user-attachments/assets/caa27feb-cb3b-443f-b5c8-37cc1d823fe6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 26, 2024
## Summary

This PR fixes some a11y and responsive related issues like:

- elastic/search-team#8666
- elastic#197622

Some of the improvements are:
- The custom dropdown content truncates the connector name content when
there is not enough space
- The `EuiComoBox` wrapping Flex item it slightly bigger compared with
the connectors name and it gets full width when reaching the `"l"`
breakpoint in order to better display its content in different
resolutions
- The badges now are display horizontally when there are more than one.
- Each `EuiComboBoxOptionOption` now has a custom `aria-label` where
users can get a better info using screen reader informing for instance
"Slack, Tech preview" This should fix the redundancy described in this
issue elastic#197622
- Deleting the selection either pressing Space or Backspace displays the
dropdown content options

https://github.com/user-attachments/assets/c4494908-2849-4f95-84e9-25a60a5a05ab

![CleanShot 2024-11-25 at 15 25
36@2x](https://github.com/user-attachments/assets/caa27feb-cb3b-443f-b5c8-37cc1d823fe6)

(cherry picked from commit e0607f7)
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
## Summary

This PR fixes some a11y and responsive related issues like:

- elastic/search-team#8666
- elastic#197622

Some of the improvements are:
- The custom dropdown content truncates the connector name content when
there is not enough space
- The `EuiComoBox` wrapping Flex item it slightly bigger compared with
the connectors name and it gets full width when reaching the `"l"`
breakpoint in order to better display its content in different
resolutions
- The badges now are display horizontally when there are more than one.
- Each `EuiComboBoxOptionOption` now has a custom `aria-label` where
users can get a better info using screen reader informing for instance
"Slack, Tech preview" This should fix the redundancy described in this
issue elastic#197622
- Deleting the selection either pressing Space or Backspace displays the
dropdown content options



https://github.com/user-attachments/assets/c4494908-2849-4f95-84e9-25a60a5a05ab

![CleanShot 2024-11-25 at 15 25
36@2x](https://github.com/user-attachments/assets/caa27feb-cb3b-443f-b5c8-37cc1d823fe6)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
## Summary

This PR fixes some a11y and responsive related issues like:

- elastic/search-team#8666
- elastic#197622

Some of the improvements are:
- The custom dropdown content truncates the connector name content when
there is not enough space
- The `EuiComoBox` wrapping Flex item it slightly bigger compared with
the connectors name and it gets full width when reaching the `"l"`
breakpoint in order to better display its content in different
resolutions
- The badges now are display horizontally when there are more than one.
- Each `EuiComboBoxOptionOption` now has a custom `aria-label` where
users can get a better info using screen reader informing for instance
"Slack, Tech preview" This should fix the redundancy described in this
issue elastic#197622
- Deleting the selection either pressing Space or Backspace displays the
dropdown content options



https://github.com/user-attachments/assets/c4494908-2849-4f95-84e9-25a60a5a05ab

![CleanShot 2024-11-25 at 15 25
36@2x](https://github.com/user-attachments/assets/caa27feb-cb3b-443f-b5c8-37cc1d823fe6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants