[Draft][Alert details page] Handling related alerts for different rule types #193942
Assignees
Labels
Comments
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
This was referenced Sep 25, 2024
maryam-saeidi
added a commit
that referenced
this issue
Sep 25, 2024
…eshold rule (#193957) Closes #193943 ### Summary This PR only loads related alerts for the custom threshold rule and only when the related rule has tags or group by fields. For now, we don't show this tab if there is no tag or group and there is a follow-up ticket for discussing the empty state for the related alerts. #### Follow-up work - #193952 - #193942
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Sep 25, 2024
…eshold rule (elastic#193957) Closes elastic#193943 ### Summary This PR only loads related alerts for the custom threshold rule and only when the related rule has tags or group by fields. For now, we don't show this tab if there is no tag or group and there is a follow-up ticket for discussing the empty state for the related alerts. #### Follow-up work - elastic#193952 - elastic#193942 (cherry picked from commit 387afb7)
kibanamachine
referenced
this issue
Sep 25, 2024
…om threshold rule (#193957) (#193991) # Backport This will backport the following commits from `main` to `8.x`: - [[Alert details page] Use related alerts logic only for the custom threshold rule (#193957)](#193957) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-09-25T12:43:52Z","message":"[Alert details page] Use related alerts logic only for the custom threshold rule (#193957)\n\nCloses #193943\r\n\r\n### Summary\r\n\r\nThis PR only loads related alerts for the custom threshold rule and only\r\nwhen the related rule has tags or group by fields.\r\n\r\nFor now, we don't show this tab if there is no tag or group and there is\r\na follow-up ticket for discussing the empty state for the related\r\nalerts.\r\n\r\n#### Follow-up work\r\n- https://github.com/elastic/kibana/issues/193952\r\n- https://github.com/elastic/kibana/issues/193942","sha":"387afb782e44a0bf7de5549751e52fc7619c328a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Alert details page] Use related alerts logic only for the custom threshold rule","number":193957,"url":"https://github.com/elastic/kibana/pull/193957","mergeCommit":{"message":"[Alert details page] Use related alerts logic only for the custom threshold rule (#193957)\n\nCloses #193943\r\n\r\n### Summary\r\n\r\nThis PR only loads related alerts for the custom threshold rule and only\r\nwhen the related rule has tags or group by fields.\r\n\r\nFor now, we don't show this tab if there is no tag or group and there is\r\na follow-up ticket for discussing the empty state for the related\r\nalerts.\r\n\r\n#### Follow-up work\r\n- https://github.com/elastic/kibana/issues/193952\r\n- https://github.com/elastic/kibana/issues/193942","sha":"387afb782e44a0bf7de5549751e52fc7619c328a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193957","number":193957,"mergeCommit":{"message":"[Alert details page] Use related alerts logic only for the custom threshold rule (#193957)\n\nCloses #193943\r\n\r\n### Summary\r\n\r\nThis PR only loads related alerts for the custom threshold rule and only\r\nwhen the related rule has tags or group by fields.\r\n\r\nFor now, we don't show this tab if there is no tag or group and there is\r\na follow-up ticket for discussing the empty state for the related\r\nalerts.\r\n\r\n#### Follow-up work\r\n- https://github.com/elastic/kibana/issues/193952\r\n- https://github.com/elastic/kibana/issues/193942","sha":"387afb782e44a0bf7de5549751e52fc7619c328a"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Oct 15, 2024
…lastic#195592) Closes elastic#193942 Closes elastic#193952 ## Summary This PR adds related alert logic for all the observability rules, as mentioned in elastic#193942. Also, it adds a beta badge for this new tab.  (cherry picked from commit b4c3ab5)
kibanamachine
added a commit
that referenced
this issue
Oct 15, 2024
…ules (#195592) (#196437) # Backport This will backport the following commits from `main` to `8.x`: - [[Related alerts] Add related alerts for all the observability rules (#195592)](#195592) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2024-10-15T20:05:11Z","message":"[Related alerts] Add related alerts for all the observability rules (#195592)\n\nCloses #193942\r\nCloses #193952\r\n\r\n## Summary\r\n\r\nThis PR adds related alert logic for all the observability rules, as\r\nmentioned in #193942. Also, it adds a beta badge for this new tab.\r\n\r\n\r\n","sha":"b4c3ab55a0680db2ec1a9d2f01051266f599e172","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Related alerts] Add related alerts for all the observability rules","number":195592,"url":"https://github.com/elastic/kibana/pull/195592","mergeCommit":{"message":"[Related alerts] Add related alerts for all the observability rules (#195592)\n\nCloses #193942\r\nCloses #193952\r\n\r\n## Summary\r\n\r\nThis PR adds related alert logic for all the observability rules, as\r\nmentioned in #193942. Also, it adds a beta badge for this new tab.\r\n\r\n\r\n","sha":"b4c3ab55a0680db2ec1a9d2f01051266f599e172"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195592","number":195592,"mergeCommit":{"message":"[Related alerts] Add related alerts for all the observability rules (#195592)\n\nCloses #193942\r\nCloses #193952\r\n\r\n## Summary\r\n\r\nThis PR adds related alert logic for all the observability rules, as\r\nmentioned in #193942. Also, it adds a beta badge for this new tab.\r\n\r\n\r\n","sha":"b4c3ab55a0680db2ec1a9d2f01051266f599e172"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
We cannot have generic logic that would be applied to all the rules since the information in different rules is different; we need to develop separate logic for each rule type.
We decided first to implement one logic to apply to all the rules and, in a follow-up step, adjust this logic per rule. Here is the shared logic:
The text was updated successfully, but these errors were encountered: