Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inventory] Enable EEM from inventory #192328

Closed
4 tasks done
smith opened this issue Sep 8, 2024 · 0 comments · Fixed by #193557
Closed
4 tasks done

[Inventory] Enable EEM from inventory #192328

smith opened this issue Sep 8, 2024 · 0 comments · Fixed by #193557
Assignees
@kpatticha
Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@smith
Copy link
Contributor

smith commented Sep 8, 2024 •
edited by kpatticha
Loading

Summary

When EEM is not enabled (elastic entity model) the user should be able to enable it. Once enable it we show a splash screen. When the user doesn't have permission should show the modal Insufficient permissions

Caution

Please review the designs on Figma - DESIGNS

(Screenshot taken on 18.09.2024)

Designs

this design is missing from figma but it's the default template from observability
Image

splash screen

Image

Insufficient permissions

Image

Acceptance criteria

  • Copies

    • Title: See everything you have in one place!
    • Subtitle: The inventory will show all of your observed entities in one place so you can detect and resolve problems with them faster!
    • Card description: The inventory uses the Elastic Entity Model to show all of your observed entities in one place.
    • Button: Enable

  • On success show show the splash screen with the empty state

  • when the user has Insufficient permissions should show the modal

  • the image in the modal should be clickable and open in full screen
@smith smith added enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Sep 8, 2024
@kpatticha kpatticha changed the title Inventory empty states [Inventory] Enable EEM and handle empty state Sep 12, 2024
@kpatticha kpatticha changed the title [Inventory] Enable EEM and handle empty state [Inventory] Enable EEM from inventory Sep 18, 2024
@kpatticha kpatticha removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label Sep 18, 2024
@kpatticha kpatticha self-assigned this Sep 19, 2024
@kpatticha kpatticha mentioned this issue Sep 20, 2024
Merged
1 task
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Sep 23, 2024
@kpatticha
[Inventory][ECO] Enable elastic entity model from inventory (elastic#…
140bb9f 
…193557)

## Summary

closes elastic#192328

> [!Note]
>  Empty state will be handled in a different ticket
### Checklist

### Enable with permissions

https://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336

https://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40

### Enable without permissions

https://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30

https://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5

### TODO

- [x] add dark screenshot of inventory

(cherry picked from commit b5a061e)
kibanamachine added a commit that referenced this issue Sep 23, 2024
@kibanamachine @kpatticha
[8.x] [Inventory][ECO] Enable elastic entity model from inventory (#1…
e3723fe 
…93557) (#193712)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory][ECO] Enable elastic entity model from inventory
(#193557)](#193557)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Katerina","email":"aikaterini.patticha@elastic.co"},"sourceCommit":{"committedDate":"2024-09-23T12:01:00Z","message":"[Inventory][ECO]
Enable elastic entity model from inventory (#193557)\n\n##
Summary\r\n\r\ncloses #192328
\r\n\r\n> [!Note] \r\n> Empty state will be handled in a different
ticket\r\n### Checklist\r\n\r\n### Enable with permissions
\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336\r\n\r\n\r\nhttps://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40\r\n\r\n\r\n\r\n\r\n###
Enable without permissions
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5\r\n\r\n\r\n\r\n###
TODO\r\n\r\n- [x] add dark screenshot of
inventory","sha":"b5a061ec64ba4246c6f476dbe192435cb896fef1","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","v8.16.0"],"title":"[Inventory][ECO]
Enable elastic entity model from
inventory","number":193557,"url":"https://github.com/elastic/kibana/pull/193557","mergeCommit":{"message":"[Inventory][ECO]
Enable elastic entity model from inventory (#193557)\n\n##
Summary\r\n\r\ncloses #192328
\r\n\r\n> [!Note] \r\n> Empty state will be handled in a different
ticket\r\n### Checklist\r\n\r\n### Enable with permissions
\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336\r\n\r\n\r\nhttps://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40\r\n\r\n\r\n\r\n\r\n###
Enable without permissions
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5\r\n\r\n\r\n\r\n###
TODO\r\n\r\n- [x] add dark screenshot of
inventory","sha":"b5a061ec64ba4246c6f476dbe192435cb896fef1"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193557","number":193557,"mergeCommit":{"message":"[Inventory][ECO]
Enable elastic entity model from inventory (#193557)\n\n##
Summary\r\n\r\ncloses #192328
\r\n\r\n> [!Note] \r\n> Empty state will be handled in a different
ticket\r\n### Checklist\r\n\r\n### Enable with permissions
\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/c7a5390b-2d7c-4897-a167-485da74ac336\r\n\r\n\r\nhttps://github.com/user-attachments/assets/44e30654-04bd-42c3-9c1e-a24042b4cb40\r\n\r\n\r\n\r\n\r\n###
Enable without permissions
\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b5f16f43-1cd4-48a7-bf04-3926b03e5a30\r\n\r\n\r\nhttps://github.com/user-attachments/assets/be17ddf7-de7a-4573-b0c4-caadeece3cc5\r\n\r\n\r\n\r\n###
TODO\r\n\r\n- [x] add dark screenshot of
inventory","sha":"b5a061ec64ba4246c6f476dbe192435cb896fef1"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Katerina <aikaterini.patticha@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpatticha kpatticha

Labels
enhancement New value added to drive a business result Feature:EntitiesInventory Observability entities inventory feature Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Inventory][ECO] Enable elastic entity model from inventory kpatticha/kibana
2 participants
@smith @kpatticha