Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Remove feature flags that are enabled by default #190844

Closed
kpollich opened this issue Aug 20, 2024 · 3 comments · Fixed by #206448
Closed

[Fleet] Remove feature flags that are enabled by default #190844

kpollich opened this issue Aug 20, 2024 · 3 comments · Fixed by #206448
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@kpollich
Copy link
Member

Currently, Fleet maintains references to many feature flags that have long since been enabled by default as their corresponding features have been made generally available, e.g:

const _allowedExperimentalValues = {
createPackagePolicyMultiPageLayout: true,
packageVerification: true,
showDevtoolsRequest: true,
diagnosticFileUploadEnabled: true,
displayAgentMetrics: true,
showIntegrationsSubcategories: true,
agentFqdnMode: true,
showExperimentalShipperOptions: false,
agentTamperProtectionEnabled: true,
secretsStorage: true,
kafkaOutput: true,
outputSecretsStorage: true,
remoteESOutput: true,
agentless: false,
enableStrictKQLValidation: true,
subfeaturePrivileges: false,
enablePackagesStateMachine: true,
advancedPolicySettings: true,
useSpaceAwareness: false,
enableReusableIntegrationPolicies: true,
};

These should be removed as a breaking change, and their relevant code paths/conditionals should be removed to avoid needless nesting and maintenance burden on their impacted areas of the Fleet codebase.

@kpollich kpollich added the Team:Fleet Team label for Observability Data Collection Fleet team label Aug 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member

These should be removed as a breaking change, and their relevant code paths/conditionals should be removed to avoid needless nesting and maintenance burden on their impacted areas of the Fleet codebase.

Actually there is no way to disable a feature flag with a default value of true in Fleet, so I do not think it will be a breaking change to delete those.

@kpollich
Copy link
Member Author

I'm removing this from our breaking changes epic as this is more just tech debt cleanup we can do at any time.

@juliaElastic juliaElastic self-assigned this Jan 13, 2025
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
## Summary

Closes elastic#190844

Removed feature flags enabled by default, deleted conditionals where not
needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants