Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Cases] Template's custom field issues #187333

Closed
js-jankisalvi opened this issue Jul 2, 2024 · 2 comments · Fixed by #187591
Closed

[ResponseOps][Cases] Template's custom field issues #187333

js-jankisalvi opened this issue Jul 2, 2024 · 2 comments · Fixed by #187591
Assignees
@js-jankisalvi
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@js-jankisalvi
Copy link
Contributor

Issue 1:
Steps to reproduce:

  1. Create a template
  2. Add new toggle custom field with default value as true
  3. Go to create case, See that new toggle custom field has value: true
  4. Select recently created template
  5. Toggle custom field value is not updated

Issue 2:

  1. Create a text custom field with default value
  2. Create a template
  3. Set text custom field value to empty
  4. Save template
  5. Go to create case
  6. Select recently created template
  7. See that text custom field has default value

Expected behaviour:
Issue 1: Template should have new custom field with it's default value.
Issue 2: Text custom field's default value should not be added after selecting a template during create case
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 2, 2024
@js-jankisalvi js-jankisalvi added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature and removed needs-team Issues missing a team label labels Jul 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@js-jankisalvi js-jankisalvi self-assigned this Jul 2, 2024
@js-jankisalvi js-jankisalvi changed the title [ResponseOps][Cases] Template's custom fields issues [ResponseOps][Cases] Template's custom field issues Jul 2, 2024
This was referenced Jul 2, 2024
Merged
Merged
js-jankisalvi added a commit that referenced this issue Jul 11, 2024
@js-jankisalvi
[ResponseOps][Cases] Fix template's custom fields bugs (#187591)
6b0d628 
## Summary

Fixes #187333

## Testing behaviour: 
Issue 1: verify similar behaviour from API as well.

1. Create a template
2. Add new toggle custom field with default value as true
3. Go to create case, See that new toggle custom field has value: true
4. Select recently created template
5. Toggle custom field new custom field with it's default value

Issue 2: verify similar behaviour from API as well.
1. Create a text custom field with default value
2. Create a template
3. Set text custom field value to empty
4. Save template
5. Go to create case
6. Select recently created template
7. See that text custom field value is updated as per template's custom
field value
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 11, 2024
@js-jankisalvi
[ResponseOps][Cases] Fix template's custom fields bugs (elastic#187591)
bdcd8b7 
## Summary

Fixes elastic#187333

## Testing behaviour:
Issue 1: verify similar behaviour from API as well.

1. Create a template
2. Add new toggle custom field with default value as true
3. Go to create case, See that new toggle custom field has value: true
4. Select recently created template
5. Toggle custom field new custom field with it's default value

Issue 2: verify similar behaviour from API as well.
1. Create a text custom field with default value
2. Create a template
3. Set text custom field value to empty
4. Save template
5. Go to create case
6. Select recently created template
7. See that text custom field value is updated as per template's custom
field value

(cherry picked from commit 6b0d628)
kibanamachine referenced this issue Jul 11, 2024
@kibanamachine @js-jankisalvi
[8.15] [ResponseOps][Cases] Fix template's custom fields bugs (#…
124d228 
…187591) (#188135)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ResponseOps][Cases] Fix template's custom fields bugs
(#187591)](#187591)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Janki
Salvi","email":"117571355+js-jankisalvi@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-07-11T16:13:19Z","message":"[ResponseOps][Cases]
Fix template's custom fields bugs (#187591)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/187333\r\n\r\n## Testing
behaviour: \r\nIssue 1: verify similar behaviour from API as
well.\r\n\r\n1. Create a template\r\n2. Add new toggle custom field with
default value as true\r\n3. Go to create case, See that new toggle
custom field has value: true\r\n4. Select recently created
template\r\n5. Toggle custom field new custom field with it's default
value\r\n\r\nIssue 2: verify similar behaviour from API as well.\r\n1.
Create a text custom field with default value\r\n2. Create a
template\r\n3. Set text custom field value to empty\r\n4. Save
template\r\n5. Go to create case\r\n6. Select recently created
template\r\n7. See that text custom field value is updated as per
template's custom\r\nfield
value","sha":"6b0d62805352c391fc7bfdb47ff848c0a46080ee","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","Feature:Cases","v8.15.0","v8.16.0"],"title":"[ResponseOps][Cases]
Fix template's custom fields
bugs","number":187591,"url":"https://github.com/elastic/kibana/pull/187591","mergeCommit":{"message":"[ResponseOps][Cases]
Fix template's custom fields bugs (#187591)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/187333\r\n\r\n## Testing
behaviour: \r\nIssue 1: verify similar behaviour from API as
well.\r\n\r\n1. Create a template\r\n2. Add new toggle custom field with
default value as true\r\n3. Go to create case, See that new toggle
custom field has value: true\r\n4. Select recently created
template\r\n5. Toggle custom field new custom field with it's default
value\r\n\r\nIssue 2: verify similar behaviour from API as well.\r\n1.
Create a text custom field with default value\r\n2. Create a
template\r\n3. Set text custom field value to empty\r\n4. Save
template\r\n5. Go to create case\r\n6. Select recently created
template\r\n7. See that text custom field value is updated as per
template's custom\r\nfield
value","sha":"6b0d62805352c391fc7bfdb47ff848c0a46080ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/187591","number":187591,"mergeCommit":{"message":"[ResponseOps][Cases]
Fix template's custom fields bugs (#187591)\n\n## Summary\r\n\r\nFixes
https://github.com/elastic/kibana/issues/187333\r\n\r\n## Testing
behaviour: \r\nIssue 1: verify similar behaviour from API as
well.\r\n\r\n1. Create a template\r\n2. Add new toggle custom field with
default value as true\r\n3. Go to create case, See that new toggle
custom field has value: true\r\n4. Select recently created
template\r\n5. Toggle custom field new custom field with it's default
value\r\n\r\nIssue 2: verify similar behaviour from API as well.\r\n1.
Create a text custom field with default value\r\n2. Create a
template\r\n3. Set text custom field value to empty\r\n4. Save
template\r\n5. Go to create case\r\n6. Select recently created
template\r\n7. See that text custom field value is updated as per
template's custom\r\nfield
value","sha":"6b0d62805352c391fc7bfdb47ff848c0a46080ee"}}]}] BACKPORT-->

Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js-jankisalvi js-jankisalvi

Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Cases] Fix template's custom fields bugs js-jankisalvi/kibana
2 participants
@elasticmachine @js-jankisalvi