-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Add METRICS
source command support
#184498
Labels
Comments
Pinging @elastic/kibana-esql (Team:ESQL) |
This was referenced May 30, 2024
stratoula
pushed a commit
that referenced
this issue
May 31, 2024
## Summary Partially addresses #184498 - Add syntax coloring in Manaco editor for the `METRICS` source command.
vadimkibana
added a commit
that referenced
this issue
May 31, 2024
…84494) ## Summary Partially addresses #184498 - Sets up unit testing for the `@kbn/esql-ast` package. - Adds unit tests for `FROM` command parsing. - Adds `METRICS` command to AST node generation. - Adds unit tests for `METRICS` command parsing. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
2 tasks
vadimkibana
added a commit
that referenced
this issue
Jun 20, 2024
## Summary Partially addresses #184498 The main contribution of this PR is the `METRICS` command validation cases: <img width="778" alt="image" src="https://github.com/elastic/kibana/assets/82822460/3d768952-3fa3-4928-b251-204c30d20c4b"> See own-review below for more comments. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bhapas
pushed a commit
to bhapas/kibana
that referenced
this issue
Jun 24, 2024
## Summary Partially addresses elastic#184498 The main contribution of this PR is the `METRICS` command validation cases: <img width="778" alt="image" src="https://github.com/elastic/kibana/assets/82822460/3d768952-3fa3-4928-b251-204c30d20c4b"> See own-review below for more comments. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
umbopepato
pushed a commit
to umbopepato/kibana
that referenced
this issue
Jul 5, 2024
## Summary Partially addresses elastic#184498 The main contribution of this PR is the `METRICS` command validation cases: <img width="778" alt="image" src="https://github.com/elastic/kibana/assets/82822460/3d768952-3fa3-4928-b251-204c30d20c4b"> See own-review below for more comments. ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@kbn/esql-ast
).METRICS
AST nodes after parsing (@kbn/esql-ast
).METRICS
source command AST node support in parsing #184494@kbn/monaco
).@kbn/esql-validation-autocomplete
.METRICS
command definition and validation #184905@kbn/esql-validation-autocomplete
.METRICS
command definition and validation #184905@kbn/esql-validation-autocomplete
.METRICS
command #187432Autocomplete should show only TSDB indicesGET /_resolve/index/*
API response elasticsearch#110382AddMETRICS
command docsThe text was updated successfully, but these errors were encountered: