Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Add METRICS source command support #184498

Open
6 of 8 tasks
vadimkibana opened this issue May 30, 2024 · 1 comment
Open
6 of 8 tasks

[ES|QL] Add METRICS source command support #184498

vadimkibana opened this issue May 30, 2024 · 1 comment
Assignees
Labels
Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana

Comments

@vadimkibana
Copy link
Contributor

vadimkibana commented May 30, 2024

@vadimkibana vadimkibana added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels May 30, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@vadimkibana vadimkibana self-assigned this May 30, 2024
stratoula pushed a commit that referenced this issue May 31, 2024
## Summary

Partially addresses #184498

- Add syntax coloring in Manaco editor for the `METRICS` source command.
vadimkibana added a commit that referenced this issue May 31, 2024
…84494)

## Summary

Partially addresses #184498

- Sets up unit testing for the `@kbn/esql-ast` package.
- Adds unit tests for `FROM` command parsing.
- Adds `METRICS` command to AST node generation.
- Adds unit tests for `METRICS` command parsing.


### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
 
### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
vadimkibana added a commit that referenced this issue Jun 20, 2024
## Summary

Partially addresses #184498

The main contribution of this PR is the `METRICS` command validation
cases:

<img width="778" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/3d768952-3fa3-4928-b251-204c30d20c4b">

See own-review below for more comments.


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
bhapas pushed a commit to bhapas/kibana that referenced this issue Jun 24, 2024
## Summary

Partially addresses elastic#184498

The main contribution of this PR is the `METRICS` command validation
cases:

<img width="778" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/3d768952-3fa3-4928-b251-204c30d20c4b">

See own-review below for more comments.


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
umbopepato pushed a commit to umbopepato/kibana that referenced this issue Jul 5, 2024
## Summary

Partially addresses elastic#184498

The main contribution of this PR is the `METRICS` command validation
cases:

<img width="778" alt="image"
src="https://github.com/elastic/kibana/assets/82822460/3d768952-3fa3-4928-b251-204c30d20c4b">

See own-review below for more comments.


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

No branches or pull requests

2 participants