[Discover] Can't set back an already saved breakdown by field to "No breakdown" #184379
Assignees
Labels
bug
Fixes for quality problems that affect the customer experience
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
triage_needed
Comments
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
the for reporting, I can confirm it's a bug, and will be fixed |
1 task
jughosta
added a commit
that referenced
this issue
Jun 7, 2024
- Closes #184379 ## Summary This PR brings back the logic which was edited in #169548 This should allow to reset the saved breakdown field with rather an empty string as `undefined` seems to be ignored. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Jun 7, 2024
…c#184668) - Closes elastic#184379 ## Summary This PR brings back the logic which was edited in elastic#169548 This should allow to reset the saved breakdown field with rather an empty string as `undefined` seems to be ignored. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 132ab34)
kibanamachine
referenced
this issue
Jun 7, 2024
…184668) (#184998) # Backport This will backport the following commits from `main` to `8.14`: - [[Discover] Fix resetting of breakdown field in a saved search (#184668)](#184668) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-06-07T11:29:16Z","message":"[Discover] Fix resetting of breakdown field in a saved search (#184668)\n\n- Closes https://github.com/elastic/kibana/issues/184379\r\n\r\n## Summary\r\n\r\nThis PR brings back the logic which was edited in\r\nhttps://github.com//pull/169548 This should allow to reset\r\nthe saved breakdown field with rather an empty string as `undefined`\r\nseems to be ignored.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"132ab34ba54fbc6d119bc1e31d3838cd72493082","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:fix","Team:DataDiscovery","backport:prev-minor","v8.15.0"],"title":"[Discover] Fix resetting of breakdown field in a saved search","number":184668,"url":"https://github.com/elastic/kibana/pull/184668","mergeCommit":{"message":"[Discover] Fix resetting of breakdown field in a saved search (#184668)\n\n- Closes https://github.com/elastic/kibana/issues/184379\r\n\r\n## Summary\r\n\r\nThis PR brings back the logic which was edited in\r\nhttps://github.com//pull/169548 This should allow to reset\r\nthe saved breakdown field with rather an empty string as `undefined`\r\nseems to be ignored.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"132ab34ba54fbc6d119bc1e31d3838cd72493082"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/184668","number":184668,"mergeCommit":{"message":"[Discover] Fix resetting of breakdown field in a saved search (#184668)\n\n- Closes https://github.com/elastic/kibana/issues/184379\r\n\r\n## Summary\r\n\r\nThis PR brings back the logic which was edited in\r\nhttps://github.com//pull/169548 This should allow to reset\r\nthe saved breakdown field with rather an empty string as `undefined`\r\nseems to be ignored.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"132ab34ba54fbc6d119bc1e31d3838cd72493082"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <julia.rechkunova@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Kibana version: 8.13.4
Elasticsearch version: 8.13.4
Server OS version: Cloud Environment
Describe the bug:
In 8.13.4, upon opening a saved search with a breakdown defined, any attempt to modify the
Breakdown byfield toNo breakdown, and then resaving the search has no effect. While it would seem that the change has taken effect, the next time you open it it reverts back to the same original "breakdown by" field that was selected before. The only way to get around this issue is by saving the search under the "unsaved changes" and using the "Save as" function using a different name.Issue reproduced in an ESS 8.13.4 deployment. There is a saved search named
7-daysbroke it down by thegeo.destfield:Then, set it to
No breakdownand go toUnsaved changesand hitSave.A prompt is displayed stating the modifications were saved:
Upon opening the Saved Search, it's not saved with the recent updates:
The workaround is to go to
Save Asand then the changes will be saved.Can you please check it?
Thanks!
The text was updated successfully, but these errors were encountered: