Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution]Hollow pie chart missing percentage of Same Family fields #177780

Closed
ghost opened this issue Feb 26, 2024 · 7 comments · Fixed by #178167
Closed

[Security Solution]Hollow pie chart missing percentage of Same Family fields #177780

ghost opened this issue Feb 26, 2024 · 7 comments · Fixed by #178167
Assignees
@kapral18
Labels
8.14 candidate bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.13.1

Comments

@ghost
Copy link

ghost commented Feb 26, 2024

Describe the bug:
Hollow pie chart missing percentage of Same Family fields

Kibana/Elasticsearch Stack version

Version: 8.13.0
Commit: c2fc8da128504d437897970d142efd4d06970c0b
Build: 71815

Browser and Browser OS Version:
Firefox for windows OS
Version: 123.0

Elastic Endpoint Version:
N/A

Original install method:
None

Functional Area:
DQ Dashboard

Initial Setup:

  • None

precondition

  • Create 7.17.18 and upgrade it to 8.13 BC2

Steps to reproduce

  • Navigate to Data Quality Dashboard
  • Perform check all if not performed earlier
  • Expand any index and navigate to summary tab having same family fields
  • Observed in summary hollow pie chart we have missing percentage of same family fields

Additional Result

  • Issue is also occuring on 8.13.0 BC2 Fresh instance

Current Result

  • No percentage of same family field in hollow pie chart

Expected Result

  • Hollow pie chart should include same family field count

Screen-Cast:

Data.Quality.-.Kibana.Mozilla.Firefox.2024-02-26.13-09-34.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Feb 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Threat Hunting Security Solution Threat Hunting Team labels Feb 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@amolnater-qasource
Copy link

Reviewed & assigned to @MadameSheema

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@MadameSheema MadameSheema assigned semd and unassigned MadameSheema Feb 28, 2024
@semd semd added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Mar 5, 2024
@semd semd assigned kapral18 and unassigned semd Mar 5, 2024
kapral18 added a commit to kapral18/kibana that referenced this issue Mar 6, 2024
@kapral18
fix(security-solution): add missing same-family field in summary chart
972f9f3 
closes elastic#177780
@kapral18 kapral18 mentioned this issue Mar 6, 2024
Merged
1 task
kapral18 added a commit that referenced this issue Mar 8, 2024
@kapral18
[Security Solution][Data Quality Dashboard] Add missing same-family f…
0f6c834 
…ield in summary chart (#178167)

Fixes #177780

## Summary

same-field category is missing in summary tab hollow chart. This PR
enables same-field category display in summary tab hollow chart.

#### Before:


https://github.com/elastic/kibana/assets/1625373/b747657a-78c6-4b06-91e0-414317d13d7c

#### After:


https://github.com/elastic/kibana/assets/1625373/0878c593-3a33-418a-94db-54d7922776f9

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kapral18
Copy link
Contributor

kapral18 commented Mar 8, 2024

hey @karanbirsingh-qasource it's merged to main can you check and let me know?

@kapral18 kapral18 reopened this Mar 8, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Mar 8, 2024
@kapral18
[Security Solution][Data Quality Dashboard] Add missing same-family f…
d947e9b 
…ield in summary chart (elastic#178167)

Fixes elastic#177780

## Summary

same-field category is missing in summary tab hollow chart. This PR
enables same-field category display in summary tab hollow chart.

#### Before:

https://github.com/elastic/kibana/assets/1625373/b747657a-78c6-4b06-91e0-414317d13d7c

#### After:

https://github.com/elastic/kibana/assets/1625373/0878c593-3a33-418a-94db-54d7922776f9

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 0f6c834)
kibanamachine added a commit that referenced this issue Mar 8, 2024
@kibanamachine @kapral18
[8.13] [Security Solution][Data Quality Dashboard] Add missing same-f…
4b8fb70 
…amily field in summary chart (#178167) (#178282)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution][Data Quality Dashboard] Add missing same-family
field in summary chart
(#178167)](#178167)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"karen.grigoryan@elastic.co"},"sourceCommit":{"committedDate":"2024-03-08T09:56:08Z","message":"[Security
Solution][Data Quality Dashboard] Add missing same-family field in
summary chart (#178167)\n\nFixes #177780\r\n\r\n##
Summary\r\n\r\nsame-field category is missing in summary tab hollow
chart. This PR\r\nenables same-field category display in summary tab
hollow chart.\r\n\r\n####
Before:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1625373/b747657a-78c6-4b06-91e0-414317d13d7c\r\n\r\n####
After:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1625373/0878c593-3a33-418a-94db-54d7922776f9\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0f6c834a26d91aaa942fc41dfe17eb13c34e2bd8","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:Threat
Hunting:Explore","v8.13.0","v8.14.0"],"title":"[Security Solution][Data
Quality Dashboard] Add missing same-family field in summary
chart","number":178167,"url":"https://github.com/elastic/kibana/pull/178167","mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Add missing same-family field in
summary chart (#178167)\n\nFixes #177780\r\n\r\n##
Summary\r\n\r\nsame-field category is missing in summary tab hollow
chart. This PR\r\nenables same-field category display in summary tab
hollow chart.\r\n\r\n####
Before:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1625373/b747657a-78c6-4b06-91e0-414317d13d7c\r\n\r\n####
After:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1625373/0878c593-3a33-418a-94db-54d7922776f9\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0f6c834a26d91aaa942fc41dfe17eb13c34e2bd8"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/178167","number":178167,"mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] Add missing same-family field in
summary chart (#178167)\n\nFixes #177780\r\n\r\n##
Summary\r\n\r\nsame-field category is missing in summary tab hollow
chart. This PR\r\nenables same-field category display in summary tab
hollow chart.\r\n\r\n####
Before:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1625373/b747657a-78c6-4b06-91e0-414317d13d7c\r\n\r\n####
After:\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/1625373/0878c593-3a33-418a-94db-54d7922776f9\r\n\r\n###
Checklist\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"0f6c834a26d91aaa942fc41dfe17eb13c34e2bd8"}}]}]
BACKPORT-->

Co-authored-by: Karen Grigoryan <karen.grigoryan@elastic.co>
@semd semd added the fixed label Mar 11, 2024
@MadameSheema
Copy link
Member

@karanbirsingh-qasource please validate the fix at the next BC.

@ghost
Copy link
Author

ghost commented Apr 1, 2024

Hi @MadameSheema

we have validated this issue on 8.13.1 and found the issue to be fixed ✔️ .

Build Details:

Version: 8.13.1
Commit: 091f486ab05863258cf2f3fa18ea0c59097dee80
Build: 72107

Screen-shot

image

Hence we are closing this issue and adding "QA:Validated" tag to it.

thanks !!

@ghost ghost closed this as completed Apr 1, 2024
@ghost ghost added the QA:Validated Issue has been validated by QA label Apr 1, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kapral18 kapral18

Labels
8.14 candidate bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.13.1
Projects
None yet
Milestone
No milestone
5 participants
@kapral18 @elasticmachine @MadameSheema @semd @amolnater-qasource