-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Pinned filters are ignored when fetching results for a saved search via a custom link #171212
Comments
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@jughosta Yes, that's for sure the right file, but I think it's likely because of this code: kibana/src/plugins/discover/public/application/main/services/load_saved_search.ts Lines 70 to 89 in f606085
Since appState is empty initially (no |
- Closes #171212 ## Summary Discover ignored global filters when loading a saved search, because it loads a saved search before it starts syncing with global URL state. This PR does not change the order of events but it adds a manual sync for global filters so they are included in search request anyway. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…c#175814) - Closes elastic#171212 ## Summary Discover ignored global filters when loading a saved search, because it loads a saved search before it starts syncing with global URL state. This PR does not change the order of events but it adds a manual sync for global filters so they are included in search request anyway. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…c#175814) - Closes elastic#171212 ## Summary Discover ignored global filters when loading a saved search, because it loads a saved search before it starts syncing with global URL state. This PR does not change the order of events but it adds a manual sync for global filters so they are included in search request anyway. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Kibana version: at least in 8.11 and above
Description of the problem including expected versus actual behavior:
If a saved search includes filters and URL is manually constructed to include pinned filters then the pinned filters are ignored after opening the URL.
Steps to reproduce:
_g=...
and excluding_a=...
param (example:http://localhost:5601/qzv/app/discover#/view/2f360f30-ea74-11eb-b4c6-3d2afc1cb389?_g=(filters:!(('$state':(store:globalState),meta:(alias:!n,disabled:!f,index:'90943e30-9a47-11e8-b64d-95841ca0b247',key:machine.os,negate:!f,params:(query:ios),type:phrase),query:(match_phrase:(machine.os:ios)))),refreshInterval:(pause:!t,value:60000),time:(from:now-30d%2Fd,to:now))
)Expected: both filters (pinned and from the saved search) are applied
Actual: only the saved search filter was used to fetch results
The text was updated successfully, but these errors were encountered: