-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Introduce Dataset health page #169759
Comments
@weltenwort, @tonyghiani, @Kerry350, @mohamedhamed-ahmed in favour of abstracting, or at least creating a black box component at the beginning, I was thinking on maybe creating a plugin just for the dataset health (sort of what you have between What do you think about then creating a page, sort of a wrapper, in |
I agree it has its pros to abstract into a new plugin.
In my understanding, we want to treat the dataset health page as we do for the log explorer, creating a new client route that embeds the previously created component. flowchart TD
apm(Apm)
fleet(Fleet)
log_explorer(Log Explorer)
dataset_health(Dataset Health)
observability_log_explorer(Observability Log Explorer)
observability_log_explorer --> log_explorer
observability_log_explorer --> dataset_health
apm --> log_explorer
fleet --> log_explorer
fleet --> dataset_health
|
Related to #169759. ## Summary This PR creates the initial plugin for Dataset Quality. The plugin has the basic boilerplate that allows us to continue working on the UI and Server sides in parallel. Further configs are to be added along with upcoming commits like: 1. Storybook 2. FTR configs --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Related to #169759. ## Summary The Data streams stats endpoint can be queried like so (example with all parameters): `GET /internal/dataset_quality/data_streams/stats?type=logs&sortOrder=asc&datasetQuery=nginx` ### Notes/questions Our intial idea was to place this endpoint within fleet, after some discussions we decided to place the endpoint inside our plugin `dataset_quality`. - ~~Is `/epm` still the best place to include this new api?~~ We decided to place the new endpoint in `dataset_quality` plugin. - ~~Should we include an `uncategorisedOnly` option as part of the Data Streams Stats endpoint as we do for [Data streams endpoint](https://github.com/elastic/kibana/blob/c1681c8d49304f324895acbe73323ffacad3fcbc/x-pack/plugins/fleet/server/types/rest_spec/epm.ts#L62)? We are not planning to have the a filter for this but it could favor consistency in this area.~~ uncategorizedOnly is not part of the new endpoint although it's easily extensible to include such parameter. - ~~We are modifying `x-pack/plugins/fleet/server/services/epm/data_streams/get.ts` to include a property for extendedResults, as of now this method only returns a list of objects that include only the name. We would like to extend this method to include also information related to the `package`. Is this the right approach? should we create a new method just for doing this? Also, this is the method we are using for `GET /api/fleet/epm/data_streams` since this new property (`extendedResponse`) is false by default the api is not being directly affected, but should we include this new param as part of the api params?~~ We are not working with fleet api anymore, instead we are using an internal route. - ~~How does `GetEpmDataStreamsStatsResponse` looks like? is this reponse type aligned with fleet responses?~~ - ~~We have configured `fleetAuthz: READ_PACKAGE_INFO_AUTHZ` for this new endpoint, would it be possible to not have this restriction and use the internal user when querying elastic search?~~ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
…observability log explorer (elastic#171777) Related to elastic#169759. ## Summary This PR adds the Dataset Quality page behind the path below: `/app/observability-log-explorer/dataset-quality` ## Testing 1. Navigate to the URL above 2. The table should be displayed with all dataset listed 3. `Add Button` should navigate you to the onboarding page 4. Sorting and Pagination should work as expected <img width="2552" alt="Screenshot 2023-11-23 at 14 05 44" src="https://github.com/elastic/kibana/assets/11225826/d348bb10-b2f5-49bf-a4af-dfbc82784bbd"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
📓 Summary
In order to make ongoing maintenance of log collection easy we want to introduce the concept of dataset health, where users can easily get an overview on the datasets they have with information such as integration, size, last activity, among others.
A hint on the datasources have been laid out in this comment.
With tooltips:

✔️ Acceptance criteria
derived from the human-readable name if the dataset is owned by an integration
derived from the plain dataset name otherwise
ℹ️ is derived from the plain dataset name
derived from the icon and name of the integration and empty If no integration is found (uncategorized)
derived the data stream stats API if a backing data stream exists and 0 otherwise formatted for easy human consumption
derived from the data stream stats API
Name
.💡 Implementation hints
Tasks
The text was updated successfully, but these errors were encountered: