Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet]: No error message is displayed while saving kafka output for adding invalid characters in the Partitioning fields. #165063

Closed
amolnater-qasource opened this issue Aug 29, 2023 · 7 comments · Fixed by #165202
Closed

[Fleet]: No error message is displayed while saving kafka output for adding invalid characters in the Partitioning fields. #165063

amolnater-qasource opened this issue Aug 29, 2023 · 7 comments · Fixed by #165202
Assignees
@szwarckonrad
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana Build details:

VERSION: 8.10.0 BC2
BUILD: 66107
COMMIT: fa3473f42d7c5e7a3c2d66026a153e01002f5d3c

Host OS and Browser version: All, All

Preconditions:

  1. 8.10.0 Kibana cloud environment should be available.

Steps to reproduce:

  1. Navigate to Fleet>Settings output.
  2. Click Add output and fill all mandatory fields.
  3. Now under Partitioning>Random enter characters say Test and save the kafka output.
  4. Observe no errors and the data gets set to 1 automatically.
  5. Now select Round robin and add characters say Test and save the kafka output.
  6. Observe no errors and the fields gets set to blank.

Expected Result:
Error message should be displayed while saving kafka output for adding invalid characters in the Partitioning fields.

Screen Recording:

Settings.-.Fleet.-.Elastic.-.Google.Chrome.2023-08-29.13-35-10.mp4
@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@jlind23
Copy link
Contributor

jlind23 commented Aug 29, 2023

@szwarckonrad is this something you can help us fix?
cc @criamico

@szwarckonrad
Copy link
Contributor

Will do. cc @kevinlog

@szwarckonrad szwarckonrad self-assigned this Aug 29, 2023
@szwarckonrad szwarckonrad mentioned this issue Aug 30, 2023
Merged
szwarckonrad added a commit that referenced this issue Aug 31, 2023
@szwarckonrad
[Fleet][Kafka][Fix] Validate number of events fields (#165202)
99032df 
This PR adds field verification for `Partitioning` part of `Kafka`
output UI.
Might close #165063



https://github.com/elastic/kibana/assets/29123534/1f0a3704-efec-40d7-9e3a-f5504ddd77af
@szwarckonrad szwarckonrad reopened this Aug 31, 2023
@szwarckonrad szwarckonrad added the QA:Ready for Testing Code is merged and ready for QA to validate label Aug 31, 2023
@szwarckonrad
Copy link
Contributor

szwarckonrad commented Aug 31, 2023 •
edited
Loading

Merged fix to main. Will be available in BC4 since BC3 just built :/

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 31, 2023
@szwarckonrad
[Fleet][Kafka][Fix] Validate number of events fields (elastic#165202)
b459b33 
This PR adds field verification for `Partitioning` part of `Kafka`
output UI.
Might close elastic#165063

https://github.com/elastic/kibana/assets/29123534/1f0a3704-efec-40d7-9e3a-f5504ddd77af
(cherry picked from commit 99032df)
kibanamachine referenced this issue Aug 31, 2023
@kibanamachine @szwarckonrad
[8.10] [Fleet][Kafka][Fix] Validate number of events fields (#165202) (…
28d2f06 
…#165318)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[Fleet][Kafka][Fix] Validate number of events fields
(#165202)](#165202)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2023-08-31T12:01:50Z","message":"[Fleet][Kafka][Fix]
Validate number of events fields (#165202)\n\nThis PR adds field
verification for `Partitioning` part of `Kafka`\r\noutput UI.\r\nMight
close
https://github.com/elastic/kibana/issues/165063\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/1f0a3704-efec-40d7-9e3a-f5504ddd77af","sha":"99032dff872d03b7e27eeeecdfcafbd3dabc0f81","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.10.0","v8.11.0"],"number":165202,"url":"https://github.com/elastic/kibana/pull/165202","mergeCommit":{"message":"[Fleet][Kafka][Fix]
Validate number of events fields (#165202)\n\nThis PR adds field
verification for `Partitioning` part of `Kafka`\r\noutput UI.\r\nMight
close
https://github.com/elastic/kibana/issues/165063\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/1f0a3704-efec-40d7-9e3a-f5504ddd77af","sha":"99032dff872d03b7e27eeeecdfcafbd3dabc0f81"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165202","number":165202,"mergeCommit":{"message":"[Fleet][Kafka][Fix]
Validate number of events fields (#165202)\n\nThis PR adds field
verification for `Partitioning` part of `Kafka`\r\noutput UI.\r\nMight
close
https://github.com/elastic/kibana/issues/165063\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/29123534/1f0a3704-efec-40d7-9e3a-f5504ddd77af","sha":"99032dff872d03b7e27eeeecdfcafbd3dabc0f81"}}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
@amolnater-qasource
Copy link
Author

Hi Team,

We have revalidated this issue on latest 8.10.0 BC7 kibana cloud environment and had below observations:

Observations:

  • Error message is displayed while saving kafka output for adding characters instead of integers in the Partitioning fields.

Screenshot:
image
image

Build details:
VERSION: 8.10.0 BC7
BUILD: 66350
COMMIT: 824bcbf

Hence we are closing this issue and marking as QA:Validated.

Thanks!

@amolnater-qasource amolnater-qasource added QA:Validated Issue has been validated by QA and removed QA:Ready for Testing Code is merged and ready for QA to validate labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szwarckonrad szwarckonrad

Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet][Kafka][Fix] Validate number of events fields szwarckonrad/kibana
5 participants
@elasticmachine @szwarckonrad @jlind23 @manishgupta-qasource @amolnater-qasource