Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/security_solution/public/timelines/components/timeline/query_tab_content - Timeline rendering it does render the timeline table when the source is loading with no events #156797

Open
kibanamachine opened this issue May 5, 2023 · 9 comments
Open

Failing test: Jest Tests.x-pack/plugins/security_solution/public/timelines/components/timeline/query_tab_content - Timeline rendering it does render the timeline table when the source is loading with no events #156797

kibanamachine opened this issue May 5, 2023 · 9 comments
Assignees
@michaelolo24
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented May 5, 2023 •
edited
Loading

A test failed on a tracked branch

TypeError: indexPatternsService.find is not a function
    at find (/var/lib/buildkite-agent/builds/kb-n2-4-spot-6c52c0702d8b32df/elastic/kibana-on-merge/kibana/src/plugins/unified_search/public/query_string_input/fetch_index_patterns.ts:38:26)
    at QueryStringInputUI.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-6c52c0702d8b32df/elastic/kibana-on-merge/kibana/src/plugins/unified_search/public/query_string_input/query_string_input.tsx:234:63)
    at invokeFunc (/var/lib/buildkite-agent/builds/kb-n2-4-spot-6c52c0702d8b32df/elastic/kibana-on-merge/kibana/node_modules/lodash/lodash.js:10401:23)
    at trailingEdge (/var/lib/buildkite-agent/builds/kb-n2-4-spot-6c52c0702d8b32df/elastic/kibana-on-merge/kibana/node_modules/lodash/lodash.js:10450:18)
    at timerExpired (/var/lib/buildkite-agent/builds/kb-n2-4-spot-6c52c0702d8b32df/elastic/kibana-on-merge/kibana/node_modules/lodash/lodash.js:10438:18)
    at Timeout.task [as _onTimeout] (/var/lib/buildkite-agent/builds/kb-n2-4-spot-6c52c0702d8b32df/elastic/kibana-on-merge/kibana/node_modules/jest-environment-jsdom/node_modules/jsdom/lib/jsdom/browser/Window.js:520:19)
    at listOnTimeout (node:internal/timers:559:17)
    at processTimers (node:internal/timers:502:7)

First failure: CI Build - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label May 5, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label May 5, 2023
@kibanamachine kibanamachine added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label May 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label May 5, 2023
@MadameSheema MadameSheema added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team labels May 5, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

mistic added a commit that referenced this issue May 8, 2023
@mistic
skip flaky suite (#156797)
20d29e5
@mistic
Copy link
Member

mistic commented May 8, 2023 •
edited
Loading

Skipped.

main: 20d29e5
8.8: 2bb4d54

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.8

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.8

mistic added a commit that referenced this issue May 9, 2023
@mistic
skip flaky suite (#156797)
2bb4d54
@mistic mistic added the v8.8.1 label May 9, 2023
@michaelolo24 michaelolo24 mentioned this issue Dec 20, 2023
Merged
janmonschke added a commit that referenced this issue Jan 17, 2024
@michaelolo24 @janmonschke
[Investigations] Unskip dataproviders test (#173183)
9746bab 
## Summary

This PR unskips the tests for the timeline query builder dataProviders.
In this unskip a few things were tackled:

1. dataProviders were unskipped and the utilized tasks updated to work
with the new timeline ux
2. Two new tasks were added: `createTimelineOptionsPopoverBottomBar` and
`openTimelineByIdFromOpenTimelineModal`
3. All `force:true` were removed from the timeline tasks file
4. The `open_timeline`, `sourcerer_timeline`, and `query_tab` tests were
fixed against the new timeline ux as `force:true` was masking a bug in
how the cypress tests was written.

Resolves the following issues:

#163622
#164069
#169396
#156797

[Flaky Tests - Dec.
20](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4662)

---------

Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
@PhilippeOberti
Copy link
Contributor

fixed in #173183

CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@michaelolo24 @janmonschke @CoenWarmer
[Investigations] Unskip dataproviders test (elastic#173183)
62aa172 
## Summary

This PR unskips the tests for the timeline query builder dataProviders.
In this unskip a few things were tackled:

1. dataProviders were unskipped and the utilized tasks updated to work
with the new timeline ux
2. Two new tasks were added: `createTimelineOptionsPopoverBottomBar` and
`openTimelineByIdFromOpenTimelineModal`
3. All `force:true` were removed from the timeline tasks file
4. The `open_timeline`, `sourcerer_timeline`, and `query_tab` tests were
fixed against the new timeline ux as `force:true` was masking a bug in
how the cypress tests was written.

Resolves the following issues:

elastic#163622
elastic#164069
elastic#169396
elastic#156797

[Flaky Tests - Dec.
20](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4662)

---------

Co-authored-by: Jan Monschke <jan.monschke@elastic.co>
@logeekal
Copy link
Contributor

logeekal commented Feb 21, 2024 •
edited
Loading

Looks like above tests are still skipped. I will try to take care of this in my upcoming PR.

@logeekal logeekal reopened this Feb 21, 2024
@logeekal logeekal reopened this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelolo24 michaelolo24

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@mistic @logeekal @elasticmachine @michaelolo24 @PhilippeOberti @MadameSheema @kibanamachine