Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [bug] Share alert button does not account for Alert Page Controls #156590

Closed
logeekal opened this issue May 3, 2023 · 2 comments
Closed

[Security Solution] [bug] Share alert button does not account for Alert Page Controls #156590

logeekal opened this issue May 3, 2023 · 2 comments
Assignees
@michaelolo24
Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0

Comments

@logeekal
Copy link
Contributor

logeekal commented May 3, 2023 •
edited
Loading

Describe the bug:

Share alert button does not work completely when Destination browser has different set of Alert Page Controls. See the video below and reproduction steps.

This can be reproduced in different browser where user have different set of Alert Page controls saved. Source Browser tab does not have standard set of Alert Page Controls

Kibana/Elasticsearch Stack version:
8.8 BC1

Server OS version:
Does not matter

Browser and Browser OS versions:
Does not matter

Elastic Endpoint version:
Does not matter

Original install method (e.g. download page, yum, from source, etc.):

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):

** Steps to reproduce: Scenario 1 **

  1. Open Browser1 and Browser 2
  2. In Browser 2 choose Status as Acknowledged
  3. Now Open Alert Details flyout of an open alert in Browser 1
  4. Click on Share Alert button.
  5. Open it in Browser 2.
  6. Flyout will open fine but Alert will not be visible.

Similar scenario is demoed below:

Screen.Recording.2023-05-03.at.18.29.31.mov

**Steps to reproduce: Scenario 2 **

  1. Open Browser1
  2. In Browser 1 choose Status as Acknowledged
  3. Now Open Alert Details flyout of an acknowledged alert in Browser 1
  4. Click on Share Alert button.
  5. Open it in Browser 2 where you have never logged before or clear the storage.
  6. Flyout will open fine but Alert will not be visible.

**Steps to reproduce: Scenario 3 ( Rule Details Page ) **

  1. Open Browser1
  2. Visit Rule Details Page in Browser 1
  3. In Browser 1 choose Status as Acknowledged
  4. Now Open Alert Details flyout of an acknowledged alert in Browser 1
  5. Click on Share Alert button.
  6. Open it in Browser 2 where you have never logged before or clear the storage.
  7. Flyout will open fine but Alert will not be visible.

Current behavior:
Share Alert button does not account for Alert Page Controls

Expected behavior:
Share Alert button should also copy Alert Page Controls

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):
@logeekal logeekal added bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0 labels May 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@michaelolo24 michaelolo24 mentioned this issue May 4, 2023
Merged
1 task
michaelolo24 added a commit that referenced this issue May 8, 2023
@michaelolo24 @kibanamachine
[Security Solution][Investigations] - fix opening flyout, and clear f…
1b40216 
…ilters (#156702)

## Summary

This PR fixes the following issue
#156590 where a users
configuration for their alert page filters can prevent them from seeing
the alert in the table. In this PR we clear the filters to only show the
required status filter, with no selection, to rely primarily on the kql
query filter for the alert id.

Demo: 


https://user-images.githubusercontent.com/17211684/236332095-ac5583ec-6b5f-4ee2-9c23-9391b54263ba.mov


It also fixes a bug where the flyout when opened wasn't unmounted when
navigating away from a page and back to it as seen here:

The bug:


https://user-images.githubusercontent.com/17211684/236333550-b41925f9-a06c-4aa9-931b-beecf4c9ae9b.mov

With the fix:


https://user-images.githubusercontent.com/17211684/236334123-a0e3169e-2ec8-4754-92d2-65f2f369fa4f.mov


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 8, 2023
@michaelolo24
[Security Solution][Investigations] - fix opening flyout, and clear f…
e3d4f90 
…ilters (elastic#156702)

## Summary

This PR fixes the following issue
elastic#156590 where a users
configuration for their alert page filters can prevent them from seeing
the alert in the table. In this PR we clear the filters to only show the
required status filter, with no selection, to rely primarily on the kql
query filter for the alert id.

Demo:

https://user-images.githubusercontent.com/17211684/236332095-ac5583ec-6b5f-4ee2-9c23-9391b54263ba.mov

It also fixes a bug where the flyout when opened wasn't unmounted when
navigating away from a page and back to it as seen here:

The bug:

https://user-images.githubusercontent.com/17211684/236333550-b41925f9-a06c-4aa9-931b-beecf4c9ae9b.mov

With the fix:

https://user-images.githubusercontent.com/17211684/236334123-a0e3169e-2ec8-4754-92d2-65f2f369fa4f.mov

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 1b40216)
kibanamachine added a commit that referenced this issue May 9, 2023
@kibanamachine @michaelolo24
[8.8] [Security Solution][Investigations] - fix opening flyout, and c…
57f0a68 
…lear filters (#156702) (#156984)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Security Solution][Investigations] - fix opening flyout, and clear
filters (#156702)](#156702)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Michael
Olorunnisola","email":"michael.olorunnisola@elastic.co"},"sourceCommit":{"committedDate":"2023-05-08T12:29:20Z","message":"[Security
Solution][Investigations] - fix opening flyout, and clear filters
(#156702)\n\n## Summary\r\n\r\nThis PR fixes the following
issue\r\nhttps://github.com//issues/156590 where a
users\r\nconfiguration for their alert page filters can prevent them
from seeing\r\nthe alert in the table. In this PR we clear the filters
to only show the\r\nrequired status filter, with no selection, to rely
primarily on the kql\r\nquery filter for the alert id.\r\n\r\nDemo:
\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236332095-ac5583ec-6b5f-4ee2-9c23-9391b54263ba.mov\r\n\r\n\r\nIt
also fixes a bug where the flyout when opened wasn't unmounted
when\r\nnavigating away from a page and back to it as seen
here:\r\n\r\nThe
bug:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236333550-b41925f9-a06c-4aa9-931b-beecf4c9ae9b.mov\r\n\r\nWith
the
fix:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236334123-a0e3169e-2ec8-4754-92d2-65f2f369fa4f.mov\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"1b40216e781b4bcd4d1bf5180aa505c266b29082","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:medium","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Investigations","v8.8.0","v8.9.0"],"number":156702,"url":"https://github.com/elastic/kibana/pull/156702","mergeCommit":{"message":"[Security
Solution][Investigations] - fix opening flyout, and clear filters
(#156702)\n\n## Summary\r\n\r\nThis PR fixes the following
issue\r\nhttps://github.com//issues/156590 where a
users\r\nconfiguration for their alert page filters can prevent them
from seeing\r\nthe alert in the table. In this PR we clear the filters
to only show the\r\nrequired status filter, with no selection, to rely
primarily on the kql\r\nquery filter for the alert id.\r\n\r\nDemo:
\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236332095-ac5583ec-6b5f-4ee2-9c23-9391b54263ba.mov\r\n\r\n\r\nIt
also fixes a bug where the flyout when opened wasn't unmounted
when\r\nnavigating away from a page and back to it as seen
here:\r\n\r\nThe
bug:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236333550-b41925f9-a06c-4aa9-931b-beecf4c9ae9b.mov\r\n\r\nWith
the
fix:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236334123-a0e3169e-2ec8-4754-92d2-65f2f369fa4f.mov\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"1b40216e781b4bcd4d1bf5180aa505c266b29082"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156702","number":156702,"mergeCommit":{"message":"[Security
Solution][Investigations] - fix opening flyout, and clear filters
(#156702)\n\n## Summary\r\n\r\nThis PR fixes the following
issue\r\nhttps://github.com//issues/156590 where a
users\r\nconfiguration for their alert page filters can prevent them
from seeing\r\nthe alert in the table. In this PR we clear the filters
to only show the\r\nrequired status filter, with no selection, to rely
primarily on the kql\r\nquery filter for the alert id.\r\n\r\nDemo:
\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236332095-ac5583ec-6b5f-4ee2-9c23-9391b54263ba.mov\r\n\r\n\r\nIt
also fixes a bug where the flyout when opened wasn't unmounted
when\r\nnavigating away from a page and back to it as seen
here:\r\n\r\nThe
bug:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236333550-b41925f9-a06c-4aa9-931b-beecf4c9ae9b.mov\r\n\r\nWith
the
fix:\r\n\r\n\r\nhttps://user-images.githubusercontent.com/17211684/236334123-a0e3169e-2ec8-4754-92d2-65f2f369fa4f.mov\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"1b40216e781b4bcd4d1bf5180aa505c266b29082"}}]}]
BACKPORT-->

Co-authored-by: Michael Olorunnisola <michael.olorunnisola@elastic.co>
@michaelolo24
Copy link
Contributor

@logeekal closing this as this issue was fixed in 8.8, please feel free to re-open if you see this behavior again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelolo24 michaelolo24

Labels
bug Fixes for quality problems that affect the customer experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@logeekal @elasticmachine @michaelolo24