Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Window Maintenance] Add window maintenance column to rule logs and rule tables #153775

Closed
doakalexi opened this issue Mar 27, 2023 · 1 comment · Fixed by #155333
Closed

[ResponseOps][Window Maintenance] Add window maintenance column to rule logs and rule tables #153775

doakalexi opened this issue Mar 27, 2023 · 1 comment · Fixed by #155333
Assignees
@JiaweiWu
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0

Comments

@doakalexi
Copy link
Contributor

  • Add a column to show window maintenance on the new and old alert table

  • Add a new column in rule logs (maybe connector logs too) to show when a rule execution was under window maintenance
@doakalexi doakalexi added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Mar 27, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@doakalexi doakalexi mentioned this issue Mar 27, 2023
Closed
31 tasks
@doakalexi doakalexi moved this from Awaiting Triage to Todo in AppEx: ResponseOps - Execution & Connectors Mar 29, 2023
@mikecote mikecote moved this from Todo to Blocked / On hold in AppEx: ResponseOps - Execution & Connectors Apr 3, 2023
@JiaweiWu JiaweiWu self-assigned this Apr 18, 2023
@JiaweiWu JiaweiWu moved this from Awaiting Triage to In Progress in AppEx: ResponseOps - Rules & Alerts Management Apr 18, 2023
@JiaweiWu JiaweiWu added Feature:Alerting/RulesManagement Issues related to the Rules Management UX v8.8.0 labels Apr 19, 2023
@JiaweiWu JiaweiWu mentioned this issue Apr 20, 2023
Merged
1 task
@JiaweiWu JiaweiWu moved this from In Progress to In Review in AppEx: ResponseOps - Rules & Alerts Management Apr 20, 2023
JiaweiWu added a commit that referenced this issue Apr 21, 2023
@JiaweiWu @lcawl @kibanamachine
[RAM] Add window maintenance column to rule logs and rule tables (#15…
9bb127f 
…5333)

## Summary
Resolves: #153775

This PR adds the `maintenance_window_id` column to the following tables:

## O11Y/Security solutions Alerts table

![o11y-alerts-table](https://user-images.githubusercontent.com/74562234/233227165-03c105d9-3890-4462-91ec-cd7c6ad26d7b.png)

## Rule details alerts table

![rule_details_maintenance_window_ids](https://user-images.githubusercontent.com/74562234/233226920-6f903ddf-401f-49e7-bb9c-9a36334fc7ce.png)

## Rule run event log

![rule_event_log_maintenance_window](https://user-images.githubusercontent.com/74562234/233226784-c6e804e6-eabe-4500-b51a-aae7aafbcff1.png)

## To test:
1. Set `ENABLE_MAINTENANCE_WINDOWS` to true in
`x-pack/plugins/alerting/public/plugin.ts`
2. Create 1 or more active maintenance windows in stack management
3. Create a rule, trigger some alerts
4. Go to the rule details page alerts table, assert the `maintenance
window` column is there, and renders the maintenance window ids
5. Go to the rule details page event log table, assert the `maintenance
window` column can enabled, and renders the maintenance window ids
6. Create a O11Y rule, trigger some alerts
7. Go to the O11Y alerts table, assert that the `maintenance_window_id`
field can be enabled, and renders the maintenance window ids
### Checklist
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@lcawl lcawl mentioned this issue May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiaweiWu JiaweiWu

Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.8.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RAM] Add window maintenance column to rule logs and rule tables JiaweiWu/kibana
3 participants
@elasticmachine @JiaweiWu @doakalexi