Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Allow project monitors to be configured with throttling disabled #148344

Closed
vigneshshanmugam opened this issue Jan 3, 2023 · 2 comments · Fixed by #148669
Closed

[Uptime] Allow project monitors to be configured with throttling disabled #148344

vigneshshanmugam opened this issue Jan 3, 2023 · 2 comments · Fixed by #148669
Assignees
@justinkambic
Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@vigneshshanmugam
Copy link
Member

Kibana version: 8.6.0

Describe the bug:

Setting throttling: false in project monitor settings or in Synthetics config file throws error when pushing monitors to Monitor Management.

Steps to reproduce:

  1. Set up a new synthetics project - npx @elastic/synthetics init
  2. Change the monitor config in synthetics.config.ts with the following
"monitor": {
   throttling: false
}
  1. Run npx @elastic/synthetics push - Check the error on the stdout.
   > Failed to save or update monitor. Configuration is not valid: monitor(test-example-journey)
       Invalid value "false" supplied to "throttling"

Expected behavior:
Should allow setting throttling to false to disable throttling.

Any additional context:
Bug on the syntheitcs agent side - elastic/synthetics#689
@vigneshshanmugam vigneshshanmugam added the bug Fixes for quality problems that affect the customer experience label Jan 3, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 3, 2023
@vigneshshanmugam vigneshshanmugam added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jan 3, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 3, 2023
@vigneshshanmugam vigneshshanmugam mentioned this issue Jan 3, 2023
Merged
@dominiqueclarke dominiqueclarke self-assigned this Jan 10, 2023
@dominiqueclarke dominiqueclarke mentioned this issue Jan 10, 2023
Merged
dominiqueclarke added a commit that referenced this issue Jan 11, 2023
@dominiqueclarke
[Synthetics] allow disabling throttling for project monitors (#148669)
04c5e65 
## Summary

Resolves #148344

Allows for disabling throttling by adjusting the request types for
project monitors

### Testing
1. Checkout the synthetics agent PR. Be sure to link the development
version of the package to the your test project directory via `npm
link`. If you don't already have a test directory, create one via `npm
run init`.
2. In a test project monitor, set `monitor.use({ throttling: false })`. 
3. Ensure no errors are reported back to the synthetics agent. 
4. In Uptime, navigate to the edit monitor page for the monitor you're
testing. Scroll down to Advanced browser options. Open the accordion and
confirm throttling is disabled
<img width="1752" alt="Screen Shot 2023-01-10 at 2 20 24 PM"
src="https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 11, 2023
@dominiqueclarke
[Synthetics] allow disabling throttling for project monitors (elastic…
9302cf7 
…#148669)

## Summary

Resolves elastic#148344

Allows for disabling throttling by adjusting the request types for
project monitors

### Testing
1. Checkout the synthetics agent PR. Be sure to link the development
version of the package to the your test project directory via `npm
link`. If you don't already have a test directory, create one via `npm
run init`.
2. In a test project monitor, set `monitor.use({ throttling: false })`.
3. Ensure no errors are reported back to the synthetics agent.
4. In Uptime, navigate to the edit monitor page for the monitor you're
testing. Scroll down to Advanced browser options. Open the accordion and
confirm throttling is disabled
<img width="1752" alt="Screen Shot 2023-01-10 at 2 20 24 PM"
src="https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png">

(cherry picked from commit 04c5e65)
kibanamachine referenced this issue Jan 11, 2023
@kibanamachine @dominiqueclarke
[8.6] [Synthetics] allow disabling throttling for project monitors (#…
0b082e6 
…148669) (#148742)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Synthetics] allow disabling throttling for project monitors
(#148669)](#148669)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dominique
Clarke","email":"dominique.clarke@elastic.co"},"sourceCommit":{"committedDate":"2023-01-11T15:59:41Z","message":"[Synthetics]
allow disabling throttling for project monitors (#148669)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/148344\r\n\r\nAllows for
disabling throttling by adjusting the request types for\r\nproject
monitors\r\n\r\n### Testing\r\n1. Checkout the synthetics agent PR. Be
sure to link the development\r\nversion of the package to the your test
project directory via `npm\r\nlink`. If you don't already have a test
directory, create one via `npm\r\nrun init`.\r\n2. In a test project
monitor, set `monitor.use({ throttling: false })`. \r\n3. Ensure no
errors are reported back to the synthetics agent. \r\n4. In Uptime,
navigate to the edit monitor page for the monitor you're\r\ntesting.
Scroll down to Advanced browser options. Open the accordion
and\r\nconfirm throttling is disabled\r\n<img width=\"1752\"
alt=\"Screen Shot 2023-01-10 at 2 20 24
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png\">","sha":"04c5e656e29b90d0d4e59853f2172db6e02b0b77","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:uptime","v8.7.0","v8.6.1"],"number":148669,"url":"https://github.com/elastic/kibana/pull/148669","mergeCommit":{"message":"[Synthetics]
allow disabling throttling for project monitors (#148669)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/148344\r\n\r\nAllows for
disabling throttling by adjusting the request types for\r\nproject
monitors\r\n\r\n### Testing\r\n1. Checkout the synthetics agent PR. Be
sure to link the development\r\nversion of the package to the your test
project directory via `npm\r\nlink`. If you don't already have a test
directory, create one via `npm\r\nrun init`.\r\n2. In a test project
monitor, set `monitor.use({ throttling: false })`. \r\n3. Ensure no
errors are reported back to the synthetics agent. \r\n4. In Uptime,
navigate to the edit monitor page for the monitor you're\r\ntesting.
Scroll down to Advanced browser options. Open the accordion
and\r\nconfirm throttling is disabled\r\n<img width=\"1752\"
alt=\"Screen Shot 2023-01-10 at 2 20 24
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png\">","sha":"04c5e656e29b90d0d4e59853f2172db6e02b0b77"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148669","number":148669,"mergeCommit":{"message":"[Synthetics]
allow disabling throttling for project monitors (#148669)\n\n##
Summary\r\n\r\nResolves
https://github.com/elastic/kibana/issues/148344\r\n\r\nAllows for
disabling throttling by adjusting the request types for\r\nproject
monitors\r\n\r\n### Testing\r\n1. Checkout the synthetics agent PR. Be
sure to link the development\r\nversion of the package to the your test
project directory via `npm\r\nlink`. If you don't already have a test
directory, create one via `npm\r\nrun init`.\r\n2. In a test project
monitor, set `monitor.use({ throttling: false })`. \r\n3. Ensure no
errors are reported back to the synthetics agent. \r\n4. In Uptime,
navigate to the edit monitor page for the monitor you're\r\ntesting.
Scroll down to Advanced browser options. Open the accordion
and\r\nconfirm throttling is disabled\r\n<img width=\"1752\"
alt=\"Screen Shot 2023-01-10 at 2 20 24
PM\"\r\nsrc=\"https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png\">","sha":"04c5e656e29b90d0d4e59853f2172db6e02b0b77"}},{"branch":"8.6","label":"v8.6.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Dominique Clarke <dominique.clarke@elastic.co>
@paulb-elastic paulb-elastic mentioned this issue Jan 11, 2023
Closed
jennypavlova pushed a commit to jennypavlova/kibana that referenced this issue Jan 13, 2023
@dominiqueclarke @jennypavlova
[Synthetics] allow disabling throttling for project monitors (elastic…
3f004d7 
…#148669)

## Summary

Resolves elastic#148344

Allows for disabling throttling by adjusting the request types for
project monitors

### Testing
1. Checkout the synthetics agent PR. Be sure to link the development
version of the package to the your test project directory via `npm
link`. If you don't already have a test directory, create one via `npm
run init`.
2. In a test project monitor, set `monitor.use({ throttling: false })`. 
3. Ensure no errors are reported back to the synthetics agent. 
4. In Uptime, navigate to the edit monitor page for the monitor you're
testing. Scroll down to Advanced browser options. Open the accordion and
confirm throttling is disabled
<img width="1752" alt="Screen Shot 2023-01-10 at 2 20 24 PM"
src="https://user-images.githubusercontent.com/11356435/211642237-de2d0ba3-2822-4ad4-beb4-a4404b9caae9.png">
@justinkambic
Copy link
Contributor

Post-FF Testing LGTM

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinkambic justinkambic

Labels
bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Synthetics] allow disabling throttling for project monitors dominiqueclarke/kibana
4 participants
@vigneshshanmugam @dominiqueclarke @elasticmachine @justinkambic