Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actionable Observability] - Add alert annotation and threshold shade on the APM latency chart on the Alert Details page #147779

Closed
Tracked by #138645
fkanout opened this issue Dec 19, 2022 · 1 comment · Fixed by #147848
Closed
Tracked by #138645

[Actionable Observability] - Add alert annotation and threshold shade on the APM latency chart on the Alert Details page #147779

fkanout opened this issue Dec 19, 2022 · 1 comment · Fixed by #147848
Labels
release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0

Comments

@fkanout
Copy link
Contributor

fkanout commented Dec 19, 2022 •
edited
Loading

📝 Summary

Part of #138645
For the APM rule type Latency threshold, we need to add alert annotation (when the alert started) and the red shade (the threshold)

Design https://www.figma.com/file/son9gUxOUGJVGAmVxYhsgn/Alert-landing-page?node-id=1800%3A249035&t=wZoo6TF7npk0r5MG-0

Screenshot 2022-12-19 at 17 17 04

✅ ACs

  • Only show the alert annotation and alert threshold for the Latency threshold rule
@fkanout fkanout added release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0 labels Dec 19, 2022
@fkanout fkanout self-assigned this Dec 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@fkanout fkanout changed the title [Actionable Observability] - Add alert annotation and threshold shade on the latency chart on the Alert Details page [Actionable Observability] - Add alert annotation and threshold shade on the APM latency chart on the Alert Details page Dec 19, 2022
This was referenced Dec 20, 2022
Merged
Closed
fkanout added a commit that referenced this issue Jan 9, 2023
@fkanout
[Actionable Observability] - Add alert annotation and threshold shade…
12ae75f 
… on the APM latency chart on the Alert Details page (#147848)

## Summary

Closes #147779 by adding the following elements to the latency chart for
the Latency threshold alert:

1. Alert annotation that indicates when the alert is triggered 
2. Alert threshold rect (shade) 
3. Alert threshold annotation (red line on Y axe)
4. Alert active rect (dark red shade where the alert is active)


![image](https://user-images.githubusercontent.com/6838659/208887316-b1848d92-4ee5-4b3e-97e0-1342fb25d3fa.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release_note:feature Makes this part of the condensed release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.7.0
Projects
None yet
Milestone
No milestone
2 participants
@fkanout @elasticmachine