Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 1 - Case Fields should post case on submit click #146394

Closed
kibanamachine opened this issue Nov 28, 2022 · 14 comments · Fixed by #157380, #177590 or #178370
Closed

Failing test: Jest Tests.x-pack/plugins/cases/public/components/create - Create case Step 1 - Case Fields should post case on submit click #146394

kibanamachine opened this issue Nov 28, 2022 · 14 comments · Fixed by #157380, #177590 or #178370
Assignees
@cnasikas
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 28, 2022 •
edited
Loading

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 5000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/form_context.test.tsx:201:5
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:98:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:60:5)
    at /var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/form_context.test.tsx:181:3
    at _dispatchDescribe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:98:26)
    at describe (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/index.js:60:5)
    at Object.<anonymous> (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/x-pack/plugins/cases/public/components/create/form_context.test.tsx:140:1)
    at Runtime._execModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1646:24)
    at Runtime._loadModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1185:12)
    at Runtime.requireModule (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-runtime/build/index.js:1009:12)
    at jestAdapter (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:13)
    at runTestInternal (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:389:16)
    at runTest (/var/lib/buildkite-agent/builds/kb-n2-4-spot-ef1231d46a9dd1b4/elastic/kibana-on-merge/kibana/node_modules/jest-runner/build/runTest.js:475:34)

First failure: CI Build - 8.6
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Nov 28, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 28, 2022
@kibanamachine kibanamachine added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 28, 2022
@cnasikas cnasikas added the Feature:Cases Cases feature label Nov 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

@tylersmalley
Copy link
Contributor

/skip

@cnasikas cnasikas self-assigned this Jan 10, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.6

jbudz added a commit that referenced this issue Jan 17, 2023
@jbudz
skip flaky suite (#146394)
ef830ca
@jbudz
Copy link
Member

jbudz commented Jan 17, 2023

Skipped

8.6: ef830ca

@cnasikas cnasikas mentioned this issue Feb 12, 2023
Closed
2 tasks
@cnasikas cnasikas linked a pull request Feb 12, 2023 that will close this issue
[Cases] Fix case creation flaky tests #150960
Closed
2 tasks
@cnasikas cnasikas mentioned this issue May 14, 2023
Merged
3 tasks
@cnasikas cnasikas removed a link to a pull request May 14, 2023
[Cases] Fix case creation flaky tests #150960
Closed
2 tasks
@cnasikas cnasikas linked a pull request May 14, 2023 that will close this issue
[Cases] Refactor connectors to use the form lib #157380
Merged
3 tasks
cnasikas added a commit that referenced this issue May 22, 2023
@cnasikas @kibanamachine
[Cases] Refactor connectors to use the form lib (#157380)
df14a76 
## Summary

This PR converts all connector forms to use the form lib.

Fixes: #133467,
#143408,
#146394

## Notable changes
- All connector's hooks were converted to use React Query
- All connector's forms were converted to use the Kibana Form Lib
- The form of fields of the connector and the preview of the fields of
the connector got separated
- All connector logic in the case view page moved on its own component
- Improve loading visualization on the first render
- Jira: Issue type is not selected automatically
- Jira: Added validation for the issue type field
- ServiceNow: Subcategory is visible

## Testing scenarios

- Create a case with no connectors. Press "Add connector". The Save
button should be disabled
- Create a case (or edit an existing one) with a connector. Press the
edit pencil. The Save button should be disabled
- Create a case (or edit an existing one) with a connector. Press the
edit pencil. Change a field or a connector. The Save button should not
be disabled
- Change various connectors and their fields on a case. The fields
should be preserved between changes
- Change various connectors and their fields on a case
- Test the forms of all supported connectors in the create case and the
view case page
- Push all supported connectors in the create case and the view case
page and verify it is working as expected
- Optional fields can be pushed correctly
- Check that the fields are being reset when changing connectors of the
same type (Jira for example)
- Test that connectors work in the create case form when attaching
outside of Cases (ML for example)
- Jira: Try to submit without an issue type selected. You should see an
error
- ServiceNow: Test that the subcategory is being reset when you change
the category.

## Flaky tests

The PR fixes the flaky tests in
`x-pack/plugins/cases/public/components/create/form_context.test.tsx`. I
run the test multiple times on CI to ensure that the test is not flaky
anymore: Specifically:
- Test run 50 times in
f220cc3
- Test run 55 times in
6221314
- Test run 50 times in
9155163

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
delanni pushed a commit to delanni/kibana that referenced this issue May 25, 2023
@cnasikas @kibanamachine @delanni
[Cases] Refactor connectors to use the form lib (elastic#157380)
6db49fe 
## Summary

This PR converts all connector forms to use the form lib.

Fixes: elastic#133467,
elastic#143408,
elastic#146394

## Notable changes
- All connector's hooks were converted to use React Query
- All connector's forms were converted to use the Kibana Form Lib
- The form of fields of the connector and the preview of the fields of
the connector got separated
- All connector logic in the case view page moved on its own component
- Improve loading visualization on the first render
- Jira: Issue type is not selected automatically
- Jira: Added validation for the issue type field
- ServiceNow: Subcategory is visible

## Testing scenarios

- Create a case with no connectors. Press "Add connector". The Save
button should be disabled
- Create a case (or edit an existing one) with a connector. Press the
edit pencil. The Save button should be disabled
- Create a case (or edit an existing one) with a connector. Press the
edit pencil. Change a field or a connector. The Save button should not
be disabled
- Change various connectors and their fields on a case. The fields
should be preserved between changes
- Change various connectors and their fields on a case
- Test the forms of all supported connectors in the create case and the
view case page
- Push all supported connectors in the create case and the view case
page and verify it is working as expected
- Optional fields can be pushed correctly
- Check that the fields are being reset when changing connectors of the
same type (Jira for example)
- Test that connectors work in the create case form when attaching
outside of Cases (ML for example)
- Jira: Try to submit without an issue type selected. You should see an
error
- ServiceNow: Test that the subcategory is being reset when you change
the category.

## Flaky tests

The PR fixes the flaky tests in
`x-pack/plugins/cases/public/components/create/form_context.test.tsx`. I
run the test multiple times on CI to ensure that the test is not flaky
anymore: Specifically:
- Test run 50 times in
elastic@f220cc3
- Test run 55 times in
elastic@6221314
- Test run 50 times in
elastic@9155163

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine reopened this Sep 8, 2023
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - main

jbudz added a commit that referenced this issue Sep 20, 2023
@jbudz
skip failing test suite (#146394)
737aaf3
@jbudz
Copy link
Member

jbudz commented Sep 20, 2023

Skipped

main: 737aaf3

gergoabraham pushed a commit to gergoabraham/kibana that referenced this issue Sep 21, 2023
@jbudz @gergoabraham
skip failing test suite (elastic#146394)
7efed96
@cnasikas cnasikas mentioned this issue Oct 9, 2023
Closed
2 tasks
@cnasikas cnasikas mentioned this issue Feb 22, 2024
Merged
2 tasks
fkanout pushed a commit to fkanout/kibana that referenced this issue Mar 4, 2024
@cnasikas @fkanout
[Cases] Unskip flyout and custom fields flaky tests (elastic#177590)
641a37e 
## Summary

PR elastic#176863 improved the cases
context provided which we assumed caused some flakiness in our tests. I
am unskipping a couple of tests to test if the changes on that PR
stabilized the tests.

Fixes elastic#176805
Fixes elastic#174528
Fixes elastic#174527
Fixes elastic#174526
Fixes elastic#174525
Fixes elastic#176600
Fixes elastic#146394


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
@js-jankisalvi js-jankisalvi mentioned this issue Mar 11, 2024
Merged
1 task
js-jankisalvi added a commit that referenced this issue Mar 11, 2024
@js-jankisalvi
[Cases] Unskip flaky tests (#178370)
8be837a 
## Summary

This PR unskip below flaky tests to confirm the fix made in
#177798

Fixes #174682
Fixes #176336
Fixes #177334
Fixes #171600
Fixes #171601
Fixes #177791
Fixes #177792
Fixes #177793
Fixes #177794
Fixes #177795
Fixes #177796
Fixes #171605
Fixes #171606
Fixes #171607
Fixes #171608
Fixes #178119
Fixes #174525
Fixes #174526
Fixes #174527
Fixes #174528
Fixes #146394
Fixes #176805
Fixes #175112
Fixes #176671
Fixes #176672
Fixes #175841
Fixes #174667
Fixes #174384
Fixes #175310


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnasikas cnasikas

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Feature:Cases Cases feature Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
5 participants
@tylersmalley @jbudz @cnasikas @elasticmachine @kibanamachine