-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/responder·ts - endpoint Response Actions Responder from timeline should show Responder from alert in a timeline #139260
Comments
Pinging @elastic/security-solution (Team: SecuritySolution) |
@paul-tavares can you take a look? |
Hey @spalger , Wondering if you might have some insight here. The failure seems to be happening in a Global This same error also just got reported today on a different test - here (build failure here). I checked out code for these tests and we don't have global |
New failure: CI Build - main |
The output is a bit verbose, but the failure line lists the test which was executing when the error was caught The error message
This does two actions, and if the element with
This handle the error by re-fetching the element using the same selection if the click fails. |
Ohhh... This is good info. on the differences between those two approached. I know for sure in some cases I am using the approach that you mention might lead to this Thank you @spalger 🙏 |
PR merged. Lets see what happens. :) |
New failure: CI Build - main |
Failed within 4 hours of merging the PR 😬 That's not great |
So, I took a look at the kibana/test/functional/services/common/find.ts Lines 288 to 301 in 71b9ed4
Unfortunately |
Opened #139964 to fix this |
Fixed by #139964 |
Thank you for looking at this @spalger ! |
Thanks @spalger . Appreciate you taking a look. |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
Skipped main: 404c359 |
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
New failure: CI Build - main |
## Summary Fixes and un-skips a test. Ensures that the test data doesn't create an existing index. If it still does, as a temp. measure we're dismissing the error toast that is blocking the button so the rest of the test can continue. closes /issues/139260 **flakey test runner** https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3036 x 200 ( all green) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
## Summary Fixes and un-skips a test. Ensures that the test data doesn't create an existing index. If it still does, as a temp. measure we're dismissing the error toast that is blocking the button so the rest of the test can continue. closes elastic/issues/139260 **flakey test runner** https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3036 x 200 ( all green) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit ada6671)
…) (#165559) # Backport This will backport the following commits from `main` to `8.10`: - [[Security Solution][Endpoint] Fix and unskip flaky test (#165466)](#165466) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-09-04T07:43:47Z","message":"[Security Solution][Endpoint] Fix and unskip flaky test (#165466)\n\n## Summary\r\n\r\nFixes and un-skips a test. Ensures that the test data doesn't create an\r\nexisting index. If it still does, as a temp. measure we're dismissing\r\nthe error toast that is blocking the button so the rest of the test can\r\ncontinue.\r\n\r\ncloses /issues/139260\r\n\r\n**flakey test runner**\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3036\r\nx 200 ( all green)\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ada6671165ecfc2c27014fa0aa43c58ed8e965df","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","OLM Sprint","v8.10.0","v8.11.0"],"number":165466,"url":"https://github.com/elastic/kibana/pull/165466","mergeCommit":{"message":"[Security Solution][Endpoint] Fix and unskip flaky test (#165466)\n\n## Summary\r\n\r\nFixes and un-skips a test. Ensures that the test data doesn't create an\r\nexisting index. If it still does, as a temp. measure we're dismissing\r\nthe error toast that is blocking the button so the rest of the test can\r\ncontinue.\r\n\r\ncloses /issues/139260\r\n\r\n**flakey test runner**\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3036\r\nx 200 ( all green)\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ada6671165ecfc2c27014fa0aa43c58ed8e965df"}},"sourceBranch":"main","suggestedTargetBranches":["8.10"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/165466","number":165466,"mergeCommit":{"message":"[Security Solution][Endpoint] Fix and unskip flaky test (#165466)\n\n## Summary\r\n\r\nFixes and un-skips a test. Ensures that the test data doesn't create an\r\nexisting index. If it still does, as a temp. measure we're dismissing\r\nthe error toast that is blocking the button so the rest of the test can\r\ncontinue.\r\n\r\ncloses /issues/139260\r\n\r\n**flakey test runner**\r\n\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3036\r\nx 200 ( all green)\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"ada6671165ecfc2c27014fa0aa43c58ed8e965df"}}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
## Summary Fixes and un-skips a test. Ensures that the test data doesn't create an existing index. If it still does, as a temp. measure we're dismissing the error toast that is blocking the button so the rest of the test can continue. closes elastic/issues/139260 **flakey test runner** https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3036 x 200 ( all green) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
A test failed on a tracked branch
First failure: CI Build - main
The text was updated successfully, but these errors were encountered: