-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rules] Add validation to prevent selecting a data view without a time field in "Elasticsearch query" rule flyout #135806
Comments
Pinging @elastic/response-ops (Team:ResponseOps) |
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
@jughosta this looks fixed to me, want to check it and close it out if so? Just making sure I hadn't misunderstood any details. Cheers. |
@EricDavisX The issue is still reproducible. |
Thanks, I must be looking at a different use case / work flow. Carry on, then. Cheers |
Upgrading the issue to a bug, because it allows users to create invalid alert rule. The bugfix should prevent this by adding a message to the user, and preventing the saving of a data view without a time field. A potential follow up issue could be, to enhance the data view picker to don't allow creating data views without timefield if the component is configured that way. This should not change the way the data view picker works by default. |
…/ editing (#146324) ## Summary Closes #135806 This PR adds optional `timeField` param for Discover alert and adding validation data view if it time based.  ### How to test - Open `Alerts` in Discover - Select non time based data view - Try to save the rule. You should see error message. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
…/ editing (elastic#146324) ## Summary Closes elastic#135806 This PR adds optional `timeField` param for Discover alert and adding validation data view if it time based.  ### How to test - Open `Alerts` in Discover - Select non time based data view - Try to save the rule. You should see error message. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Kibana version: main (8.4)
Description of the problem including expected versus actual behavior:
Currently we allow to select a data view without a time field which results in a broken rule.
Steps to reproduce:
Expected:
A validation message that such rule can't be created based on a data view without a time field. Or we disable selecting such data views in the chooser component.
Originally posted in #134763 (review)
The text was updated successfully, but these errors were encountered: