Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] "Filter In", "Filter Out" and "Show top values" are not working for alerts table Data under cases. #134442

Closed
Tracked by #144943
ghost opened this issue Jun 15, 2022 · 18 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0

Comments

@ghost
Copy link

ghost commented Jun 15, 2022

Describe the bug:
"Filter In", "Filter Out" and "Show top values" are not working for alerts table Data under cases.

Build Details:

Version:8.3.0 BC4
Commit:875ea184462f73a04410981ac9eaf799db28b4f0
Build:53413

Preconditions

  1. Elasticsearch should be up and running
  2. Kibana should be up and running
  3. Alerts should be present on environment.

Steps to Reproduce

  1. Navigate to Security--> Alerts
  2. Select multiple alerts.
  3. Attach selected alerts to a case.
  4. Navigate to Security--> Cases.
  5. Open the Case and click on Alerts tab.
  6. Use "Filter In", "Filter Out" and "Show top values" on alerts table data.

Expected Result
"Filter In", "Filter Out" and "Show top values" should work on alerts table data.

Actual Result
"Filter In", "Filter Out" and "Show top values" is not working on alerts table data.

Screen Records

Cases.-.Kibana.-.Google.Chrome.2022-06-15.15-44-03.mp4
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.3.0 labels Jun 15, 2022
@ghost ghost self-assigned this Jun 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@ghost ghost removed their assignment Jun 15, 2022
@ghost ghost added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Jun 15, 2022
@ghost ghost assigned cnasikas Jun 15, 2022
@cnasikas cnasikas added the Feature:Cases Cases feature label Jun 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jun 15, 2022
@cnasikas
Copy link
Member

@kqualters-elastic Does it make sense to filter in the alerts table inside cases?

@kqualters-elastic
Copy link
Contributor

if we add the query bar maybe, without it, no imo.

@cnasikas
Copy link
Member

cnasikas commented Jun 15, 2022

Thanks! There is no plan to add a query bar in Cases at the moment. I think this is related to how the security solution registers the alerts' table configuration. Who should I assign for?

cc @XavierM

@cnasikas cnasikas assigned michaelolo24 and unassigned cnasikas Jun 21, 2022
@cnasikas
Copy link
Member

@michaelolo24 Any update on this?

@michaelolo24 michaelolo24 assigned XavierM and unassigned michaelolo24 Jun 21, 2022
@michaelolo24
Copy link
Contributor

@cnasikas sorry was out on vacation when this came in, but I pinged @XavierM about it

@XavierM
Copy link
Contributor

XavierM commented Jun 21, 2022

I will remove this filtering from the cell actions

@abo1787
Copy link

abo1787 commented May 15, 2023

Removal of this functionality has negatively impacted the ability to filter inside the security > explore > hosts panel (the CMD integration that was brought into Elastic). Also it notes this ticket is still open, how did this function (removal of the filtering) get merged into a mainline branch that's impacting my 8.7.1 deployment if this ticket is still open?

We rely on this ability to filter our session data. We have a query bar on that application. It seems this was removed from the wrong section, or it has some negative regression on another section it shouldn't have ... Either way as an enterprise customer seeing an open ticket noted as the breaking change that removed functionality in an elastic cloud deployment running the latest version of code looks like a major security hole. Are you deploying non production versions to your cloud deploy base, or do you have customers running on improperly vetted code? At a minimum I'd expect the ticket to be closed on our side (and merged on your side though I don't think I could see that) before it gets deployed to a customer.

Please add this capability back in, and remove it only from the alerts panel where it wasn't working. It was working properly where we needed it and can no longer quickly filter without building a filter in the query bar.

@machadoum
Copy link
Member

machadoum commented May 15, 2023

Hi @abo1787,

Thank you for reporting this issue!

I can reproduce that "Filter In" and "Filter Out" actions are absent from Hosts/Session and Alerts/Cases on 8.7.1.

The bug you found isn't related to this ticket. The ticket is still open because we haven't merged the branch yet. Another change caused this regression bug.

I apologize for any inconvenience you may have faced and assure you that we are working to resolve it.


Update: The bug shall get fixed on version 8.8

@cnasikas
Copy link
Member

cnasikas commented May 16, 2023

Hi @abo1787,

As @machadoum said, this issue is unrelated to your problem. It is still open because we did not fix it. What you encountered is a bug introduced in 8.7. I can ensure you that there is no way to have code from the main branch (non-production) to cloud deployments. Sorry for the inconvenience.

@cnasikas cnasikas removed the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label May 16, 2023
@semd semd added Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting:Explore labels May 16, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd
Copy link
Contributor

semd commented May 16, 2023

I don't have the capacity to take it, but an easy fix would be to conditionally add FILTER as disabledActionTypes at:

return {
triggerId: SecurityCellActionsTrigger.DEFAULT,
fields,
metadata: {
// cell actions scope
scopeId: tableId,
},
dataGridRef,
};

like this:

      const disabledActionTypes =
        tableId === TableId.alertsOnCasePage ? [SecurityCellActionType.FILTER] : undefined;

      return {
        triggerId: SecurityCellActionsTrigger.DEFAULT,
        fields,
        metadata: {
          // cell actions scope
          scopeId: tableId,
        },
        dataGridRef,
        disabledActionTypes,
      };

This should hide filter actions in the Cases alerts table

@abo1787
Copy link

abo1787 commented May 16, 2023

Thank you for confirming that the two issues are not related. I'll follow up with my support ticket that landed me here and see if he can link me to the bug in question that caused my actual problem.

machadoum added a commit that referenced this issue Jul 5, 2023
… fix show_top_n action (#161150)

issue #134442

## Summary

* Remove filter actions from the cases alerts page because it has no
search bar (as suggested by Sergi).
* Fix the `show_top_n` action not executing from inside a table cell
* Fix the `show_top_n` action not preselecting alerts on the cases
alerts table

Warning: `show_top_n` uses the global `timerange` but the cases page
doesn't have the time range picker.
@machadoum machadoum added the fixed label Jul 5, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Hi Team,

we have validated this issue on main and found the issue to be fixed. Filter in and Filter out action are now not showing and show top is now started working.

Observations:

image

However, in the show top n modal incorrect count Showing:115 alerts is showing ❌

video1573097995.mp4

thanks!!

c.c @MadameSheema

@machadoum
Copy link
Member

machadoum commented Jul 28, 2023

Hey Karanbir, thank you for reviewing it. Can you tell me why it's wrong and what the expected behavior is?

At the moment, this component displays all alerts in the global time range. If we want it to only display alerts within a case, we'll need to submit a feature request.

@ghost
Copy link

ghost commented Jul 28, 2023

ok @machadoum thanks for clearing the time range for which seeing the alert count on show top modal.

We can close this ticket as this is fixed ✔️

thanks !!

@ghost ghost closed this as completed Jul 28, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Cases Cases feature fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team v8.10.0
Projects
None yet
Development

No branches or pull requests

10 participants