spy pane toggle shown in full screen mode #13340
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Dashboard
Dashboard related features
PR sent
Comments
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this issue
Aug 4, 2017
There is still a bit of a bug here as mentioned in elastic#13340 but it will be fixed separately as it’s also an issue in master
stacey-gammon
added a commit
that referenced
this issue
Aug 8, 2017
* Move dashboard panel rendering logic to each registered type. * Remove dashboard knowledge of click and brush handlers for visualizations Move it to the VisualizeEmbeddableHandler. * merge master with manual changes * No need to use lodash * Add EmbeddableHandler base class * Use correct path to embeddable_handlers_registry * clean up * Set visualize scope uiState that is of type PersistedState, otherwise it won't actually be set. * add retry to loading saved search data * Fix handleError param and remove unnecessary private param * Rename savePanelState updatePanel and return the new object rather than mutating the original * Make ContainerAPI a base class and move the dashboard specific functionality into a new class * Make api's async and clean up documentation * Fix panel tests * Fix bug which broke tests - need to pass container-api to dashboard-panel * Address code comments - Rename onFilter to addFilter - Use angular promises instead of async/await - fix jsdoc - rename createChildUiState to getInitialState * changed the wrong variable name * no need for async or Promise.reject on interface * add tests that will fail due to spy pane issue in this PR * Fix logic with spy pane toggle There is still a bit of a bug here as mentioned in #13340 but it will be fixed separately as it’s also an issue in master * Fix failing test
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this issue
Aug 8, 2017
* Move dashboard panel rendering logic to each registered type. * Remove dashboard knowledge of click and brush handlers for visualizations Move it to the VisualizeEmbeddableHandler. * merge master with manual changes * No need to use lodash * Add EmbeddableHandler base class * Use correct path to embeddable_handlers_registry * clean up * Set visualize scope uiState that is of type PersistedState, otherwise it won't actually be set. * add retry to loading saved search data * Fix handleError param and remove unnecessary private param * Rename savePanelState updatePanel and return the new object rather than mutating the original * Make ContainerAPI a base class and move the dashboard specific functionality into a new class * Make api's async and clean up documentation * Fix panel tests * Fix bug which broke tests - need to pass container-api to dashboard-panel * Address code comments - Rename onFilter to addFilter - Use angular promises instead of async/await - fix jsdoc - rename createChildUiState to getInitialState * changed the wrong variable name * no need for async or Promise.reject on interface * add tests that will fail due to spy pane issue in this PR * Fix logic with spy pane toggle There is still a bit of a bug here as mentioned in elastic#13340 but it will be fixed separately as it’s also an issue in master * Fix failing test
stacey-gammon
added a commit
that referenced
this issue
Aug 8, 2017
* Move dashboard panel rendering logic to each registered type. * Remove dashboard knowledge of click and brush handlers for visualizations Move it to the VisualizeEmbeddableHandler. * merge master with manual changes * No need to use lodash * Add EmbeddableHandler base class * Use correct path to embeddable_handlers_registry * clean up * Set visualize scope uiState that is of type PersistedState, otherwise it won't actually be set. * add retry to loading saved search data * Fix handleError param and remove unnecessary private param * Rename savePanelState updatePanel and return the new object rather than mutating the original * Make ContainerAPI a base class and move the dashboard specific functionality into a new class * Make api's async and clean up documentation * Fix panel tests * Fix bug which broke tests - need to pass container-api to dashboard-panel * Address code comments - Rename onFilter to addFilter - Use angular promises instead of async/await - fix jsdoc - rename createChildUiState to getInitialState * changed the wrong variable name * no need for async or Promise.reject on interface * add tests that will fail due to spy pane issue in this PR * Fix logic with spy pane toggle There is still a bit of a bug here as mentioned in #13340 but it will be fixed separately as it’s also an issue in master * Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The spy pane is supposed to be hidden when the chrome is hidden. Originally this was because the chrome was only hidden in embedded mode, and that was meant for public consumption, so we hid the extra details the spy pane exposes.
When we introduced full screen mode in the menu bar, we didn't revisit this logic, but purely by accident, the spy pane toggle will show when using full screen in the menu. This is because the visualize panel isn't rebuilt when going from full screen to regular mode or back again, and the logic is only touched once.
This isn't a big issue for users, but we should be more explicit about how we want it work, and then be more intentional in our logic.
cc @spalger
The text was updated successfully, but these errors were encountered: