-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Transaction latency distribution should use transaction metrics instead of transaction events #132394
Labels
apm:test-plan-done
Pull request that was successfully tested during the test plan
bug
Fixes for quality problems that affect the customer experience
Team:APM - DEPRECATED
Use Team:obs-ux-infra_services.
v8.4.0
Comments
Pinging @elastic/apm-ui (Team:apm) |
3 tasks
@dannycroft I've added this to 8.4 (I was considering 8.3 but it is a little too late for that I feel) |
ogupte
added a commit
to ogupte/kibana
that referenced
this issue
Jul 11, 2022
ogupte
added a commit
to ogupte/kibana
that referenced
this issue
Jul 19, 2022
ogupte
added a commit
that referenced
this issue
Jul 26, 2022
…36594) * [APM] Adds support for metrics for latency distribution histogram (#132394) * PR feedback * Addresses feedback: - filters by existing duration field for metrics - get duration field and event type by chart type * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * fixed type errors and removed eventType from being passed to to function specifically for latency correlations * addressed PR feedback: - renamed enums to match established pattern - renamed `LatencyDistributionChartType.transactionDetails` to `*.traceSamples` to align with tab label - added explanatory line comments * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * rename `LatencyDistributionChartType.traceSamples` -> `*.transactionLatency` * renamed `LatencyDistributionChartType.dependencyLatency` -> `*.dependencyLatency` * filters the query passed into getOverallLatencyDistribution when using metrics data * fixes appendFilterQuery param types * renames searchAggregatedTransactions -> searchMetrics for latency distribution * removed unnecessary util function `appendFilterQuery`. * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * make the searchMetrics param required * fixes lint issue * moves the duration field filter to append to the given query at the tail functions for latency distribution Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:test-plan-done
Pull request that was successfully tested during the test plan
bug
Fixes for quality problems that affect the customer experience
Team:APM - DEPRECATED
Use Team:obs-ux-infra_services.
v8.4.0
The transaction latency distribution chart on the APM transaction details page is using transaction events (it should be using transaction metrics. This is how it looks if all transaction events are deleted (similar to a sampling rate of 0):
Reproduce problem
Go to APM -> Settings -> Indices and then change "Transaction Indices" to
foo*
.This is equivalent to removing all transaction documents, but is reversible.
The text was updated successfully, but these errors were encountered: