Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL queries with double quotes cause JS to crash #1284

Closed
tchough opened this issue Jun 5, 2014 · 3 comments
Closed

URL queries with double quotes cause JS to crash #1284

tchough opened this issue Jun 5, 2014 · 3 comments
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@tchough
Copy link

tchough commented Jun 5, 2014

Using Kibana 3.0.1:

This works as expected:
/#/dashboard/file/logstash.json?query=@fields.request_id:blah

This causes the browser (Chrome/Linux 34.0.1847.132 official) to error out:
/#/dashboard/file/logstash.json?query=@fields.request_id:%22blah%22

The error (from the javascript console):
TypeError: Cannot read property 'interval' of undefined
at dash_load (https://myserver/app/app.js:21:25997)
at https://myserver/app/app.js:21:28539
at i (https://myserver/app/app.js:9:458)
at i (https://myserver/app/app.js:9:458)
at https://myserver/app/app.js:9:1014
at Object.f.$eval (https://myserver/app/app.js:9:6963)
at Object.f.$digest (https://myserver/app/app.js:9:5755)
at Object.f.$apply (https://myserver/app/app.js:9:7111)
at f (https://myserver/app/app.js:9:11507)
at r (https://myserver/app/app.js:9:13216)

The upshot is values that must be quoted can't be searched for via URL parameters.

@rashidkpc rashidkpc added the bug label Jun 5, 2014
@tchough
Copy link
Author

tchough commented Jun 5, 2014

I've verified that the same issue happens with v3.1.0, also.

@nbrownus
Copy link

nbrownus commented Sep 3, 2014

Any update on when this might be fixed?

@rashidkpc
Copy link
Contributor

We've vastly improved the url encoding in Kibana 4. Values are now encoded and decoded with RISON, which should entirely solve this issue. https://github.com/Nanonid/rison

rbrtj added a commit that referenced this issue Sep 4, 2024
## Summary

Fix for [#1284](elastic/ml-team#1284)


https://github.com/user-attachments/assets/3b829777-4ff9-4272-80dd-d27bccdb9fb5



### Checklist

Delete any items that are not applicable to this PR.

- [X] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

3 participants