Skip to content

Commit

Permalink
fix: onRuleChange
Browse files Browse the repository at this point in the history
  • Loading branch information
logeekal committed Feb 22, 2023
1 parent ef74cb2 commit f79e02e
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface StatefulEventContextType {
timelineID: string;
enableHostDetailsFlyout: boolean;
enableIpDetailsFlyout: boolean;
onRuleChange?: () => void;
}

export const StatefulEventContext = createContext<StatefulEventContextType | null>(null);
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
loading: ruleLoading,
isExistingRule,
} = useRuleWithFallback(ruleId);

const { pollForSignalIndex } = useSignalHelpers();
const [rule, setRule] = useState<Rule | null>(null);
const isLoading = ruleLoading && rule == null;
Expand Down Expand Up @@ -617,10 +618,11 @@ const RuleDetailsPageComponent: React.FC<DetectionEngineComponentProps> = ({
flyoutSize="m"
inputFilters={[...alertMergedFilters, ...groupingFilters]}
tableId={TableId.alertsOnRuleDetailsPage}
onRuleChange={refreshRule}
/>
);
},
[alertMergedFilters]
[alertMergedFilters, refreshRule]
);

const {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ interface DetectionEngineAlertTableProps {
tableId: TableId;
sourcererScope?: SourcererScopeName;
isLoading?: boolean;
onRuleChange?: () => void;
}
export const AlertsTableComponent: FC<DetectionEngineAlertTableProps> = ({
configId,
Expand All @@ -93,6 +94,7 @@ export const AlertsTableComponent: FC<DetectionEngineAlertTableProps> = ({
tableId = TableId.alertsOnAlertsPage,
sourcererScope = SourcererScopeName.detections,
isLoading,
onRuleChange,
}) => {
const { triggersActionsUi, uiSettings } = useKibana().services;

Expand All @@ -108,6 +110,7 @@ export const AlertsTableComponent: FC<DetectionEngineAlertTableProps> = ({
tabType: 'query',
enableHostDetailsFlyout: true,
enableIpDetailsFlyout: true,
onRuleChange,
});
const { browserFields, indexPattern: indexPatterns } = useSourcererDataView(sourcererScope);
const license = useLicense();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
*/

import type { EcsSecurityExtension as Ecs } from '@kbn/securitysolution-ecs';
import React, { useCallback, useMemo } from 'react';
import React, { useCallback, useContext, useMemo } from 'react';
import { useSelector } from 'react-redux';
import type { AlertsTableConfigurationRegistry } from '@kbn/triggers-actions-ui-plugin/public/types';
import { StatefulEventContext } from '../../../common/components/events_viewer/stateful_event_context';
import { eventsViewerSelector } from '../../../common/components/events_viewer/selectors';
import { getDefaultControlColumn } from '../../../timelines/components/timeline/body/control_columns';
import { useLicense } from '../../../common/hooks/use_license';
Expand All @@ -25,6 +26,8 @@ export const getUseActionColumnHook =
const isEnterprisePlus = license.isEnterprise();
const ACTION_BUTTON_COUNT = isEnterprisePlus ? 5 : 4;

const { onRuleChange } = useContext(StatefulEventContext);

const leadingControlColumns = useMemo(
() => [...getDefaultControlColumn(ACTION_BUTTON_COUNT)],
[ACTION_BUTTON_COUNT]
Expand Down Expand Up @@ -57,6 +60,7 @@ export const getUseActionColumnHook =
ecs: alert as Ecs,
data: nonEcsData,
};

return (
<RowAction
columnId={`actions-${rowIndex}`}
Expand All @@ -77,6 +81,7 @@ export const getUseActionColumnHook =
selectedEventIds={selectedEventIds}
setCellProps={cveProps.setCellProps}
showCheckboxes={showCheckboxes}
onRuleChange={onRuleChange}
tabType={'query'}
tableId={tableId}
width={0}
Expand All @@ -92,7 +97,14 @@ export const getUseActionColumnHook =
/>
);
},
[columnHeaders, loadingEventIds, showCheckboxes, leadingControlColumns, selectedEventIds]
[
columnHeaders,
loadingEventIds,
showCheckboxes,
leadingControlColumns,
selectedEventIds,
onRuleChange,
]
);

return {
Expand Down

0 comments on commit f79e02e

Please sign in to comment.