addressing PR comments

elastic · Feb 28, 2021 · f57cd1f · f57cd1f
1 parent 716d1c6
commit f57cd1f
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/...ublic/components/app/service_overview/service_overview_transactions_table/get_columns.tsx b/...ublic/components/app/service_overview/service_overview_transactions_table/get_columns.tsx
@@ -155,19 +155,19 @@ export function getColumns({
       ),
       width: px(unit * 5),
       render: (_, { name }) => {
-        const currenIimpact =
+        const currentImpact =
           transactionGroupComparisonStatistics?.currentPeriod?.[name]?.impact ??
           0;
-        const previousIimpact =
+        const previousImpact =
           transactionGroupComparisonStatistics?.previousPeriod?.[name]
             ?.impact ?? 0;
         return (
           <EuiFlexGroup gutterSize="xs" direction="column">
             <EuiFlexItem>
-              <ImpactBar value={currenIimpact} size="m" />
+              <ImpactBar value={currentImpact} size="m" />
             </EuiFlexItem>
             <EuiFlexItem>
-              <ImpactBar value={previousIimpact} size="s" color="subdued" />
+              <ImpactBar value={previousImpact} size="s" color="subdued" />
             </EuiFlexItem>
           </EuiFlexGroup>
         );

diff --git a/x-pack/plugins/apm/public/components/shared/charts/spark_plot/index.tsx b/x-pack/plugins/apm/public/components/shared/charts/spark_plot/index.tsx
@@ -75,7 +75,7 @@ export function SparkPlot({
     width: compact ? px(unit * 3) : px(unit * 4),
   };
 
-  const SparklinesSeries = hasComparisonSeries ? LineSeries : AreaSeries;
+  const SparkelineSeries = hasComparisonSeries ? LineSeries : AreaSeries;
 
   return (
     <EuiFlexGroup gutterSize="m" responsive={false}>
@@ -98,8 +98,8 @@ export function SparkPlot({
               showLegend={false}
               tooltip="none"
             />
-            <SparklinesSeries
-              id="sparklinesSeries"
+            <SparkelineSeries
+              id="sparkelineSeries"
               xScaleType={ScaleType.Time}
               yScaleType={ScaleType.Linear}
               xAccessor={'x'}

diff --git a/...ck/plugins/apm/server/lib/services/get_service_transaction_group_comparison_statistics.ts b/...ck/plugins/apm/server/lib/services/get_service_transaction_group_comparison_statistics.ts
@@ -220,7 +220,7 @@ export async function getServiceTransactionGroupComparisonStatisticsPeriods({
 }) {
   const { start, end } = setup;
 
-  const commomProps = {
+  const commonProps = {
     setup,
     serviceName,
     transactionNames,
@@ -233,15 +233,15 @@ export async function getServiceTransactionGroupComparisonStatisticsPeriods({
   };
 
   const currentPeriodPromise = getServiceTransactionGroupComparisonStatistics({
-    ...commomProps,
+    ...commonProps,
     start,
     end,
   });
 
   const previousPeriodPromise =
     comparisonStart && comparisonEnd
       ? getServiceTransactionGroupComparisonStatistics({
-          ...commomProps,
+          ...commonProps,
           start: comparisonStart,
           end: comparisonEnd,
           getOffsetXCoordinate: (x: number) =>

diff --git a/.../test/apm_api_integration/tests/transactions/transactions_groups_comparison_statistics.ts b/.../test/apm_api_integration/tests/transactions/transactions_groups_comparison_statistics.ts
@@ -199,7 +199,7 @@ export default function ApiTest({ getService }: FtrProviderContext) {
           previousPeriod = response.body.previousPeriod;
         });
 
-        it('returns corrent number of items', () => {
+        it('returns correct number of items', () => {
           expect(Object.keys(currentPeriod)).to.be.eql(transactionNames);
           expect(Object.keys(previousPeriod)).to.be.eql(transactionNames);