Check typing char by char for job wizard inputs

elastic · Dec 6, 2019 · eb90bff · eb90bff
1 parent 49471bd
commit eb90bff
Show file tree

Hide file tree

Showing 4 changed files with 64 additions and 9 deletions.
diff --git a/test/functional/services/test_subjects.ts b/test/functional/services/test_subjects.ts
@@ -199,6 +199,58 @@ export function TestSubjectsProvider({ getService }: FtrProviderContext) {
       });
     }
 
+    public async setValueWithChecks(
+      selector: string,
+      text: string,
+      options: SetValueOptions = {}
+    ): Promise<void> {
+      return await retry.try(async () => {
+        const { clearWithKeyboard = false, typeCharByChar = false } = options;
+        log.debug(`TestSubjects.setValueWithChecks(${selector}, ${text})`);
+        await this.click(selector);
+        // in case the input element is actually a child of the testSubject, we
+        // call clearValue() and type() on the element that is focused after
+        // clicking on the testSubject
+        const input = await find.activeElement();
+
+        await retry.tryForTime(5000, async () => {
+          let currentValue = await input.getAttribute('value');
+          if (currentValue !== '') {
+            if (clearWithKeyboard === true) {
+              await input.clearValueWithKeyboard();
+            } else {
+              await input.clearValue();
+            }
+            currentValue = await input.getAttribute('value');
+          }
+
+          if (currentValue === '') {
+            return true;
+          } else {
+            throw new Error(`Expected input to be empty, but got value '${currentValue}'`);
+          }
+        });
+
+        for (const chr of text) {
+          await retry.tryForTime(5000, async () => {
+            const oldValue = await input.getAttribute('value');
+            await input.type(chr, { charByChar: typeCharByChar });
+
+            await retry.tryForTime(1000, async () => {
+              const newValue = await input.getAttribute('value');
+              if (newValue === `${oldValue}${chr}`) {
+                return true;
+              } else {
+                throw new Error(
+                  `After typing character '${chr}', the new value in the input should be '${oldValue}${chr}' (got ${newValue})`
+                );
+              }
+            });
+          });
+        }
+      });
+    }
+
     public async selectValue(selector: string, value: string): Promise<void> {
       await find.selectValue(`[data-test-subj="${selector}"]`, value);
     }

diff --git a/x-pack/test/functional/apps/machine_learning/anomaly_detection/index.ts b/x-pack/test/functional/apps/machine_learning/anomaly_detection/index.ts
@@ -6,7 +6,8 @@
 import { FtrProviderContext } from '../../../ftr_provider_context';
 
 export default function({ loadTestFile }: FtrProviderContext) {
-  describe('anomaly detection', function() {
+  // eslint-disable-next-line ban/ban
+  describe.only('anomaly detection', function() {
     this.tags(['skipFirefox']);
 
     loadTestFile(require.resolve('./single_metric_job'));

diff --git a/x-pack/test/functional/services/machine_learning/job_wizard_advanced.ts b/x-pack/test/functional/services/machine_learning/job_wizard_advanced.ts
@@ -44,7 +44,7 @@ export function MachineLearningJobWizardAdvancedProvider({ getService }: FtrProv
     },
 
     async setQueryDelay(queryDelay: string) {
-      await testSubjects.setValue('mlJobWizardInputQueryDelay', queryDelay, {
+      await testSubjects.setValueWithChecks('mlJobWizardInputQueryDelay', queryDelay, {
         clearWithKeyboard: true,
         typeCharByChar: true,
       });
@@ -61,7 +61,7 @@ export function MachineLearningJobWizardAdvancedProvider({ getService }: FtrProv
     },
 
     async setFrequency(frequency: string) {
-      await testSubjects.setValue('mlJobWizardInputFrequency', frequency, {
+      await testSubjects.setValueWithChecks('mlJobWizardInputFrequency', frequency, {
         clearWithKeyboard: true,
         typeCharByChar: true,
       });
@@ -78,7 +78,7 @@ export function MachineLearningJobWizardAdvancedProvider({ getService }: FtrProv
     },
 
     async setScrollSize(scrollSize: string) {
-      await testSubjects.setValue('mlJobWizardInputScrollSize', scrollSize, {
+      await testSubjects.setValueWithChecks('mlJobWizardInputScrollSize', scrollSize, {
         clearWithKeyboard: true,
         typeCharByChar: true,
       });
@@ -257,7 +257,7 @@ export function MachineLearningJobWizardAdvancedProvider({ getService }: FtrProv
     },
 
     async setDetectorDescription(description: string) {
-      await testSubjects.setValue('mlAdvancedDetectorDescriptionInput', description, {
+      await testSubjects.setValueWithChecks('mlAdvancedDetectorDescriptionInput', description, {
         clearWithKeyboard: true,
       });
       await this.assertDetectorDescriptionValue(description);

diff --git a/x-pack/test/functional/services/machine_learning/job_wizard_common.ts b/x-pack/test/functional/services/machine_learning/job_wizard_common.ts
@@ -108,7 +108,7 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
     },
 
     async setBucketSpan(bucketSpan: string) {
-      await testSubjects.setValue('mlJobWizardInputBucketSpan', bucketSpan, {
+      await testSubjects.setValueWithChecks('mlJobWizardInputBucketSpan', bucketSpan, {
         clearWithKeyboard: true,
         typeCharByChar: true,
       });
@@ -125,7 +125,9 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
     },
 
     async setJobId(jobId: string) {
-      await testSubjects.setValue('mlJobWizardInputJobId', jobId, { clearWithKeyboard: true });
+      await testSubjects.setValueWithChecks('mlJobWizardInputJobId', jobId, {
+        clearWithKeyboard: true,
+      });
       await this.assertJobIdValue(jobId);
     },
 
@@ -141,7 +143,7 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
     },
 
     async setJobDescription(jobDescription: string) {
-      await testSubjects.setValue('mlJobWizardInputJobDescription', jobDescription, {
+      await testSubjects.setValueWithChecks('mlJobWizardInputJobDescription', jobDescription, {
         clearWithKeyboard: true,
       });
       await this.assertJobDescriptionValue(jobDescription);
@@ -285,7 +287,7 @@ export function MachineLearningJobWizardCommonProvider({ getService }: FtrProvid
         await this.ensureAdvancedSectionOpen();
         subj = advancedSectionSelector(subj);
       }
-      await testSubjects.setValue(subj, modelMemoryLimit, { clearWithKeyboard: true });
+      await testSubjects.setValueWithChecks(subj, modelMemoryLimit, { clearWithKeyboard: true });
       await this.assertModelMemoryLimitValue(modelMemoryLimit, {
         withAdvancedSection: sectionOptions.withAdvancedSection,
       });