Respond to review comments

elastic · Mar 3, 2021 · e6e3dca · e6e3dca
1 parent e665736
commit e6e3dca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/test/functional/apps/visualize/_histogram_request_start.ts b/test/functional/apps/visualize/_histogram_request_start.ts
@@ -76,7 +76,9 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       it('should use provided value when number of generated buckets is less than histogram:maxBars', async function () {
         log.debug('Field = machine.ram_range');
         await PageObjects.visEditor.selectField('machine.ram_range');
-        await PageObjects.common.sleep(1000); // fix this
+        await retry.waitFor('interval to be set', async () => {
+          return await PageObjects.visEditor.getNumericInterval();
+        });
         expect(await PageObjects.visEditor.getNumericInterval()).to.eql(100);
       });
     });

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/ranges/ranges.tsx b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/ranges/ranges.tsx
@@ -127,7 +127,6 @@ export const rangeOperation: OperationDefinition<RangeIndexPatternColumn, 'field
     );
   },
   onFieldChange: (oldColumn, field) => {
-    // TODO: Handle switch with number_range fields
     return {
       ...oldColumn,
       label: field.name,