[Stack Monitoring] add test subject to tab (#114319)

* pass test subject to advanced link and change name in angular version to be generic * change name in functional test Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
elastic · Oct 11, 2021 · de42e53 · de42e53
1 parent 328da6f
commit de42e53
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/x-pack/plugins/monitoring/public/application/pages/elasticsearch/item_template.tsx b/x-pack/plugins/monitoring/public/application/pages/elasticsearch/item_template.tsx
@@ -25,6 +25,7 @@ export const ItemTemplate: React.FC<ItemTemplateProps> = (props) => {
     },
     {
       id: 'advanced',
+      testSubj: 'esItemDetailAdvancedLink',
       label: i18n.translate('xpack.monitoring.esItemNavigation.advancedLinkText', {
         defaultMessage: 'Advanced',
       }),

diff --git a/x-pack/plugins/monitoring/public/directives/main/index.html b/x-pack/plugins/monitoring/public/directives/main/index.html
@@ -103,7 +103,7 @@ <h1 class="euiTitle euiTitle--xsmall">{{pageTitle || monitoringMain.instance}}</
       </a>
       <a
         ng-if="monitoringMain.instance && (monitoringMain.name === 'nodes' || monitoringMain.name === 'indices')"
-        data-test-subj="esNodeDetailAdvancedLink"
+        data-test-subj="esItemDetailAdvancedLink"
         kbn-href="#/elasticsearch/{{ monitoringMain.name }}/{{ monitoringMain.resolver }}/advanced"
         class="euiTab"
         ng-class="{'euiTab-isSelected': monitoringMain.page === 'advanced'}"

diff --git a/x-pack/test/functional/services/monitoring/elasticsearch_node_detail.js b/x-pack/test/functional/services/monitoring/elasticsearch_node_detail.js
@@ -21,7 +21,7 @@ export function MonitoringElasticsearchNodeDetailProvider({ getService }) {
 
   return new (class ElasticsearchNodeDetail {
     async clickAdvanced() {
-      return testSubjects.click('esNodeDetailAdvancedLink');
+      return testSubjects.click('esItemDetailAdvancedLink');
     }
 
     async getSummary() {