Fix eslint

elastic · Oct 30, 2020 · d7be45e · d7be45e
1 parent 2815ca3
commit d7be45e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx b/x-pack/plugins/infra/public/alerting/inventory/components/metric.tsx
@@ -107,11 +107,14 @@ export const MetricExpression = ({
   );
 
   const expressionDisplayValue = useMemo(
-    () =>
-      (customMetricTabOpen
+    () => {
+      return customMetricTabOpen
         ? customMetric?.field && getCustomMetricLabel(customMetric)
-        : metric?.text) || firstFieldOption.text,
-    [customMetricTabOpen, metric?.text, customMetric?.field, firstFieldOption]
+        : metric?.text || firstFieldOption.text;
+    },
+    // The ?s are confusing eslint here, so...
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    [customMetricTabOpen, metric, customMetric, firstFieldOption]
   );
 
   const onChangeTab = useCallback(
@@ -163,7 +166,7 @@ export const MetricExpression = ({
       };
       if (SnapshotCustomMetricInputRT.is(newCustomMetric)) debouncedOnChangeCustom(newCustomMetric);
     },
-    [customMetric, onChangeCustom]
+    [customMetric, debouncedOnChangeCustom]
   );
 
   const availablefieldsOptions = metrics.map((m) => {