Fix more types

x-pack/plugins/observability_solution/observability_ai_assistant/public/service/create_service.ts

@@ -95,5 +95,6 @@ export function createService({
       },
       predefinedConversation$: predefinedConversation$.asObservable(),
     },
+    scope,
   };
 }

x-pack/plugins/observability_solution/observability_ai_assistant/public/types.ts

@@ -83,7 +83,8 @@ export interface ObservabilityAIAssistantChatService {
     name: string,
     args: string | undefined,
     response: { data?: string; content?: string },
-    onActionClick: ChatActionClickHandler
+    onActionClick: ChatActionClickHandler,
+    scope?: AssistantScope
   ) => React.ReactNode;
 }
 
@@ -101,6 +102,7 @@ export interface ObservabilityAIAssistantService {
   getScreenContexts: () => ObservabilityAIAssistantScreenContext[];
   conversations: ObservabilityAIAssistantConversationService;
   navigate: (callback: () => void) => Promise<Observable<MessageAddEvent>>;
+  scope: AssistantScope;
 }
 
 export type RenderFunction<TArguments, TResponse extends FunctionResponse> = (options: {

x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/chat/chat_body.tsx

@@ -110,7 +110,6 @@ export function ChatBody({
   showLinkToConversationsApp,
   onConversationUpdate,
   onToggleFlyoutPositionMode,
-  scope,
 }: {
   connectors: ReturnType<typeof useGenAIConnectors>;
   currentUser?: Pick<AuthenticatedUser, 'full_name' | 'username'>;
@@ -122,7 +121,6 @@ export function ChatBody({
   showLinkToConversationsApp: boolean;
   onConversationUpdate: (conversation: { conversation: Conversation['conversation'] }) => void;
   onToggleFlyoutPositionMode?: (flyoutPositionMode: FlyoutPositionMode) => void;
-  scope: AssistantScope;
 }) {
   const license = useLicense();
   const hasCorrectLicense = license?.hasAtLeast('enterprise');
@@ -140,7 +138,6 @@ export function ChatBody({
     chatService,
     connectorId: connectors.selectedConnector,
     onConversationUpdate,
-    scope,
   });
 
   const timelineContainerRef = useRef<HTMLDivElement | null>(null);

x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/chat/chat_flyout.tsx

@@ -274,7 +274,6 @@ export function ChatFlyout({
                 conversationList.conversations.refresh();
               }}
               onToggleFlyoutPositionMode={handleToggleFlyoutPositionMode}
-              scope={scope}
             />
           </EuiFlexItem>
 

x-pack/plugins/observability_solution/observability_ai_assistant_app/public/hooks/use_conversation.test.tsx

@@ -55,6 +55,7 @@ const mockService: MockedService = {
     predefinedConversation$: new Observable(),
   },
   navigate: jest.fn().mockReturnValue(of()),
+  scope: 'all',
 };
 
 const mockChatService = createMockChatService();
@@ -107,7 +108,6 @@ describe('useConversation', () => {
             },
           ],
           initialConversationId: 'foo',
-          scope: 'all',
         },
         wrapper,
       });
@@ -125,7 +125,6 @@ describe('useConversation', () => {
           connectorId: 'my-connector',
         },
         wrapper,
-        scope: 'all',
       });
     });
 
@@ -165,7 +164,6 @@ describe('useConversation', () => {
               },
             },
           ],
-          scope: 'all',
         },
         wrapper,
       });
@@ -220,7 +218,6 @@ describe('useConversation', () => {
           chatService: mockChatService,
           connectorId: 'my-connector',
           initialConversationId: 'my-conversation-id',
-          scope: 'all',
         },
         wrapper,
       });
@@ -285,7 +282,6 @@ describe('useConversation', () => {
           chatService: mockChatService,
           connectorId: 'my-connector',
           initialConversationId: 'my-conversation-id',
-          scope: 'all',
         },
         wrapper,
       });
@@ -378,7 +374,6 @@ describe('useConversation', () => {
             },
           ],
           onConversationUpdate,
-          scope: 'all',
         },
         wrapper,
       });
@@ -458,7 +453,6 @@ describe('useConversation', () => {
             initialConversationId: 'foo',
           },
           wrapper,
-          scope: 'all',
         });
       });
 
@@ -497,7 +491,6 @@ describe('useConversation', () => {
               chatService: mockChatService,
               connectorId: 'my-connector',
               initialConversationId: 'my-conversation-id',
-              scope: 'all',
             },
             wrapper,
           });

x-pack/plugins/observability_solution/observability_ai_assistant_app/public/hooks/use_conversation.ts

@@ -45,7 +45,6 @@ export interface UseConversationProps {
   chatService: ObservabilityAIAssistantChatService;
   connectorId: string | undefined;
   onConversationUpdate?: (conversation: { conversation: Conversation['conversation'] }) => void;
-  scope: AssistantScope;
 }
 
 export type UseConversationResult = {
@@ -62,9 +61,9 @@ export function useConversation({
   chatService,
   connectorId,
   onConversationUpdate,
-  scope,
 }: UseConversationProps): UseConversationResult {
   const service = useObservabilityAIAssistantAppService();
+  const { scope } = service;
 
   const {
     services: {

x-pack/plugins/observability_solution/observability_ai_assistant_app/public/routes/conversations/conversation_view.tsx

@@ -176,7 +176,6 @@ export function ConversationView() {
             knowledgeBase={knowledgeBase}
             showLinkToConversationsApp={false}
             onConversationUpdate={handleConversationUpdate}
-            scope={scope}
           />
 
           <div className={sidebarContainerClass}>

x-pack/plugins/observability_solution/observability_ai_assistant_app/scripts/evaluation/evaluation.ts

@@ -100,6 +100,7 @@ function runEvaluations() {
             evaluationConnectorId: evaluationConnector.id!,
             persist: argv.persist,
             suite: mocha.suite,
+            scope: 'all',
           });
 
           const header: string[][] = [