[UnifiedFieldList] Address PR comments

elastic · Oct 27, 2022 · cdbceeb · cdbceeb
1 parent a27f79c
commit cdbceeb
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 19 deletions.
diff --git a/src/plugins/unified_field_list/README.md b/src/plugins/unified_field_list/README.md
@@ -92,7 +92,7 @@ const { fieldGroups } = useGroupedFields({
 <FieldListGrouped
   fieldGroups={fieldGroups}
   fieldsExistenceStatus={fieldsExistenceReader.getFieldsExistenceStatus(currentDataViewId)}
-  existFieldsInIndex={!!allFields.length}
+  fieldsExistInIndex={!!allFields.length}
   renderFieldItem={renderFieldItem}
   screenReaderDescriptionForSearchInputId={fieldSearchDescriptionId}
 />

diff --git a/src/plugins/unified_field_list/public/components/field_list/field_list_grouped.test.tsx b/src/plugins/unified_field_list/public/components/field_list/field_list_grouped.test.tsx
@@ -44,7 +44,7 @@ describe('UnifiedFieldList <FieldListGrouped /> + useGroupedFields()', () => {
     defaultProps = {
       fieldGroups: {},
       fieldsExistenceStatus: ExistenceFetchStatus.succeeded,
-      existFieldsInIndex: true,
+      fieldsExistInIndex: true,
       screenReaderDescriptionForSearchInputId: 'testId',
       renderFieldItem: jest.fn(({ field, itemIndex, groupIndex }) => (
         <EuiText
@@ -181,7 +181,7 @@ describe('UnifiedFieldList <FieldListGrouped /> + useGroupedFields()', () => {
     const wrapper = await mountGroupedList({
       listProps: {
         ...defaultProps,
-        existFieldsInIndex: false,
+        fieldsExistInIndex: false,
         fieldsExistenceStatus: ExistenceFetchStatus.failed,
       },
       hookParams: {
@@ -196,7 +196,7 @@ describe('UnifiedFieldList <FieldListGrouped /> + useGroupedFields()', () => {
     expect(wrapper.find(FieldsAccordion)).toHaveLength(3);
     expect(wrapper.find(EuiLoadingSpinner)).toHaveLength(0);
     expect(
-      wrapper.find(NoFieldsCallout).map((callout) => callout.prop('existFieldsInIndex'))
+      wrapper.find(NoFieldsCallout).map((callout) => callout.prop('fieldsExistInIndex'))
     ).toStrictEqual([false, false, false]);
   });
 

diff --git a/src/plugins/unified_field_list/public/components/field_list/field_list_grouped.tsx b/src/plugins/unified_field_list/public/components/field_list/field_list_grouped.tsx
@@ -31,15 +31,15 @@ function getDisplayedFieldsLength<T extends FieldListItem>(
 export interface FieldListGroupedProps<T extends FieldListItem> {
   fieldGroups: FieldListGroups<T>;
   fieldsExistenceStatus: ExistenceFetchStatus;
-  existFieldsInIndex: boolean;
+  fieldsExistInIndex: boolean;
   renderFieldItem: FieldsAccordionProps<T>['renderFieldItem'];
   screenReaderDescriptionForSearchInputId?: string;
 }
 
 function InnerFieldListGrouped<T extends FieldListItem = DataViewField>({
   fieldGroups,
   fieldsExistenceStatus,
-  existFieldsInIndex,
+  fieldsExistInIndex,
   renderFieldItem,
   screenReaderDescriptionForSearchInputId,
 }: FieldListGroupedProps<T>) {
@@ -220,7 +220,7 @@ function InnerFieldListGrouped<T extends FieldListItem = DataViewField>({
                     isAffectedByGlobalFilter={fieldGroup.isAffectedByGlobalFilter}
                     isAffectedByTimerange={fieldGroup.isAffectedByTimeFilter}
                     isAffectedByFieldFilter={fieldGroup.fieldCount !== fieldGroup.fields.length}
-                    existFieldsInIndex={!!existFieldsInIndex}
+                    fieldsExistInIndex={!!fieldsExistInIndex}
                     defaultNoFieldsMessage={fieldGroup.defaultNoFieldsMessage}
                   />
                 )}

diff --git a/src/plugins/unified_field_list/public/components/field_list/no_fields_callout.test.tsx b/src/plugins/unified_field_list/public/components/field_list/no_fields_callout.test.tsx
@@ -12,7 +12,7 @@ import { NoFieldsCallout } from './no_fields_callout';
 
 describe('UnifiedFieldList <NoFieldCallout />', () => {
   it('renders correctly for index with no fields', () => {
-    const component = shallow(<NoFieldsCallout existFieldsInIndex={false} />);
+    const component = shallow(<NoFieldsCallout fieldsExistInIndex={false} />);
     expect(component).toMatchInlineSnapshot(`
       <EuiCallOut
         color="warning"
@@ -22,7 +22,7 @@ describe('UnifiedFieldList <NoFieldCallout />', () => {
     `);
   });
   it('renders correctly when empty with no filters/timerange reasons', () => {
-    const component = shallow(<NoFieldsCallout existFieldsInIndex={true} />);
+    const component = shallow(<NoFieldsCallout fieldsExistInIndex={true} />);
     expect(component).toMatchInlineSnapshot(`
       <EuiCallOut
         color="warning"
@@ -33,7 +33,7 @@ describe('UnifiedFieldList <NoFieldCallout />', () => {
   });
   it('renders correctly with passed defaultNoFieldsMessage', () => {
     const component = shallow(
-      <NoFieldsCallout existFieldsInIndex={true} defaultNoFieldsMessage="No empty fields" />
+      <NoFieldsCallout fieldsExistInIndex={true} defaultNoFieldsMessage="No empty fields" />
     );
     expect(component).toMatchInlineSnapshot(`
       <EuiCallOut
@@ -46,7 +46,7 @@ describe('UnifiedFieldList <NoFieldCallout />', () => {
 
   it('renders properly when affected by field filter', () => {
     const component = shallow(
-      <NoFieldsCallout existFieldsInIndex={true} isAffectedByFieldFilter={true} />
+      <NoFieldsCallout fieldsExistInIndex={true} isAffectedByFieldFilter={true} />
     );
     expect(component).toMatchInlineSnapshot(`
       <EuiCallOut
@@ -69,7 +69,7 @@ describe('UnifiedFieldList <NoFieldCallout />', () => {
   it('renders correctly when affected by global filters and timerange', () => {
     const component = shallow(
       <NoFieldsCallout
-        existFieldsInIndex={true}
+        fieldsExistInIndex={true}
         isAffectedByTimerange={true}
         isAffectedByGlobalFilter={true}
         defaultNoFieldsMessage="There are no available fields that contain data."
@@ -99,7 +99,7 @@ describe('UnifiedFieldList <NoFieldCallout />', () => {
   it('renders correctly when affected by global filters and field filters', () => {
     const component = shallow(
       <NoFieldsCallout
-        existFieldsInIndex={true}
+        fieldsExistInIndex={true}
         isAffectedByTimerange={true}
         isAffectedByFieldFilter={true}
         defaultNoFieldsMessage="There are no available fields that contain data."
@@ -129,7 +129,7 @@ describe('UnifiedFieldList <NoFieldCallout />', () => {
   it('renders correctly when affected by field filters, global filter and timerange', () => {
     const component = shallow(
       <NoFieldsCallout
-        existFieldsInIndex={true}
+        fieldsExistInIndex={true}
         isAffectedByFieldFilter={true}
         isAffectedByTimerange={true}
         isAffectedByGlobalFilter={true}

diff --git a/src/plugins/unified_field_list/public/components/field_list/no_fields_callout.tsx b/src/plugins/unified_field_list/public/components/field_list/no_fields_callout.tsx
@@ -18,19 +18,19 @@ const defaultNoFieldsMessageCopy = i18n.translate(
 );
 
 export const NoFieldsCallout = ({
-  existFieldsInIndex,
+  fieldsExistInIndex,
   defaultNoFieldsMessage = defaultNoFieldsMessageCopy,
   isAffectedByFieldFilter = false,
   isAffectedByTimerange = false,
   isAffectedByGlobalFilter = false,
 }: {
-  existFieldsInIndex: boolean;
+  fieldsExistInIndex: boolean;
   isAffectedByFieldFilter?: boolean;
   defaultNoFieldsMessage?: string;
   isAffectedByTimerange?: boolean;
   isAffectedByGlobalFilter?: boolean;
 }) => {
-  if (!existFieldsInIndex) {
+  if (!fieldsExistInIndex) {
     return (
       <EuiCallOut
         size="s"

diff --git a/x-pack/plugins/lens/public/datasources/form_based/datapanel.tsx b/x-pack/plugins/lens/public/datasources/form_based/datapanel.tsx
@@ -618,7 +618,7 @@ export const InnerFormBasedDataPanel = function InnerFormBasedDataPanel({
           <FieldListGrouped<IndexPatternField>
             fieldGroups={fieldGroups}
             fieldsExistenceStatus={fieldsExistenceStatus}
-            existFieldsInIndex={!!allFields.length}
+            fieldsExistInIndex={!!allFields.length}
             renderFieldItem={renderFieldItem}
             screenReaderDescriptionForSearchInputId={fieldSearchDescriptionId}
           />

diff --git a/x-pack/plugins/lens/public/datasources/text_based/datapanel.tsx b/x-pack/plugins/lens/public/datasources/text_based/datapanel.tsx
@@ -199,7 +199,7 @@ export function TextBasedDataPanel({
               fieldsExistenceStatus={
                 dataHasLoaded ? ExistenceFetchStatus.succeeded : ExistenceFetchStatus.unknown
               }
-              existFieldsInIndex={Boolean(fieldList.length)}
+              fieldsExistInIndex={Boolean(fieldList.length)}
               renderFieldItem={renderFieldItem}
               screenReaderDescriptionForSearchInputId={fieldSearchDescriptionId}
             />