[Monitoring] Ensure Stack Monitoring UI works with metricbeat-* ind…

…ices (#96205)

* WIP

* WIP

* Remove unnecessary fields

* Work on node detail page

* Cluster overview looking good

* Index page

* Fix types

* ML jobs

* CCR

* CCR

* We just need total here

* Standalone cluster fix

* Re-enable logstash

* FIx jest test

* Fix tests

* Fix tests

* Fix unused import

* Add new MB-based archives

* Add actual archives

* Fix types

* Add this file back in

* Fix tests and add more

* Update whitelist

* Renames

* Renames

* Only do ccs if enabled

* Updates

* Comment out

* More tests passing

* Another passing test

* More passing, yay

* Forgot to add the actual tests, wow

* CCR

* Fix CI issues

* Missed a field here

* Kibana tests passing

* Fix type issues

* Fix type

* Fix types

* Good chunk of logstash work

* Fix types

* Fix jest test

* Fix issue with get usage in logstash code

* Fix small bug here

* Update archives with proper mappings

* Handle both legacy and mb fields properly

* Fixes

* Fix jest test

* Fix issue

* Getting setup tests in a better state

* Only beats is failing now, which is good

* Progress on cluster listing

* Functional tests passing!

* More progress on cluster tests

* More cluster work

* Fix test

* Last recovery working

* Fix types

* Fix tests

* More tweaks

* Fix snapshot

* Use stats instead of kibana_stats

* Use node and node_stats for logstash

* Beats tests passing

* APM tests passing

* API tests passing!

* Fix types

* Fix tests

* Renames beats-with-restarted-instance archive dirs

Kebab case is disallowed for all newly added files.

* Renames logstash-pipeline dirs

Kebab case disallowed for all new files

* Renames multi-basic dirs

Kebab case disallowed for all new files

* Renames singlecluster-* dirs

Kebab case disallowed for all new files

* Fixes inaccurate path change for archive setup

* Reverts changes to rebuild_all script

Co-authored-by: Jason Rhodes <jason.matthew.rhodes@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

src/dev/precommit_hook/casing_check_config.js

@@ -139,7 +139,6 @@ export const TEMPORARILY_IGNORED_PATHS = [
   'test/functional/apps/management/exports/_import_objects-conflicts.json',
   'x-pack/legacy/plugins/index_management/public/lib/editSettings.js',
   'x-pack/legacy/plugins/license_management/public/store/reducers/licenseManagement.js',
-  'x-pack/plugins/monitoring/public/components/sparkline/__mocks__/plugins/xpack_main/jquery_flot.js',
   'x-pack/plugins/monitoring/public/icons/health-gray.svg',
   'x-pack/plugins/monitoring/public/icons/health-green.svg',
   'x-pack/plugins/monitoring/public/icons/health-red.svg',
@@ -150,28 +149,4 @@ export const TEMPORARILY_IGNORED_PATHS = [
   'x-pack/plugins/reporting/server/export_types/common/assets/fonts/roboto/Roboto-Medium.ttf',
   'x-pack/plugins/reporting/server/export_types/common/assets/fonts/roboto/Roboto-Regular.ttf',
   'x-pack/plugins/reporting/server/export_types/common/assets/img/logo-grey.png',
-  'x-pack/test/functional/es_archives/monitoring/beats-with-restarted-instance/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/beats-with-restarted-instance/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/logstash-pipelines/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/logstash-pipelines/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/multi-basic/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/multi-basic/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-basic-beats/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-basic-beats/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-green-gold/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-green-gold/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-green-platinum/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-green-platinum/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-green-trial-two-nodes-one-cgrouped/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-green-trial-two-nodes-one-cgrouped/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-red-platinum/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-red-platinum/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-three-nodes-shard-relocation/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-three-nodes-shard-relocation/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-basic/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-basic/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum--with-10-alerts/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum--with-10-alerts/mappings.json',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum/data.json.gz',
-  'x-pack/test/functional/es_archives/monitoring/singlecluster-yellow-platinum/mappings.json',
 ];

x-pack/plugins/infra/public/pages/metrics/metric_detail/components/page_error.tsx

@@ -11,7 +11,6 @@ import { IHttpFetchError } from 'src/core/public';
 import { InvalidNodeError } from './invalid_node';
 import { DocumentTitle } from '../../../../components/document_title';
 import { ErrorPageBody } from '../../../error';
-
 interface Props {
   name: string;
   error: IHttpFetchError;
@@ -30,13 +29,11 @@ export const PageError = ({ error, name }: Props) => {
           })
         }
       />
-      {
-        (error.body.statusCode = 404 ? (
-          <InvalidNodeError nodeName={name} />
-        ) : (
-          <ErrorPageBody message={error.message} />
-        ))
-      }
+      {error.body?.statusCode === 404 ? (
+        <InvalidNodeError nodeName={name} />
+      ) : (
+        <ErrorPageBody message={error.message} />
+      )}
     </>
   );
 };