Skip to content

Commit

Permalink
[7.x] fix: fix flaky test (#67175) (#68773)
Browse files Browse the repository at this point in the history
  • Loading branch information
mbondyra authored Jun 11, 2020
1 parent c9ac203 commit c51b9cd
Showing 1 changed file with 4 additions and 15 deletions.
19 changes: 4 additions & 15 deletions x-pack/test/functional/apps/lens/smokescreen.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
);
await PageObjects.lens.assertExactText(
'[data-test-subj="lnsDataTable"] [data-test-subj="lnsDataTableCellValue"]',
'19,985'
);
await PageObjects.lens.assertExactText(
'[data-test-subj="lnsDataTable"] [data-test-subj="lnsDataTableCellValueFilterable"]',
'IN'
'19,986'
);
}

Expand All @@ -68,7 +64,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await browser.getActions().move({ x: 5, y: 5, origin: el._webElement }).click().perform();
}

// Failing: https://github.com/elastic/kibana/issues/66779
// FLAKY: https://github.com/elastic/kibana/issues/67838
describe.skip('lens smokescreen tests', () => {
it('should allow editing saved visualizations', async () => {
await PageObjects.visualize.gotoVisualizationLandingPage();
Expand Down Expand Up @@ -103,22 +99,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
expect(hasIpFilter).to.be(true);
});

it('should allow seamless transition to and from table view and add a filter', async () => {
it('should allow seamless transition to and from table view', async () => {
await PageObjects.visualize.gotoVisualizationLandingPage();
await PageObjects.lens.clickVisualizeListItemTitle('Artistpreviouslyknownaslens');
await PageObjects.lens.goToTimeRange();
await assertExpectedMetric();
await PageObjects.lens.switchToVisualization('lnsChartSwitchPopover_lnsDatatable');
await PageObjects.lens.configureDimension({
dimension: '[data-test-subj="lnsDatatable_column"] [data-test-subj="lns-empty-dimension"]',
operation: 'terms',
field: 'geo.dest',
});
await PageObjects.lens.save('Artistpreviouslyknownaslens');
await find.clickByCssSelector('[data-test-subj="lensDatatableFilterOut"]');
await assertExpectedTable();
await PageObjects.lens.switchToVisualization('lnsChartSwitchPopover_lnsMetric');
await assertExpectedMetric('19,985');
await assertExpectedMetric();
});

it('should allow creation of lens visualizations', async () => {
Expand Down

0 comments on commit c51b9cd

Please sign in to comment.