add unit test

elastic · Dec 11, 2020 · bef91a9 · bef91a9
1 parent 3ff0246
commit bef91a9
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.test.ts b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.test.ts
@@ -60,6 +60,31 @@ test('adds empty composed_of correctly', () => {
   expect(template.composed_of).toStrictEqual(composedOfTemplates);
 });
 
+test('adds hidden field correctly', () => {
+  const templateWithHiddenName = 'logs-nginx-access-abcd';
+
+  const templateWithHidden = getTemplate({
+    type: 'logs',
+    templateWithHiddenName,
+    packageName: 'nginx',
+    mappings: { properties: {} },
+    composedOfTemplates: [],
+    hidden: true,
+  });
+  expect(templateWithHidden.data_stream.hidden.toStrictEqual(true));
+
+  const templateWithoutHiddenName = 'logs-nginx-access-efgh';
+
+  const template = getTemplate({
+    type: 'logs',
+    templateWithoutHiddenName,
+    packageName: 'nginx',
+    mappings: { properties: {} },
+    composedOfTemplates: [],
+  });
+  expect(template.data_stream.hidden.toStrictEqual(false));
+});
+
 test('tests loading base.yml', () => {
   const ymlPath = path.join(__dirname, '../../fields/tests/base.yml');
   const fieldsYML = readFileSync(ymlPath, 'utf-8');

diff --git a/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts b/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/template.ts
@@ -263,7 +263,6 @@ function getBaseTemplate(
   mappings: IndexTemplateMappings,
   packageName: string,
   composedOfTemplates: string[],
-  ilmPolicy?: string | undefined,
   hidden?: boolean | false
 ): IndexTemplate {
   // Meta information to identify Ingest Manager's managed templates and indices
@@ -288,7 +287,7 @@ function getBaseTemplate(
         index: {
           // ILM Policy must be added here, for now point to the default global ILM policy name
           lifecycle: {
-            name: ilmPolicy ? ilmPolicy : type,
+            name: type,
           },
           // What should be our default for the compression?
           codec: 'best_compression',