[7.x] [data.search] Simplify poll logic and improve types (#82545) (#…

…84292)

* [data.search] Simplify poll logic and improve types (#82545)

* [Search] Add request context and asScoped pattern

* Update docs

* Unify interface for getting search client

* Update examples/search_examples/server/my_strategy.ts

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>

* Review feedback

* Fix checks

* Fix CI

* Fix security search

* Fix test

* Fix test for reals

* Fix types

* [data.search] Refactor search polling and improve types

* Fix & update tests & types

* eql totals

* doc

* Revert "eql totals"

This reverts commit 01e8a06.

* lint

* response type

* shim inside strategies

* shim for security

* fix eql params

Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Liza K <liza.katz@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	src/plugins/data/server/index.ts
#	src/plugins/data/server/server.api.md

* doc

Co-authored-by: Lukas Olson <olson.lukas@gmail.com>

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.painlesserror._constructor_.md

@@ -9,13 +9,12 @@ Constructs a new instance of the `PainlessError` class
 <b>Signature:</b>
 
 ```typescript
-constructor(err: IEsError, request: IKibanaSearchRequest);
+constructor(err: IEsError);
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
 |  err | <code>IEsError</code> |  |
-|  request | <code>IKibanaSearchRequest</code> |  |
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.painlesserror.md

@@ -14,7 +14,7 @@ export declare class PainlessError extends EsError
 
 |  Constructor | Modifiers | Description |
 |  --- | --- | --- |
-|  [(constructor)(err, request)](./kibana-plugin-plugins-data-public.painlesserror._constructor_.md) |  | Constructs a new instance of the <code>PainlessError</code> class |
+|  [(constructor)(err)](./kibana-plugin-plugins-data-public.painlesserror._constructor_.md) |  | Constructs a new instance of the <code>PainlessError</code> class |
 
 ## Properties
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchinterceptor.handlesearcherror.md

@@ -7,15 +7,14 @@
 <b>Signature:</b>
 
 ```typescript
-protected handleSearchError(e: any, request: IKibanaSearchRequest, timeoutSignal: AbortSignal, options?: ISearchOptions): Error;
+protected handleSearchError(e: any, timeoutSignal: AbortSignal, options?: ISearchOptions): Error;
 ```
 
 ## Parameters
 
 |  Parameter | Type | Description |
 |  --- | --- | --- |
 |  e | <code>any</code> |  |
-|  request | <code>IKibanaSearchRequest</code> |  |
 |  timeoutSignal | <code>AbortSignal</code> |  |
 |  options | <code>ISearchOptions</code> |  |
 

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.searchinterceptor.md

@@ -27,7 +27,7 @@ export declare class SearchInterceptor
 |  Method | Modifiers | Description |
 |  --- | --- | --- |
 |  [getTimeoutMode()](./kibana-plugin-plugins-data-public.searchinterceptor.gettimeoutmode.md) |  |  |
-|  [handleSearchError(e, request, timeoutSignal, options)](./kibana-plugin-plugins-data-public.searchinterceptor.handlesearcherror.md) |  |  |
+|  [handleSearchError(e, timeoutSignal, options)](./kibana-plugin-plugins-data-public.searchinterceptor.handlesearcherror.md) |  |  |
 |  [search(request, options)](./kibana-plugin-plugins-data-public.searchinterceptor.search.md) |  | Searches using the given <code>search</code> method. Overrides the <code>AbortSignal</code> with one that will abort either when <code>cancelPending</code> is called, when the request times out, or when the original <code>AbortSignal</code> is aborted. Updates <code>pendingCount$</code> when the request is started/finalized. |
 |  [showError(e)](./kibana-plugin-plugins-data-public.searchinterceptor.showerror.md) |  |  |
 

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.getdefaultsearchparams.md

@@ -7,11 +7,7 @@
 <b>Signature:</b>
 
 ```typescript
-export declare function getDefaultSearchParams(uiSettingsClient: IUiSettingsClient): Promise<{
-    maxConcurrentShardRequests: number | undefined;
-    ignoreUnavailable: boolean;
-    trackTotalHits: boolean;
-}>;
+export declare function getDefaultSearchParams(uiSettingsClient: IUiSettingsClient): Promise<Pick<Search, 'max_concurrent_shard_requests' | 'ignore_unavailable' | 'track_total_hits'>>;
 ```
 
 ## Parameters
@@ -22,9 +18,5 @@ export declare function getDefaultSearchParams(uiSettingsClient: IUiSettingsClie
 
 <b>Returns:</b>
 
-`Promise<{
-    maxConcurrentShardRequests: number | undefined;
-    ignoreUnavailable: boolean;
-    trackTotalHits: boolean;
-}>`
+`Promise<Pick<Search, 'max_concurrent_shard_requests' | 'ignore_unavailable' | 'track_total_hits'>>`
 

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.getshardtimeout.md

@@ -7,11 +7,7 @@
 <b>Signature:</b>
 
 ```typescript
-export declare function getShardTimeout(config: SharedGlobalConfig): {
-    timeout: string;
-} | {
-    timeout?: undefined;
-};
+export declare function getShardTimeout(config: SharedGlobalConfig): Pick<Search, 'timeout'>;
 ```
 
 ## Parameters
@@ -22,9 +18,5 @@ export declare function getShardTimeout(config: SharedGlobalConfig): {
 
 <b>Returns:</b>
 
-`{
-    timeout: string;
-} | {
-    timeout?: undefined;
-}`
+`Pick<Search, 'timeout'>`
 

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.md

@@ -34,6 +34,7 @@
 |  [getTime(indexPattern, timeRange, options)](./kibana-plugin-plugins-data-server.gettime.md) |  |
 |  [parseInterval(interval)](./kibana-plugin-plugins-data-server.parseinterval.md) |  |
 |  [plugin(initializerContext)](./kibana-plugin-plugins-data-server.plugin.md) | Static code to be shared externally |
+|  [searchUsageObserver(logger, usage)](./kibana-plugin-plugins-data-server.searchusageobserver.md) | Rxjs observer for easily doing <code>tap(searchUsageObserver(logger, usage))</code> in an rxjs chain. |
 |  [shouldReadFieldFromDocValues(aggregatable, esType)](./kibana-plugin-plugins-data-server.shouldreadfieldfromdocvalues.md) |  |
 |  [usageProvider(core)](./kibana-plugin-plugins-data-server.usageprovider.md) |  |
 
@@ -45,7 +46,6 @@
 |  [EsQueryConfig](./kibana-plugin-plugins-data-server.esqueryconfig.md) |  |
 |  [FieldDescriptor](./kibana-plugin-plugins-data-server.fielddescriptor.md) |  |
 |  [FieldFormatConfig](./kibana-plugin-plugins-data-server.fieldformatconfig.md) |  |
-|  [IEsRawSearchResponse](./kibana-plugin-plugins-data-server.iesrawsearchresponse.md) |  |
 |  [IEsSearchRequest](./kibana-plugin-plugins-data-server.iessearchrequest.md) |  |
 |  [IFieldSubType](./kibana-plugin-plugins-data-server.ifieldsubtype.md) |  |
 |  [IFieldType](./kibana-plugin-plugins-data-server.ifieldtype.md) |  |

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.search.md

@@ -8,24 +8,6 @@
 
 ```typescript
 search: {
-    esSearch: {
-        utils: {
-            doSearch: <SearchResponse = any>(searchMethod: () => Promise<SearchResponse>, abortSignal?: AbortSignal | undefined) => import("rxjs").Observable<SearchResponse>;
-            shimAbortSignal: <T extends import("../common").TransportRequestPromise<unknown>>(promise: T, signal: AbortSignal | undefined) => T;
-            trackSearchStatus: <KibanaResponse extends import("../common").IKibanaSearchResponse<any> = import("./search").IEsSearchResponse<import("src/core/server").SearchResponse<unknown>>>(logger: import("src/core/server").Logger, usage?: import("./search").SearchUsage | undefined) => import("rxjs").UnaryFunction<import("rxjs").Observable<KibanaResponse>, import("rxjs").Observable<KibanaResponse>>;
-            includeTotalLoaded: () => import("rxjs").OperatorFunction<import("../common").IKibanaSearchResponse<import("elasticsearch").SearchResponse<unknown>>, {
-                total: number;
-                loaded: number;
-                id?: string | undefined;
-                isRunning?: boolean | undefined;
-                isPartial?: boolean | undefined;
-                rawResponse: import("elasticsearch").SearchResponse<unknown>;
-            }>;
-            toKibanaSearchResponse: <SearchResponse_1 extends import("../common").IEsRawSearchResponse<any> = import("../common").IEsRawSearchResponse<any>, KibanaResponse_1 extends import("../common").IKibanaSearchResponse<any> = import("../common").IKibanaSearchResponse<SearchResponse_1>>() => import("rxjs").OperatorFunction<import("@elastic/elasticsearch").ApiResponse<SearchResponse_1, import("@elastic/elasticsearch/lib/Transport").Context>, KibanaResponse_1>;
-            getTotalLoaded: typeof getTotalLoaded;
-            toSnakeCase: typeof toSnakeCase;
-        };
-    };
     aggs: {
         CidrMask: typeof CidrMask;
         dateHistogramInterval: typeof dateHistogramInterval;

docs/development/plugins/data/server/kibana-plugin-plugins-data-server.searchusageobserver.md

@@ -0,0 +1,31 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-server](./kibana-plugin-plugins-data-server.md) &gt; [searchUsageObserver](./kibana-plugin-plugins-data-server.searchusageobserver.md)
+
+## searchUsageObserver() function
+
+Rxjs observer for easily doing `tap(searchUsageObserver(logger, usage))` in an rxjs chain.
+
+<b>Signature:</b>
+
+```typescript
+export declare function searchUsageObserver(logger: Logger, usage?: SearchUsage): {
+    next(response: IEsSearchResponse): void;
+    error(): void;
+};
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  logger | <code>Logger</code> |  |
+|  usage | <code>SearchUsage</code> |  |
+
+<b>Returns:</b>
+
+`{
+    next(response: IEsSearchResponse): void;
+    error(): void;
+}`
+

src/plugins/data/common/search/es_search/index.ts

@@ -18,8 +18,3 @@
  */
 
 export * from './types';
-export * from './utils';
-export * from './es_search_rxjs_utils';
-export * from './shim_abort_signal';
-export * from './to_snake_case';
-export * from './get_total_loaded';