Internationalize some strings, address pr comments

elastic · Mar 18, 2020 · bcf1035 · bcf1035
1 parent ef7b568
commit bcf1035
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 3 deletions.
diff --git a/x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/details/overview/index.tsx b/x-pack/plugins/endpoint/public/applications/endpoint/view/alerts/details/overview/index.tsx
@@ -93,9 +93,22 @@ export const AlertDetailsOverview = styled(
           </EuiText>
           <EuiSpacer />
           <EuiText>
-            Endpoint Status: <EuiHealth color="success">Online</EuiHealth>
+            Endpoint Status:{' '}
+            <EuiHealth color="success">
+              {' '}
+              <FormattedMessage
+                id="xpack.endpoint.application.endpoint.alertDetails.endpoint.status.online"
+                defaultMessage="Online"
+              />
+            </EuiHealth>
+          </EuiText>
+          <EuiText>
+            {' '}
+            <FormattedMessage
+              id="xpack.endpoint.application.endpoint.alertDetails.alert.status.open"
+              defaultMessage="Alert Status: Open"
+            />
           </EuiText>
-          <EuiText>Alert Status: Open</EuiText>
           <EuiSpacer />
           <TakeActionDropdown />
           <EuiSpacer />

diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/store/actions.ts b/x-pack/plugins/endpoint/public/embeddables/resolver/store/actions.ts
@@ -33,7 +33,7 @@ interface UserChangedSelectedEvent {
     /**
      * Optional because they could have unselected the event.
      */
-    selectedEvent?: ResolverEvent;
+    readonly selectedEvent?: ResolverEvent;
   };
 }
 

diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/store/middleware.ts b/x-pack/plugins/endpoint/public/embeddables/resolver/store/middleware.ts
@@ -21,6 +21,9 @@ export const resolverMiddlewareFactory: MiddlewareFactory = context => {
   return api => next => async (action: ResolverAction) => {
     next(action);
     if (action.type === 'userChangedSelectedEvent') {
+      /**
+       * concurrently fetches a process's details, its ancestors, and its related events.
+       */
       if (context?.services.http && action.payload.selectedEvent) {
         api.dispatch({ type: 'appRequestedResolverData' });
         let response = [];

diff --git a/x-pack/plugins/endpoint/public/embeddables/resolver/types.ts b/x-pack/plugins/endpoint/public/embeddables/resolver/types.ts
@@ -275,6 +275,9 @@ export interface SideEffectSimulator {
   mock: jest.Mocked<Omit<SideEffectors, 'ResizeObserver'>> & Pick<SideEffectors, 'ResizeObserver'>;
 }
 
+/**
+ * The internal types of process events used by resolver, mapped from v0 and v1 events.
+ */
 export type ResolverProcessType =
   | 'processCreated'
   | 'processRan'
-Original file line number
+Diff line change
@@ Expand Up / @@ -33,7 +33,7 @@ interface UserChangedSelectedEvent { @@
         /**
          * Optional because they could have unselected the event.
          */
-        selectedEvent?: ResolverEvent;
+        readonly selectedEvent?: ResolverEvent;
       };
     }
@@ Expand Down @@