Use string values for EngineTypes instead of int (#94823) (#95165)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Byron Hulcher <byronhulcher@gmail.com>
elastic · Mar 23, 2021 · bc0e4c7 · bc0e4c7
1 parent afa16c0
commit bc0e4c7
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/types.ts b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engine/types.ts
@@ -9,9 +9,9 @@ import { Schema, SchemaConflicts, IIndexingStatus } from '../../../shared/types'
 import { ApiToken } from '../credentials/types';
 
 export enum EngineTypes {
-  default,
-  indexed,
-  meta,
+  default = 'default',
+  indexed = 'indexed',
+  meta = 'meta',
 }
 export interface Engine {
   name: string;

diff --git a/...enterprise_search/public/applications/app_search/components/engines/engines_logic.test.ts b/...enterprise_search/public/applications/app_search/components/engines/engines_logic.test.ts
@@ -204,15 +204,21 @@ describe('EnginesLogic', () => {
       it('should call loadEngines if engine.type === default', () => {
         jest.spyOn(EnginesLogic.actions, 'loadEngines');
 
-        EnginesLogic.actions.onDeleteEngineSuccess({ ...MOCK_ENGINE, type: EngineTypes.default });
+        EnginesLogic.actions.onDeleteEngineSuccess({
+          ...MOCK_ENGINE,
+          type: 'default' as EngineTypes.default,
+        });
 
         expect(EnginesLogic.actions.loadEngines).toHaveBeenCalled();
       });
 
       it('should call loadMetaEngines if engine.type === meta', () => {
         jest.spyOn(EnginesLogic.actions, 'loadMetaEngines');
 
-        EnginesLogic.actions.onDeleteEngineSuccess({ ...MOCK_ENGINE, type: EngineTypes.meta });
+        EnginesLogic.actions.onDeleteEngineSuccess({
+          ...MOCK_ENGINE,
+          type: 'meta' as EngineTypes.meta,
+        });
 
         expect(EnginesLogic.actions.loadMetaEngines).toHaveBeenCalled();
       });