[Cases] Add space only tests (#99409)

* Starting spaces tests * Finishing space only tests * Refactoring createCaseWithConnector * Fixing spelling * Addressing PR feedback and creating alert tests * Fixing mocks
elastic · May 10, 2021 · b910889 · b910889
1 parent 21d173d
commit b910889
Show file tree

Hide file tree

Showing 46 changed files with 2,173 additions and 139 deletions.
diff --git a/x-pack/plugins/cases/server/client/mocks.ts b/x-pack/plugins/cases/server/client/mocks.ts
@@ -28,6 +28,7 @@ const createCasesSubClientMock = (): CasesSubClientMock => {
     delete: jest.fn(),
     getTags: jest.fn(),
     getReporters: jest.fn(),
+    getCaseIDsByAlertID: jest.fn(),
   };
 };
 

diff --git a/x-pack/scripts/functional_tests.js b/x-pack/scripts/functional_tests.js
@@ -36,6 +36,7 @@ const onlyNotInCoverageTests = [
   require.resolve('../test/alerting_api_integration/security_and_spaces/config.ts'),
   require.resolve('../test/case_api_integration/security_and_spaces/config_basic.ts'),
   require.resolve('../test/case_api_integration/security_and_spaces/config_trial.ts'),
+  require.resolve('../test/case_api_integration/spaces_only/config.ts'),
   require.resolve('../test/apm_api_integration/basic/config.ts'),
   require.resolve('../test/apm_api_integration/trial/config.ts'),
   require.resolve('../test/apm_api_integration/rules/config.ts'),

diff --git a/x-pack/test/case_api_integration/common/lib/authentication/index.ts b/x-pack/test/case_api_integration/common/lib/authentication/index.ts
@@ -7,7 +7,7 @@
 
 import { FtrProviderContext as CommonFtrProviderContext } from '../../../common/ftr_provider_context';
 import { Role, User, UserInfo } from './types';
-import { superUser, users } from './users';
+import { users } from './users';
 import { roles } from './roles';
 import { spaces } from './spaces';
 
@@ -90,5 +90,3 @@ export const deleteSpacesAndUsers = async (getService: CommonFtrProviderContext[
   await deleteSpaces(getService);
   await deleteUsersAndRoles(getService);
 };
-
-export const superUserSpace1Auth = { user: superUser, space: 'space1' };
diff --git a/x-pack/test/case_api_integration/common/lib/mock.ts b/x-pack/test/case_api_integration/common/lib/mock.ts
@@ -31,6 +31,11 @@ import {
 } from '../../../../plugins/cases/common/api';
 
 export const defaultUser = { email: null, full_name: null, username: 'elastic' };
+/**
+ * A null filled user will occur when the security plugin is disabled
+ */
+export const nullUser = { email: null, full_name: null, username: null };
+
 export const postCaseReq: CasePostRequest = {
   description: 'This is a brand new case of a bad meanie defacing data',
   title: 'Super Bad Security Issue',

diff --git a/x-pack/test/case_api_integration/common/lib/utils.ts b/x-pack/test/case_api_integration/common/lib/utils.ts
@@ -12,6 +12,7 @@ import type { KibanaClient } from '@elastic/elasticsearch/api/kibana';
 
 import * as st from 'supertest';
 import supertestAsPromised from 'supertest-as-promised';
+import { ObjectRemover as ActionsRemover } from '../../../alerting_api_integration/common/lib';
 import {
   CASES_URL,
   CASE_CONFIGURE_CONNECTORS_URL,
@@ -45,7 +46,7 @@ import {
   CasesConfigurationsResponse,
   CaseUserActionsResponse,
 } from '../../../../plugins/cases/common/api';
-import { postCollectionReq, postCommentGenAlertReq } from './mock';
+import { getPostCaseRequest, postCollectionReq, postCommentGenAlertReq } from './mock';
 import { getCaseUserActionUrl, getSubCasesUrl } from '../../../../plugins/cases/common/api/helpers';
 import { ContextTypeGeneratedAlertType } from '../../../../plugins/cases/server/connectors';
 import { SignalHit } from '../../../../plugins/security_solution/server/lib/detection_engine/signals/types';
@@ -539,6 +540,16 @@ export const deleteMappings = async (es: KibanaClient): Promise<void> => {
   });
 };
 
+export const superUserSpace1Auth = getAuthWithSuperUser();
+
+/**
+ * Returns an auth object with the specified space and user set as super user. The result can be passed to other utility
+ * functions.
+ */
+export function getAuthWithSuperUser(space: string = 'space1'): { user: User; space: string } {
+  return { user: superUser, space };
+}
+
 export const getSpaceUrlPrefix = (spaceId: string | undefined | null) => {
   return spaceId && spaceId !== 'default' ? `/s/${spaceId}` : ``;
 };
@@ -556,6 +567,72 @@ export const ensureSavedObjectIsAuthorized = (
   entities.forEach((entity) => expect(owners.includes(entity.owner)).to.be(true));
 };
 
+export const createCaseWithConnector = async ({
+  supertest,
+  configureReq = {},
+  servicenowSimulatorURL,
+  actionsRemover,
+  auth = { user: superUser, space: null },
+  createCaseReq = getPostCaseRequest(),
+}: {
+  supertest: st.SuperTest<supertestAsPromised.Test>;
+  servicenowSimulatorURL: string;
+  actionsRemover: ActionsRemover;
+  configureReq?: Record<string, unknown>;
+  auth?: { user: User; space: string | null };
+  createCaseReq?: CasePostRequest;
+}): Promise<{
+  postedCase: CaseResponse;
+  connector: CreateConnectorResponse;
+}> => {
+  const connector = await createConnector({
+    supertest,
+    req: {
+      ...getServiceNowConnector(),
+      config: { apiUrl: servicenowSimulatorURL },
+    },
+    auth,
+  });
+
+  actionsRemover.add(auth.space ?? 'default', connector.id, 'action', 'actions');
+  await createConfiguration(
+    supertest,
+    {
+      ...getConfigurationRequest({
+        id: connector.id,
+        name: connector.name,
+        type: connector.connector_type_id as ConnectorTypes,
+      }),
+      ...configureReq,
+    },
+    200,
+    auth
+  );
+
+  const postedCase = await createCase(
+    supertest,
+    {
+      ...createCaseReq,
+      connector: {
+        id: connector.id,
+        name: connector.name,
+        type: connector.connector_type_id,
+        fields: {
+          urgency: '2',
+          impact: '2',
+          severity: '2',
+          category: 'software',
+          subcategory: 'os',
+        },
+      } as CaseConnector,
+    },
+    200,
+    auth
+  );
+
+  return { postedCase, connector };
+};
+
 export const createCase = async (
   supertest: st.SuperTest<supertestAsPromised.Test>,
   params: CasePostRequest,
@@ -622,19 +699,6 @@ export const createComment = async ({
   return theCase;
 };
 
-export const getAllUserAction = async (
-  supertest: st.SuperTest<supertestAsPromised.Test>,
-  caseId: string,
-  expectedHttpCode: number = 200
-): Promise<CaseUserActionResponse[]> => {
-  const { body: userActions } = await supertest
-    .get(`${CASES_URL}/${caseId}/user_actions`)
-    .set('kbn-xsrf', 'true')
-    .expect(expectedHttpCode);
-
-  return userActions;
-};
-
 export const updateCase = async ({
   supertest,
   params,
@@ -742,13 +806,13 @@ export const getComment = async ({
   caseId,
   commentId,
   expectedHttpCode = 200,
-  auth = { user: superUser },
+  auth = { user: superUser, space: null },
 }: {
   supertest: st.SuperTest<supertestAsPromised.Test>;
   caseId: string;
   commentId: string;
   expectedHttpCode?: number;
-  auth?: { user: User; space?: string };
+  auth?: { user: User; space: string | null };
 }): Promise<CommentResponse> => {
   const { body: comment } = await supertest
     .get(`${getSpaceUrlPrefix(auth.space)}${CASES_URL}/${caseId}/comments/${commentId}`)
@@ -843,13 +907,18 @@ export const createConnector = async ({
   return connector;
 };
 
-export const getCaseConnectors = async (
-  supertest: st.SuperTest<supertestAsPromised.Test>,
-  expectedHttpCode: number = 200
-): Promise<FindActionResult[]> => {
+export const getCaseConnectors = async ({
+  supertest,
+  expectedHttpCode = 200,
+  auth = { user: superUser, space: null },
+}: {
+  supertest: st.SuperTest<supertestAsPromised.Test>;
+  expectedHttpCode?: number;
+  auth?: { user: User; space: string | null };
+}): Promise<FindActionResult[]> => {
   const { body: connectors } = await supertest
-    .get(`${CASE_CONFIGURE_CONNECTORS_URL}/_find`)
-    .set('kbn-xsrf', 'true')
+    .get(`${getSpaceUrlPrefix(auth.space)}${CASE_CONFIGURE_CONNECTORS_URL}/_find`)
+    .auth(auth.user.username, auth.user.password)
     .expect(expectedHttpCode);
 
   return connectors;

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/delete_cases.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/delete_cases.ts
@@ -22,9 +22,10 @@ import {
   deleteCases,
   createComment,
   getComment,
-  getAllUserAction,
   removeServerGeneratedPropertiesFromUserAction,
   getCase,
+  superUserSpace1Auth,
+  getCaseUserActions,
 } from '../../../../common/lib/utils';
 import { getSubCaseDetailsUrl } from '../../../../../../plugins/cases/common/api/helpers';
 import { CaseResponse } from '../../../../../../plugins/cases/common/api';
@@ -39,8 +40,6 @@ import {
   superUser,
 } from '../../../../common/lib/authentication/users';
 
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
-
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {
   const supertestWithoutAuth = getService('supertestWithoutAuth');
@@ -89,7 +88,7 @@ export default ({ getService }: FtrProviderContext): void => {
     it('should create a user action when creating a case', async () => {
       const postedCase = await createCase(supertest, getPostCaseRequest());
       await deleteCases({ supertest, caseIDs: [postedCase.id] });
-      const userActions = await getAllUserAction(supertest, postedCase.id);
+      const userActions = await getCaseUserActions({ supertest, caseID: postedCase.id });
       const creationUserAction = removeServerGeneratedPropertiesFromUserAction(userActions[1]);
 
       expect(creationUserAction).to.eql({

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/patch_cases.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/patch_cases.ts
@@ -32,10 +32,11 @@ import {
   createCase,
   createComment,
   updateCase,
-  getAllUserAction,
+  getCaseUserActions,
   removeServerGeneratedPropertiesFromCase,
   removeServerGeneratedPropertiesFromUserAction,
   findCases,
+  superUserSpace1Auth,
 } from '../../../../common/lib/utils';
 import {
   createSignalsIndex,
@@ -58,7 +59,6 @@ import {
   secOnlyRead,
   superUser,
 } from '../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {
@@ -110,7 +110,7 @@ export default ({ getService }: FtrProviderContext): void => {
           },
         });
 
-        const userActions = await getAllUserAction(supertest, postedCase.id);
+        const userActions = await getCaseUserActions({ supertest, caseID: postedCase.id });
         const statusUserAction = removeServerGeneratedPropertiesFromUserAction(userActions[1]);
         const data = removeServerGeneratedPropertiesFromCase(patchedCases[0]);
 
@@ -149,7 +149,7 @@ export default ({ getService }: FtrProviderContext): void => {
           },
         });
 
-        const userActions = await getAllUserAction(supertest, postedCase.id);
+        const userActions = await getCaseUserActions({ supertest, caseID: postedCase.id });
         const statusUserAction = removeServerGeneratedPropertiesFromUserAction(userActions[1]);
         const data = removeServerGeneratedPropertiesFromCase(patchedCases[0]);
 

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/post_case.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/post_case.ts
@@ -22,7 +22,7 @@ import {
   createCase,
   removeServerGeneratedPropertiesFromCase,
   removeServerGeneratedPropertiesFromUserAction,
-  getAllUserAction,
+  getCaseUserActions,
 } from '../../../../common/lib/utils';
 import {
   secOnly,
@@ -106,7 +106,7 @@ export default ({ getService }: FtrProviderContext): void => {
 
       it('should create a user action when creating a case', async () => {
         const postedCase = await createCase(supertest, getPostCaseRequest());
-        const userActions = await getAllUserAction(supertest, postedCase.id);
+        const userActions = await getCaseUserActions({ supertest, caseID: postedCase.id });
         const creationUserAction = removeServerGeneratedPropertiesFromUserAction(userActions[0]);
 
         const { new_value, ...rest } = creationUserAction as CaseUserActionResponse;

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/status/get_status.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/cases/status/get_status.ts
@@ -15,6 +15,7 @@ import {
   updateCase,
   getAllCasesStatuses,
   deleteAllCaseItems,
+  superUserSpace1Auth,
 } from '../../../../../common/lib/utils';
 import {
   globalRead,
@@ -25,7 +26,6 @@ import {
   secOnlyRead,
   superUser,
 } from '../../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/delete_comment.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/delete_comment.ts
@@ -22,6 +22,7 @@ import {
   createComment,
   deleteComment,
   deleteAllComments,
+  superUserSpace1Auth,
 } from '../../../../common/lib/utils';
 import {
   globalRead,
@@ -33,7 +34,6 @@ import {
   secOnlyRead,
   superUser,
 } from '../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/find_comments.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/find_comments.ts
@@ -28,6 +28,7 @@ import {
   ensureSavedObjectIsAuthorized,
   getSpaceUrlPrefix,
   createCase,
+  superUserSpace1Auth,
 } from '../../../../common/lib/utils';
 
 import {
@@ -40,7 +41,6 @@ import {
   globalRead,
   obsSecRead,
 } from '../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {

diff --git a/...k/test/case_api_integration/security_and_spaces/tests/common/comments/get_all_comments.ts b/...k/test/case_api_integration/security_and_spaces/tests/common/comments/get_all_comments.ts
@@ -18,6 +18,7 @@ import {
   createCase,
   createComment,
   getAllComments,
+  superUserSpace1Auth,
 } from '../../../../common/lib/utils';
 import { CommentType } from '../../../../../../plugins/cases/common/api';
 import {
@@ -31,7 +32,6 @@ import {
   secOnlyRead,
   superUser,
 } from '../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/get_comment.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/get_comment.ts
@@ -17,6 +17,7 @@ import {
   createCase,
   createComment,
   getComment,
+  superUserSpace1Auth,
 } from '../../../../common/lib/utils';
 import { CommentType } from '../../../../../../plugins/cases/common/api';
 import {
@@ -30,7 +31,6 @@ import {
   secOnlyRead,
   superUser,
 } from '../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {

diff --git a/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/patch_comment.ts b/x-pack/test/case_api_integration/security_and_spaces/tests/common/comments/patch_comment.ts
@@ -34,6 +34,7 @@ import {
   createCase,
   createComment,
   updateComment,
+  superUserSpace1Auth,
 } from '../../../../common/lib/utils';
 import {
   globalRead,
@@ -45,7 +46,6 @@ import {
   secOnlyRead,
   superUser,
 } from '../../../../common/lib/authentication/users';
-import { superUserSpace1Auth } from '../../../../common/lib/authentication';
 
 // eslint-disable-next-line import/no-default-export
 export default ({ getService }: FtrProviderContext): void => {