Skip to content

Commit

Permalink
[ML] fix typing issue
Browse files Browse the repository at this point in the history
  • Loading branch information
darnautov committed Mar 22, 2020
1 parent c67dc3a commit a46aa53
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ export class DataRecognizer {
end: number | undefined,
jobOverrides: JobOverride[],
datafeedOverrides: DatafeedOverride[],
estimateModelMemory: boolean | undefined
estimateModelMemory?: boolean
) {
// load the config from disk
const moduleConfig = await this.getModule(moduleId, jobPrefix);
Expand Down
9 changes: 6 additions & 3 deletions x-pack/plugins/ml/server/shared_services/providers/modules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ export interface ModulesProvider {
start: number,
end: number,
jobOverrides: JobOverride[],
datafeedOverrides: DatafeedOverride[]
datafeedOverrides: DatafeedOverride[],
estimateModelMemory?: boolean
): Promise<DataRecognizerConfigResponse>;
};
}
Expand Down Expand Up @@ -65,7 +66,8 @@ export function getModulesProvider(isFullLicense: LicenseCheck): ModulesProvider
start: number,
end: number,
jobOverrides: JobOverride[],
datafeedOverrides: DatafeedOverride[]
datafeedOverrides: DatafeedOverride[],
estimateModelMemory?: boolean
) {
const dr = dataRecognizerFactory(callAsCurrentUser, savedObjectsClient);
return dr.setupModuleItems(
Expand All @@ -79,7 +81,8 @@ export function getModulesProvider(isFullLicense: LicenseCheck): ModulesProvider
start,
end,
jobOverrides,
datafeedOverrides
datafeedOverrides,
estimateModelMemory
);
},
};
Expand Down

0 comments on commit a46aa53

Please sign in to comment.