Skip to content

Commit

Permalink
[8.x] [Response Ops][Rules] Rule Model Version Forward Compat (#193233)…
Browse files Browse the repository at this point in the history
… (#193695)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Response Ops][Rules] Rule Model Version Forward Compat
(#193233)](#193233)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jiawei
Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-20T08:50:54Z","message":"[Response
Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n##
Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for
the rule model\r\nversion in preparation for the flapping
PR\r\n(#190019). We're doing this
so we\r\nhave the point to revert back to if we need to where
the\r\n`forwardCompatibility` is
defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response
Ops][Rules] Rule Model Version Forward
Compat","number":193233,"url":"https://github.com/elastic/kibana/pull/193233","mergeCommit":{"message":"[Response
Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n##
Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for
the rule model\r\nversion in preparation for the flapping
PR\r\n(#190019). We're doing this
so we\r\nhave the point to revert back to if we need to where
the\r\n`forwardCompatibility` is
defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193233","number":193233,"mergeCommit":{"message":"[Response
Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n##
Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for
the rule model\r\nversion in preparation for the flapping
PR\r\n(#190019). We're doing this
so we\r\nhave the point to revert back to if we need to where
the\r\n`forwardCompatibility` is
defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
  • Loading branch information
kibanamachine and JiaweiWu authored Sep 23, 2024
1 parent 6cc4fdc commit 9c356e8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ describe('checking migration metadata changes on all registered SO types', () =>
"action": "0e6fc0b74c7312a8c11ff6b14437b93a997358b8",
"action_task_params": "b50cb5c8a493881474918e8d4985e61374ca4c30",
"ad_hoc_run_params": "d4e3c5c794151d0a4f5c71e886b2aa638da73ad2",
"alert": "3a67d3f1db80af36bd57aaea47ecfef87e43c58f",
"alert": "e920b0583b1a32338d5dbbbfabb6ff2a511f5f6c",
"api_key_pending_invalidation": "1399e87ca37b3d3a65d269c924eda70726cfe886",
"apm-custom-dashboards": "b67128f78160c288bd7efe25b2da6e2afd5e82fc",
"apm-indices": "8a2d68d415a4b542b26b0d292034a28ffac6fed4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export const ruleModelVersions: SavedObjectsModelVersionMap = {
'1': {
changes: [],
schemas: {
forwardCompatibility: rawRuleSchemaV1.extends({}, { unknowns: 'ignore' }),
create: rawRuleSchemaV1,
},
},
Expand Down

0 comments on commit 9c356e8

Please sign in to comment.