uiState should trigger normal reload path

elastic · Jul 12, 2017 · 9a08034 · 9a08034
1 parent deaf3ed
commit 9a08034
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/src/core_plugins/kibana/public/visualize/editor/editor.js b/src/core_plugins/kibana/public/visualize/editor/editor.js
@@ -106,7 +106,7 @@ function VisEditor($scope, $route, timefilter, AppState, $window, kbnUrl, courie
     key: 'refresh',
     description: 'Refresh',
     run: function () {
-      vis.emit('reload');
+      vis.forceReload();
     },
     testId: 'visualizeRefreshButton',
   }];

diff --git a/src/ui/public/vis/vis.js b/src/ui/public/vis/vis.js
@@ -98,6 +98,10 @@ export function VisProvider(Private, indexPatterns, timefilter, getAppState) {
       this.setCurrentState(this._state);
     }
 
+    forceReload() {
+      this.emit('reload');
+    }
+
     getCurrentState(includeDisabled) {
       return {
         title: this.title,

diff --git a/src/ui/public/visualize/visualize.js b/src/ui/public/visualize/visualize.js
@@ -15,7 +15,7 @@ import {
 
 uiModules
 .get('kibana/directive', ['ngSanitize'])
-.directive('visualize', function (Notifier, Private, timefilter, getAppState, $timeout) {
+.directive('visualize', function (Notifier, Private, timefilter, getAppState) {
   const notify = new Notifier({ location: 'Visualize' });
   const requestHandlers = Private(VisRequestHandlersRegistryProvider);
   const responseHandlers = Private(VisResponseHandlersRegistryProvider);
@@ -106,9 +106,7 @@ uiModules
             // current visualizations uiState changed.
             if (!oldUiState || oldUiState !== JSON.stringify($scope.uiState.toJSON())) {
               oldUiState = JSON.stringify($scope.uiState.toJSON());
-              $timeout(() => {
-                $scope.$broadcast('render');
-              });
+              $scope.fetch();
             }
           }
         });