Merge remote-tracking branch 'upstream/master' into migrate-docview

.eslintrc.js

@@ -69,12 +69,6 @@ module.exports = {
         'jsx-a11y/no-onchange': 'off',
       },
     },
-    {
-      files: ['src/legacy/core_plugins/data/**/*.{js,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: ['src/legacy/core_plugins/expressions/**/*.{js,ts,tsx}'],
       rules: {
@@ -142,7 +136,7 @@ module.exports = {
       },
     },
     {
-      files: ['x-pack/legacy/plugins/ml/**/*.{js,ts,tsx}'],
+      files: ['x-pack/plugins/ml/**/*.{js,ts,tsx}'],
       rules: {
         'react-hooks/exhaustive-deps': 'off',
       },
@@ -322,6 +316,7 @@ module.exports = {
         'x-pack/test/functional/apps/**/*.js',
         'x-pack/legacy/plugins/apm/**/*.js',
         'test/*/config.ts',
+        'test/*/config_open.ts',
         'test/*/{tests,test_suites,apis,apps}/**/*',
         'test/visual_regression/tests/**/*',
         'x-pack/test/*/{tests,test_suites,apis,apps}/**/*',

.github/CODEOWNERS

@@ -26,36 +26,35 @@
 /src/plugins/kibana_legacy/ @elastic/kibana-app
 /src/plugins/timelion/ @elastic/kibana-app
 /src/plugins/dev_tools/ @elastic/kibana-app
-/src/plugins/dashboard_embeddable_container/ @elastic/kibana-app
+/src/plugins/dashboard/ @elastic/kibana-app
 
 # App Architecture
+/examples/url_generators_examples/ @elastic/kibana-app-arch
+/examples/url_generators_explorer/ @elastic/kibana-app-arch
 /packages/kbn-interpreter/ @elastic/kibana-app-arch
-/src/legacy/core_plugins/data/ @elastic/kibana-app-arch
-/src/legacy/core_plugins/elasticsearch/lib/create_proxy.js @elastic/kibana-app-arch
 /src/legacy/core_plugins/embeddable_api/ @elastic/kibana-app-arch
 /src/legacy/core_plugins/interpreter/ @elastic/kibana-app-arch
 /src/legacy/core_plugins/kibana_react/ @elastic/kibana-app-arch
 /src/legacy/core_plugins/kibana/public/management/ @elastic/kibana-app-arch
-/src/legacy/core_plugins/kibana/server/field_formats/ @elastic/kibana-app-arch
 /src/legacy/core_plugins/kibana/server/routes/api/management/ @elastic/kibana-app-arch
-/src/legacy/core_plugins/kibana/server/routes/api/suggestions/ @elastic/kibana-app-arch
 /src/legacy/core_plugins/visualizations/ @elastic/kibana-app-arch
 /src/legacy/server/index_patterns/ @elastic/kibana-app-arch
+/src/plugins/advanced_settings/ @elastic/kibana-app-arch
 /src/plugins/bfetch/ @elastic/kibana-app-arch
 /src/plugins/data/ @elastic/kibana-app-arch
 /src/plugins/embeddable/ @elastic/kibana-app-arch
 /src/plugins/expressions/ @elastic/kibana-app-arch
 /src/plugins/inspector/ @elastic/kibana-app-arch
 /src/plugins/kibana_react/ @elastic/kibana-app-arch
+/src/plugins/kibana_react/public/code_editor @elastic/kibana-canvas
 /src/plugins/kibana_utils/ @elastic/kibana-app-arch
 /src/plugins/management/ @elastic/kibana-app-arch
 /src/plugins/navigation/ @elastic/kibana-app-arch
+/src/plugins/share/ @elastic/kibana-app-arch
 /src/plugins/ui_actions/ @elastic/kibana-app-arch
 /src/plugins/visualizations/ @elastic/kibana-app-arch
-/src/plugins/share/ @elastic/kibana-app-arch
-/examples/url_generators_examples/ @elastic/kibana-app-arch
-/examples/url_generators_explorer/ @elastic/kibana-app-arch
 /x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch
+/x-pack/plugins/data_enhanced/ @elastic/kibana-app-arch
 /x-pack/plugins/drilldowns/ @elastic/kibana-app-arch
 
 # APM
@@ -75,9 +74,9 @@
 # Observability UIs
 /x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui
 /x-pack/plugins/infra/ @elastic/logs-metrics-ui
-/x-pack/plugins/ingest_manager/ @elastic/ingest
-/x-pack/legacy/plugins/ingest_manager/ @elastic/ingest
-/x-pack/plugins/observability/ @elastic/logs-metrics-ui @elastic/apm-ui @elastic/uptime @elastic/ingest
+/x-pack/plugins/ingest_manager/ @elastic/ingest-management
+/x-pack/legacy/plugins/ingest_manager/ @elastic/ingest-management
+/x-pack/plugins/observability/ @elastic/logs-metrics-ui @elastic/apm-ui @elastic/uptime @elastic/ingest-management
 /x-pack/legacy/plugins/monitoring/ @elastic/stack-monitoring-ui
 
 # Machine Learning

.github/workflows/pr-project-assigner.yml

@@ -8,14 +8,14 @@ jobs:
     name: Assign a PR to project based on label
     steps:
       - name: Assign to project
-        uses: elastic/github-actions/project-assigner@v1.0.3
+        uses: elastic/github-actions/project-assigner@v2.0.0
         id: project_assigner
         with:
           issue-mappings: |
             [
             ]
           ghToken: ${{ secrets.PROJECT_ASSIGNER_TOKEN }}
 
-#              { "label": "Team:AppArch", "projectName": "kibana-app-arch", "columnId": 6173897 },
-#              { "label": "Feature:Lens", "projectName": "Lens", "columnId": 6219362 },
-#              { "label": "Team:Canvas", "projectName": "canvas", "columnId": 6187580 }
+# { "label": "Team:AppArch", "projectNumber": 37, "columnName": "Review in progress" },
+# { "label": "Feature:Lens", "projectNumber": 32, "columnName": "In progress" },
+# { "label": "Team:Canvas", "projectNumber": 38, "columnName": "Review in progress" }

.github/workflows/project-assigner.yml

@@ -8,10 +8,10 @@ jobs:
     name: Assign issue or PR to project based on label
     steps:
       - name: Assign to project
-        uses: elastic/github-actions/project-assigner@v1.0.3
+        uses: elastic/github-actions/project-assigner@v2.0.0
         id: project_assigner
         with:
-          issue-mappings: '[{"label": "Team:AppArch", "projectName": "kibana-app-arch", "columnId": 6173895}, {"label": "Feature:Lens", "projectName": "Lens", "columnId": 6219363}, {"label": "Team:Canvas", "projectName": "canvas", "columnId": 6187593}]'
+          issue-mappings: '[{"label": "Team:AppArch", "projectNumber": 37, "columnName": "To triage"}, {"label": "Feature:Lens", "projectNumber": 32, "columnName": "Long-term goals"}, {"label": "Team:Canvas", "projectNumber": 38, "columnName": "Inbox"}]'
           ghToken: ${{ secrets.PROJECT_ASSIGNER_TOKEN }}
 
 

.gitignore

@@ -4,7 +4,6 @@
 /.es
 .DS_Store
 .node_binaries
-.native_modules
 node_modules
 !/src/dev/npm/integration_tests/__fixtures__/fixture1/node_modules
 !/src/dev/notice/__fixtures__/node_modules

.i18nrc.json

@@ -3,12 +3,9 @@
     "common.ui": "src/legacy/ui",
     "console": "src/plugins/console",
     "core": "src/core",
-    "dashboardEmbeddableContainer": "src/plugins/dashboard_embeddable_container",
-    "data": [
-      "src/legacy/core_plugins/data",
-      "src/plugins/data"
-    ],
     "discover": "src/plugins/discover",
+    "dashboard": "src/plugins/dashboard",
+    "data": "src/plugins/data",
     "embeddableApi": "src/plugins/embeddable",
     "embeddableExamples": "examples/embeddable_examples",
     "share": "src/plugins/share",

.sass-lint.yml

@@ -7,6 +7,7 @@ files:
     - 'x-pack/legacy/plugins/rollup/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
+    - 'x-pack/plugins/triggers_actions_ui/**/*.s+(a|c)ss'
   ignore:
     - 'x-pack/legacy/plugins/canvas/shareable_runtime/**/*.s+(a|c)ss'
     - 'x-pack/legacy/plugins/lens/**/*.s+(a|c)ss'

CONTRIBUTING.md

@@ -171,6 +171,8 @@ Bootstrap Kibana and install all the dependencies
 yarn kbn bootstrap
 ```
 
+> Node.js native modules could be in use and node-gyp is the tool used to build them. There are tools you need to install per platform and python versions you need to be using. Please see https://github.com/nodejs/node-gyp#installation and follow the guide according your platform.
+
 (You can also run `yarn kbn` to see the other available commands. For more info about this tool, see https://github.com/elastic/kibana/tree/master/packages/kbn-pm.)
 
 When switching branches which use different versions of npm packages you may need to run;

Jenkinsfile

@@ -40,7 +40,12 @@ kibanaPipeline(timeoutMinutes: 135, checkPrChanges: true) {
           'xpack-ciGroup9': kibanaPipeline.xpackCiGroupProcess(9),
           'xpack-ciGroup10': kibanaPipeline.xpackCiGroupProcess(10),
           'xpack-accessibility': kibanaPipeline.functionalTestProcess('xpack-accessibility', './test/scripts/jenkins_xpack_accessibility.sh'),
-          'xpack-siemCypress': kibanaPipeline.functionalTestProcess('xpack-siemCypress', './test/scripts/jenkins_siem_cypress.sh'),
+          'xpack-siemCypress': { processNumber ->
+            whenChanged(['x-pack/legacy/plugins/siem/', 'x-pack/test/siem_cypress/']) {
+              kibanaPipeline.functionalTestProcess('xpack-siemCypress', './test/scripts/jenkins_siem_cypress.sh')(processNumber)
+            }
+          },
+
           // 'xpack-visualRegression': kibanaPipeline.functionalTestProcess('xpack-visualRegression', './test/scripts/jenkins_xpack_visual_regression.sh'),
         ]),
       ])

docs/api/dashboard/export-dashboard.asciidoc

@@ -9,7 +9,7 @@ experimental[] Export dashboards and corresponding saved objects.
 [[dashboard-api-export-request]]
 ==== Request
 
-`GET /api/kibana/dashboards/export`
+`GET <kibana host>:<port>/api/kibana/dashboards/export`
 
 [[dashboard-api-export-params]]
 ==== Query parameters
@@ -20,9 +20,9 @@ experimental[] Export dashboards and corresponding saved objects.
 [[dashboard-api-export-response-body]]
 ==== Response body
 
-`objects`:: 
+`objects`::
   (array) A top level property that includes the saved objects. The order of the objects is not guaranteed. Use the exact response body as the request body for the corresponding <<dashboard-import-api, Import dashboard API>>.
-  
+
 [[dashboard-api-export-codes]]
 ==== Response code
 
@@ -33,10 +33,10 @@ experimental[] Export dashboards and corresponding saved objects.
 [[dashboard-api-export-example]]
 ==== Example
 
-[source,js]
+[source,sh]
 --------------------------------------------------
-GET api/kibana/dashboards/export?dashboard=942dcef0-b2cd-11e8-ad8e-85441f0c2e5c <1>
+$ curl -X GET "localhost:5601/api/kibana/dashboards/export?dashboard=942dcef0-b2cd-11e8-ad8e-85441f0c2e5c" <1>
 --------------------------------------------------
 // KIBANA
 
-<1> The dashboard ID is `942dcef0-b2cd-11e8-ad8e-85441f0c2e5c`.
+<1> The dashboard ID is `942dcef0-b2cd-11e8-ad8e-85441f0c2e5c`.

docs/api/dashboard/import-dashboard.asciidoc

@@ -9,7 +9,7 @@ experimental[] Import dashboards and corresponding saved objects.
 [[dashboard-api-import-request]]
 ==== Request
 
-`POST /api/kibana/dashboards/import`
+`POST <kibana host>:<port>/api/kibana/dashboards/import`
 
 [[dashboard-api-import-params]]
 ==== Query parameters
@@ -40,9 +40,9 @@ Use the complete response body from the <<dashboard-api-export, Export dashboard
 [[dashboard-api-import-example]]
 ==== Example
 
-[source,js]
+[source,sh]
 --------------------------------------------------
-POST api/kibana/dashboards/import?exclude=index-pattern
+$ curl -X POST "localhost:5601/api/kibana/dashboards/import?exclude=index-pattern"
 {
   "objects": [
     {

docs/api/features.asciidoc

@@ -8,7 +8,7 @@ experimental[] Retrieves all {kib} features. Features are used by spaces and sec
 [[features-api-get-request]]
 === Request
 
-`GET /api/features`
+`GET <kibana host>:<port>/api/features`
 
 [float]
 [[features-api-get-codes]]
@@ -23,7 +23,7 @@ experimental[] Retrieves all {kib} features. Features are used by spaces and sec
 
 The API returns the following:
 
-[source,js]
+[source,sh]
 --------------------------------------------------
   {
     "id": "discover",

docs/api/logstash-configuration-management.asciidoc

@@ -2,9 +2,9 @@
 [[logstash-configuration-management-api]]
 == Logstash configuration management APIs
 
-Programmatically integrate with the Logstash configuration management feature.
+Programmatically integrate with Logstash configuration management.
 
-WARNING: Do not directly access the `.logstash` index. The structure of the `.logstash` index is subject to change, which could cause your integration to break. Instead, use the Logstash configuration management APIs. 
+WARNING: Do not directly access the `.logstash` index. The structure of the `.logstash` index is subject to change, which could cause your integration to break. Instead, use the Logstash configuration management APIs.
 
 The following Logstash configuration management APIs are available:
 
@@ -20,5 +20,3 @@ include::logstash-configuration-management/delete-pipeline.asciidoc[]
 include::logstash-configuration-management/list-pipeline.asciidoc[]
 include::logstash-configuration-management/create-logstash.asciidoc[]
 include::logstash-configuration-management/retrieve-pipeline.asciidoc[]
-
-

docs/api/logstash-configuration-management/create-logstash.asciidoc

@@ -9,7 +9,7 @@ experimental[] Create a centrally-managed Logstash pipeline, or update an existi
 [[logstash-configuration-management-api-create-request]]
 ==== Request
 
-`PUT /api/logstash/pipeline/<id>`
+`PUT <kibana host>:<port>/api/logstash/pipeline/<id>`
 
 [[logstash-configuration-management-api-create-params]]
 ==== Path parameters
@@ -39,9 +39,9 @@ experimental[] Create a centrally-managed Logstash pipeline, or update an existi
 [[logstash-configuration-management-api-create-example]]
 ==== Example
 
-[source,js]
+[source,sh]
 --------------------------------------------------
-PUT api/logstash/pipeline/hello-world
+$ curl -X PUT "localhost:5601/api/logstash/pipeline/hello-world"
 {
   "pipeline": "input { stdin {} } output { stdout {} }",
   "settings": {

docs/api/logstash-configuration-management/delete-pipeline.asciidoc

@@ -9,7 +9,7 @@ experimental[] Delete a centrally-managed Logstash pipeline.
 [[logstash-configuration-management-api-delete-request]]
 ==== Request
 
-`DELETE /api/logstash/pipeline/<id>`
+`DELETE <kibana host>:<port>/api/logstash/pipeline/<id>`
 
 [[logstash-configuration-management-api-delete-params]]
 ==== Path parameters
@@ -26,9 +26,8 @@ experimental[] Delete a centrally-managed Logstash pipeline.
 [[logstash-configuration-management-api-delete-example]]
 ==== Example
 
-[source,js]
+[source,sh]
 --------------------------------------------------
-DELETE api/logstash/pipeline/hello-world
+$ curl -X DELETE "localhost:5601/api/logstash/pipeline/hello-world"
 --------------------------------------------------
 // KIBANA
-

docs/api/logstash-configuration-management/list-pipeline.asciidoc

@@ -9,14 +9,14 @@ experimental[] List all centrally-managed Logstash pipelines.
 [[logstash-configuration-management-api-list-request]]
 ==== Request
 
-`GET /api/logstash/pipelines`
+`GET <kibana host>:<port>/api/logstash/pipelines`
 
 [[logstash-configuration-management-api-list-example]]
 ==== Example
 
 The API returns the following:
 
-[source,js]
+[source,sh]
 --------------------------------------------------
 {
   "pipelines": [
@@ -35,4 +35,4 @@ The API returns the following:
 }
 --------------------------------------------------
 
-<1> The `username` property appears when security is enabled, and depends on when the pipeline was created or last updated.
+<1> The `username` property appears when security is enabled, and depends on when the pipeline was created or last updated.

docs/api/logstash-configuration-management/retrieve-pipeline.asciidoc

@@ -9,20 +9,20 @@ experimental[] Retrieve a centrally-managed Logstash pipeline.
 [[logstash-configuration-management-api-retrieve-request]]
 ==== Request
 
-`GET /api/logstash/pipeline/<id>`
+`GET <kibana host>:<port>/api/logstash/pipeline/<id>`
 
 [[logstash-configuration-management-api-retrieve-path-params]]
 ==== Path parameters
 
 `id`::
   (Required, string) The pipeline ID.
-  
+
 [[logstash-configuration-management-api-retrieve-example]]
 ==== Example
 
 The API returns the following:
 
-[source,js]
+[source,sh]
 --------------------------------------------------
 {
   "id": "hello-world",
@@ -33,4 +33,4 @@ The API returns the following:
     "queue.type": "persistent"
   }
 }
---------------------------------------------------
+--------------------------------------------------

docs/api/role-management.asciidoc

@@ -2,9 +2,9 @@
 [[role-management-api]]
 == {kib} role management APIs
 
-Manage the roles that grant <<kibana-privileges, Kibana privileges>>.
+Manage the roles that grant <<kibana-privileges, {kib} privileges>>.
 
-WARNING: Do not use the {ref}/security-api.html#security-role-apis[{es} role management APIs] to manage {kib} roles. 
+WARNING: Do not use the {ref}/security-api.html#security-role-apis[{es} role management APIs] to manage {kib} roles.
 
 The following {kib} role management APIs are available: