[Security Solution] Remove SavedObjects client UI for CTI and risk sc…

…ores module (#156213)

## Summary

issue: #155995


1. Remove SO client from UI.
2. Replace **Kibana** dashboard url with **Security** dashboard url in
threat intel overview.

### Checklist

Delete any items that are not applicable to this PR.


- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Angela Chuang <yi-chun.chuang@elastic.co>
Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>

x-pack/plugins/security_solution/public/common/containers/dashboards/api/__mocks__/index.ts → x-pack/plugins/security_solution/public/common/containers/dashboards/__mocks__/api.ts

@@ -5,19 +5,6 @@
  * 2.0.
  */
 
-import { SECURITY_TAG_NAME, SECURITY_TAG_DESCRIPTION } from '../../../../../../common/constants';
-
-export const MOCK_TAG_ID = 'securityTagId';
-
-export const DEFAULT_TAGS_RESPONSE = [
-  {
-    id: MOCK_TAG_ID,
-    name: SECURITY_TAG_NAME,
-    description: SECURITY_TAG_DESCRIPTION,
-    color: '#2c7b82',
-  },
-];
-
 export const DEFAULT_DASHBOARDS_RESPONSE = [
   {
     type: 'dashboard',
@@ -44,10 +31,6 @@ export const DEFAULT_DASHBOARDS_RESPONSE = [
   },
 ];
 
-export const getSecuritySolutionTags = jest
-  .fn()
-  .mockImplementation(() => Promise.resolve(DEFAULT_TAGS_RESPONSE));
-
-export const getSecuritySolutionDashboards = jest
+export const getDashboardsByTagIds = jest
   .fn()
   .mockImplementation(() => Promise.resolve(DEFAULT_DASHBOARDS_RESPONSE));

x-pack/plugins/security_solution/public/common/containers/dashboards/api.ts

@@ -0,0 +1,28 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { HttpSetup } from '@kbn/core/public';
+import { INTERNAL_DASHBOARDS_URL } from '../../../../common/constants';
+
+export interface Dashboard {
+  id: string;
+  type: string;
+  attributes: {
+    title: string;
+    description: string;
+  };
+  references: Array<{ name: string; type: string; id: string }>;
+}
+
+export const getDashboardsByTagIds = (
+  { http, tagIds }: { http: HttpSetup; tagIds: string[] },
+  abortSignal?: AbortSignal
+): Promise<Dashboard[] | null> =>
+  http.post(INTERNAL_DASHBOARDS_URL, {
+    body: JSON.stringify({ tagIds }),
+    signal: abortSignal,
+  });

x-pack/plugins/security_solution/public/common/containers/tags/__mocks__/api.ts

@@ -0,0 +1,24 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+export const MOCK_TAG_ID = 'securityTagId';
+
+export const DEFAULT_TAGS_RESPONSE = [
+  {
+    id: MOCK_TAG_ID,
+    name: 'test tag',
+    description: 'test tag description',
+    color: '#2c7b82',
+  },
+];
+
+export const getTagsByName = jest
+  .fn()
+  .mockImplementation(() => Promise.resolve(DEFAULT_TAGS_RESPONSE));
+export const createTag = jest
+  .fn()
+  .mockImplementation(() => Promise.resolve(DEFAULT_TAGS_RESPONSE[0]));

x-pack/plugins/security_solution/public/common/containers/tags/api.ts

@@ -0,0 +1,25 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import type { HttpSetup } from '@kbn/core/public';
+import type { Tag } from '@kbn/saved-objects-tagging-plugin/public';
+import type { TagAttributes } from '@kbn/saved-objects-tagging-plugin/common';
+import { INTERNAL_TAGS_URL } from '../../../../common/constants';
+
+export const getTagsByName = (
+  { http, tagName }: { http: HttpSetup; tagName: string },
+  abortSignal?: AbortSignal
+): Promise<Tag[]> => http.get(INTERNAL_TAGS_URL, { query: { name: tagName }, signal: abortSignal });
+
+export const createTag = (
+  { http, tag }: { http: HttpSetup; tag: Omit<TagAttributes, 'color'> & { color?: string } },
+  abortSignal?: AbortSignal
+): Promise<Tag> =>
+  http.put(INTERNAL_TAGS_URL, {
+    body: JSON.stringify(tag),
+    signal: abortSignal,
+  });

x-pack/plugins/security_solution/public/common/hooks/use_fetch/request_names.ts

@@ -8,6 +8,9 @@ import { APP_UI_ID } from '../../../../common/constants';
 
 export const REQUEST_NAMES = {
   SECURITY_DASHBOARDS: `${APP_UI_ID} fetch security dashboards`,
+  SECURITY_TAGS: `${APP_UI_ID} fetch security tags`,
+  SECURITY_CREATE_TAG: `${APP_UI_ID} fetch security create tag`,
+  CTI_TAGS: `${APP_UI_ID} fetch cti tags`,
   ANOMALIES_TABLE: `${APP_UI_ID} fetch anomalies table data`,
   GET_RISK_SCORE_DEPRECATED: `${APP_UI_ID} fetch is risk score deprecated`,
   ENABLE_RISK_SCORE: `${APP_UI_ID} fetch enable risk score`,

x-pack/plugins/security_solution/public/common/hooks/use_fetch/use_fetch.test.tsx

@@ -112,7 +112,7 @@ describe('useFetch', () => {
     });
 
     expect(result.current.data).toEqual(undefined);
-    expect(result.current.isLoading).toEqual(true);
+    expect(result.current.isLoading).toEqual(false);
     expect(result.current.error).toEqual(undefined);
 
     expect(mockFetchFn).not.toHaveBeenCalled();

x-pack/plugins/security_solution/public/common/hooks/use_fetch/use_fetch.ts

@@ -122,7 +122,7 @@ export const useFetch = <Parameters, Response, Error extends unknown>(
     Reducer<State<Parameters, Response, Error>, Action<Parameters, Response, Error>>
   >(requestReducer, {
     data: undefined,
-    isLoading: initialParameters !== undefined, // isLoading state is used internally to control fetch executions
+    isLoading: !disabled && initialParameters !== undefined, // isLoading state is used internally to control fetch executions
     error: undefined,
     parameters: initialParameters,
   });

x-pack/plugins/security_solution/public/common/components/dashboards/dashboard_renderer.test.tsx → x-pack/plugins/security_solution/public/dashboards/components/dashboard_renderer.test.tsx

@@ -6,7 +6,7 @@
  */
 import { render } from '@testing-library/react';
 import React from 'react';
-import { TestProviders } from '../../mock';
+import { TestProviders } from '../../common/mock';
 import { DashboardRenderer } from './dashboard_renderer';
 
 jest.mock('@kbn/dashboard-plugin/public', () => {

x-pack/plugins/security_solution/public/common/components/dashboards/dashboard_renderer.tsx → x-pack/plugins/security_solution/public/dashboards/components/dashboard_renderer.tsx

@@ -11,8 +11,8 @@ import { ViewMode } from '@kbn/embeddable-plugin/public';
 import type { Filter, Query } from '@kbn/es-query';
 
 import { useDispatch } from 'react-redux';
-import { InputsModelId } from '../../store/inputs/constants';
-import { inputsActions } from '../../store/inputs';
+import { InputsModelId } from '../../common/store/inputs/constants';
+import { inputsActions } from '../../common/store/inputs';
 
 const DashboardRendererComponent = ({
   canReadDashboard,

x-pack/plugins/security_solution/public/common/components/dashboards/dashboards_table.test.tsx → x-pack/plugins/security_solution/public/dashboards/components/dashboards_table.test.tsx

@@ -7,8 +7,8 @@
 
 import React from 'react';
 import { fireEvent, render } from '@testing-library/react';
-import { TestProviders } from '../../mock';
 import { DashboardsTable } from './dashboards_table';
+import { TestProviders } from '../../common/mock';
 
 // mock lodash debounce to speed up the test
 jest.mock('lodash', () => ({ ...jest.requireActual('lodash'), debounce: (fn: () => void) => fn }));
@@ -35,8 +35,8 @@ const mockUseSecurityDashboardsTableItems = jest.fn(() => ({
   items: DASHBOARD_TABLE_ITEMS,
   isLoading: false,
 }));
-jest.mock('../../containers/dashboards/use_security_dashboards_table', () => {
-  const actual = jest.requireActual('../../containers/dashboards/use_security_dashboards_table');
+jest.mock('../hooks/use_security_dashboards_table', () => {
+  const actual = jest.requireActual('../hooks/use_security_dashboards_table');
   return {
     ...actual,
     useSecurityDashboardsTableItems: () => mockUseSecurityDashboardsTableItems(),

x-pack/plugins/security_solution/public/common/components/dashboards/dashboards_table.tsx → x-pack/plugins/security_solution/public/dashboards/components/dashboards_table.tsx

@@ -13,8 +13,8 @@ import { i18n } from '@kbn/i18n';
 import {
   useSecurityDashboardsTableItems,
   useSecurityDashboardsTableColumns,
-} from '../../containers/dashboards/use_security_dashboards_table';
-import { useAppToasts } from '../../hooks/use_app_toasts';
+} from '../hooks/use_security_dashboards_table';
+import { useAppToasts } from '../../common/hooks/use_app_toasts';
 
 export const DASHBOARDS_QUERY_ERROR = i18n.translate(
   'xpack.securitySolution.dashboards.queryError',