Skip to content

Commit

Permalink
fix update on bulk action
Browse files Browse the repository at this point in the history
  • Loading branch information
XavierM authored and dplumlee committed Sep 13, 2021
1 parent 7ae35e7 commit 93970db
Show file tree
Hide file tree
Showing 4 changed files with 32 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const StatefulEventsViewerComponent: React.FC<Props> = ({
entityType,
excludedRowRendererIds,
filters,
globalQuery,
id,
isLive,
itemsPerPage,
Expand All @@ -102,6 +103,7 @@ const StatefulEventsViewerComponent: React.FC<Props> = ({
scopeId,
showCheckboxes,
sort,
timelineQuery,
utilityBar,
additionalFilters,
// If truthy, the graph viewer (Resolver) is showing
Expand Down Expand Up @@ -157,6 +159,18 @@ const StatefulEventsViewerComponent: React.FC<Props> = ({
[dispatch, id]
);

const refetchQuery = (newQueries: inputsModel.GlobalQuery[]) => {
newQueries.forEach((q) => q.refetch && (q.refetch as inputsModel.Refetch)());
};
const onAlertStatusActionSuccess = useCallback(() => {
if (id === TimelineId.active) {
refetchQuery([timelineQuery]);
} else {
refetchQuery(globalQuery);
}
}, [id, timelineQuery, globalQuery]);
const bulkActions = useMemo(() => ({ onAlertStatusActionSuccess }), [onAlertStatusActionSuccess]);

return (
<>
<FullScreenContainer $isFullScreen={globalFullScreen}>
Expand All @@ -166,6 +180,7 @@ const StatefulEventsViewerComponent: React.FC<Props> = ({
id,
type: 'embedded',
browserFields,
bulkActions,
columns,
dataProviders: dataProviders!,
defaultCellActions,
Expand Down Expand Up @@ -245,6 +260,8 @@ const makeMapStateToProps = () => {
const getGlobalQuerySelector = inputsSelectors.globalQuerySelector();
const getGlobalFiltersQuerySelector = inputsSelectors.globalFiltersQuerySelector();
const getTimeline = timelineSelectors.getTimelineByIdSelector();
const getGlobalQueries = inputsSelectors.globalQuery();
const getTimelineQuery = inputsSelectors.timelineQueryByIdSelector();
const mapStateToProps = (state: State, { id, defaultModel }: OwnProps) => {
const input: inputsModel.InputsRange = getInputsTimeline(state);
const timeline: TimelineModel = getTimeline(state, id) ?? defaultModel;
Expand Down Expand Up @@ -280,6 +297,8 @@ const makeMapStateToProps = () => {
// Used to determine whether the footer should show (since it is hidden if the graph is showing.)
// `getTimeline` actually returns `TimelineModel | undefined`
graphEventId,
globalQuery: getGlobalQueries(state),
timelineQuery: getTimelineQuery(state, id),
};
};
return mapStateToProps;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const globalTimeRangeSelector = createSelector(selectGlobal, (global) =>

export const globalPolicySelector = createSelector(selectGlobal, (global) => global.policy);

export const globalQuery = createSelector(selectGlobal, (global) => global.queries);
export const globalQuery = () => createSelector(selectGlobal, (global) => global.queries);

export const globalQueryByIdSelector = () => createSelector(selectGlobalQuery, (query) => query);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps & PropsFromRedux
if (timelineId === TimelineId.active) {
refetchQuery([timelineQuery]);
} else {
refetchQuery([globalQuery]);
refetchQuery(globalQuery);
}
}, [timelineId, globalQuery, timelineQuery]);

Expand Down Expand Up @@ -234,11 +234,11 @@ const AlertContextMenuComponent: React.FC<AlertContextMenuProps & PropsFromRedux
};

const makeMapStateToProps = () => {
const getGlobalQuery = inputsSelectors.globalQueryByIdSelector();
const getGlobalQueries = inputsSelectors.globalQuery();
const getTimelineQuery = inputsSelectors.timelineQueryByIdSelector();
const mapStateToProps = (state: State, { timelineId }: AlertContextMenuProps) => {
return {
globalQuery: getGlobalQuery(state, timelineId),
globalQuery: getGlobalQueries(state),
timelineQuery: getTimelineQuery(state, timelineId),
};
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,12 @@ import { Direction, EntityType } from '../../../../common/search_strategy';
import type { DocValueFields } from '../../../../common/search_strategy';
import type { CoreStart } from '../../../../../../../src/core/public';
import type { BrowserFields } from '../../../../common/search_strategy/index_fields';
import { TGridCellAction, TimelineId, TimelineTabs } from '../../../../common/types/timeline';
import {
BulkActionsProp,
TGridCellAction,
TimelineId,
TimelineTabs,
} from '../../../../common/types/timeline';

import type {
CellValueElementProps,
Expand Down Expand Up @@ -95,6 +100,7 @@ const SECURITY_ALERTS_CONSUMERS = [AlertConsumers.SIEM];
export interface TGridIntegratedProps {
additionalFilters: React.ReactNode;
browserFields: BrowserFields;
bulkActions?: BulkActionsProp;
columns: ColumnHeaderOptions[];
data?: DataPublicPluginStart;
dataProviders: DataProvider[];
Expand Down Expand Up @@ -135,6 +141,7 @@ export interface TGridIntegratedProps {
const TGridIntegratedComponent: React.FC<TGridIntegratedProps> = ({
additionalFilters,
browserFields,
bulkActions = true,
columns,
data,
dataProviders,
Expand Down Expand Up @@ -334,6 +341,7 @@ const TGridIntegratedComponent: React.FC<TGridIntegratedProps> = ({
hasAlertsCrud={hasAlertsCrud}
activePage={pageInfo.activePage}
browserFields={browserFields}
bulkActions={bulkActions}
filterQuery={filterQuery}
data={nonDeletedEvents}
defaultCellActions={defaultCellActions}
Expand Down

0 comments on commit 93970db

Please sign in to comment.