Skip to content

Commit

Permalink
Colocate default exports with definition
Browse files Browse the repository at this point in the history
  • Loading branch information
weltenwort committed Jun 9, 2020
1 parent cf11771 commit 80efa79
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 33 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -384,3 +384,7 @@ export const Expressions: React.FC<Props> = (props) => {
</>
);
};

// required for dynamic import
// eslint-disable-next-line import/no-default-export
export default Expressions;

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function createMetricThresholdAlertType(): AlertTypeModel {
defaultMessage: 'Metric threshold',
}),
iconClass: 'bell',
alertParamsExpression: React.lazy(() => import('./components/expression_lazy')),
alertParamsExpression: React.lazy(() => import('./components/expression')),
validate: validateMetricThreshold,
defaultActionMessage: i18n.translate(
'xpack.infra.metrics.alerting.threshold.defaultActionMessage',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,10 @@ export const Expressions: React.FC<Props> = (props) => {
);
};

// required for dynamic import
// eslint-disable-next-line import/no-default-export
export default Expressions;

interface ExpressionRowProps {
nodeType: InventoryItemType;
expressionId: number;
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function getInventoryMetricAlertType(): AlertTypeModel {
defaultMessage: 'Inventory',
}),
iconClass: 'bell',
alertParamsExpression: React.lazy(() => import('./expression_lazy')),
alertParamsExpression: React.lazy(() => import('./expression')),
validate: validateMetricThreshold,
defaultActionMessage: i18n.translate(
'xpack.infra.metrics.alerting.inventory.threshold.defaultActionMessage',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,7 @@ export const Editor: React.FC<Props> = (props) => {
</>
);
};

// required for dynamic import
// eslint-disable-next-line import/no-default-export
export default Editor;

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function getAlertType(): AlertTypeModel {
defaultMessage: 'Log threshold',
}),
iconClass: 'bell',
alertParamsExpression: React.lazy(() => import('./expression_editor/editor_lazy')),
alertParamsExpression: React.lazy(() => import('./expression_editor/editor')),
validate: validateExpression,
defaultActionMessage: i18n.translate(
'xpack.infra.logs.alerting.threshold.defaultActionMessage',
Expand Down

0 comments on commit 80efa79

Please sign in to comment.