Skip to content

Commit

Permalink
Use newfeed.service config for all newsfeeds
Browse files Browse the repository at this point in the history
Prior to this change, the main `kibana` newsfeed would respect the
`newsfeed.service.urlRoot` config setting, but other feeds like
`kibana-analytics` would not. This made it difficult to test new feed
items using a local server.
  • Loading branch information
gtback committed Feb 3, 2021
1 parent d00266b commit 773ec4e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/plugins/newsfeed/public/plugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ export class NewsfeedPublicPlugin
return {
createNewsFeed$: (endpoint: NewsfeedApiEndpoint) => {
const config = Object.assign({}, this.config, {
service: { pathTemplate: `/${endpoint}/v{VERSION}.json` },
service: {
pathTemplate: `/${endpoint}/v{VERSION}.json`,
urlRoot: this.config.service.urlRoot,
},
});
return this.fetchNewsfeed(core, config);
},
Expand Down

0 comments on commit 773ec4e

Please sign in to comment.