Skip to content

Commit

Permalink
Merge branch 'main' into incompatible_cluster_routing_allocation-ftrs…
Browse files Browse the repository at this point in the history
…-change-archive
  • Loading branch information
afharo authored Oct 23, 2024
2 parents 775e9e8 + a6dc47d commit 7499c50
Show file tree
Hide file tree
Showing 55 changed files with 1,743 additions and 724 deletions.
6 changes: 6 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,7 @@ x-pack/test_serverless/**/test_suites/observability/ai_assistant @elastic/obs-ai
/x-pack/test/functional/apps/infra/logs @elastic/obs-ux-logs-team

# Observability UX management team
/x-pack/test/api_integration/apis/slos @elastic/obs-ux-management-team
/x-pack/test/accessibility/apps/group1/uptime.ts @elastic/obs-ux-management-team
/x-pack/test/accessibility/apps/group3/observability.ts @elastic/obs-ux-management-team
/x-pack/packages/observability/alert_details @elastic/obs-ux-management-team
Expand Down Expand Up @@ -1392,6 +1393,9 @@ x-pack/test/api_integration/deployment_agnostic/services/ @elastic/appex-qa
x-pack/test/**/deployment_agnostic/ @elastic/appex-qa #temporarily to monitor tests migration

# Core
/x-pack/test/api_integration/apis/telemetry @elastic/kibana-core
/x-pack/test/api_integration/apis/status @elastic/kibana-core
/x-pack/test/api_integration/apis/stats @elastic/kibana-core
/x-pack/test/api_integration/apis/kibana/stats @elastic/kibana-core
/x-pack/test_serverless/functional/test_suites/security/config.saved_objects_management.ts @elastic/kibana-core
/config/ @elastic/kibana-core
Expand Down Expand Up @@ -1532,6 +1536,7 @@ x-pack/test/api_integration/apis/management/index_management/inference_endpoints
/x-pack/test/functional_search/ @elastic/search-kibana

# Management Experience - Deployment Management
/x-pack/test/api_integration/apis/searchprofiler @elastic/kibana-management
/x-pack/test/api_integration/apis/console @elastic/kibana-management
/x-pack/test_serverless/**/test_suites/common/index_management/ @elastic/kibana-management
/x-pack/test_serverless/**/test_suites/common/management/index_management/ @elastic/kibana-management
Expand Down Expand Up @@ -1835,6 +1840,7 @@ x-pack/test/security_solution_cypress/cypress/tasks/expandable_flyout @elastic/
/x-pack/plugins/security_solution/public/common/components/threat_match @elastic/security-detection-engine

## Security Solution sub teams - security-defend-workflows
/x-pack/test/api_integration/apis/osquery @elastic/security-defend-workflows
/x-pack/plugins/security_solution/public/management/ @elastic/security-defend-workflows
/x-pack/plugins/security_solution/public/common/lib/endpoint/ @elastic/security-defend-workflows
/x-pack/plugins/security_solution/public/common/components/endpoint/ @elastic/security-defend-workflows
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const getRecommendedQueries = ({
defaultMessage: 'Count aggregation',
}
),
queryString: `${fromCommand}\n | STATS count = COUNT(*) // you can group by a field using the BY operator`,
queryString: `${fromCommand}\n | STATS count = COUNT(*) /* you can group by a field using the BY operator */`,
},
...(timeField
? [
Expand All @@ -49,7 +49,7 @@ export const getRecommendedQueries = ({
defaultMessage: 'Sort by time',
}
),
queryString: `${fromCommand}\n | SORT ${timeField} // Data is not sorted by default`,
queryString: `${fromCommand}\n | SORT ${timeField} /* Data is not sorted by default */`,
},
{
label: i18n.translate(
Expand All @@ -64,7 +64,7 @@ export const getRecommendedQueries = ({
defaultMessage: 'Count aggregation over time',
}
),
queryString: `${fromCommand}\n | EVAL buckets = DATE_TRUNC(5 minute, ${timeField}) | STATS count = COUNT(*) BY buckets // try out different intervals`,
queryString: `${fromCommand}\n | EVAL buckets = DATE_TRUNC(5 minute, ${timeField}) | STATS count = COUNT(*) BY buckets /* try out different intervals */`,
},
]
: []),
Expand Down Expand Up @@ -98,7 +98,7 @@ export const getRecommendedQueries = ({
defaultMessage: 'Count aggregation over time',
}
),
queryString: `${fromCommand}\n | WHERE ${timeField} <=?_tend and ${timeField} >?_tstart\n | STATS count = COUNT(*) BY \`Over time\` = BUCKET(${timeField}, 50, ?_tstart, ?_tend) // ?_tstart and ?_tend take the values of the time picker`,
queryString: `${fromCommand}\n | WHERE ${timeField} <=?_tend and ${timeField} >?_tstart\n | STATS count = COUNT(*) BY \`Over time\` = BUCKET(${timeField}, 50, ?_tstart, ?_tend) /* ?_tstart and ?_tend take the values of the time picker */`,
},
{
label: i18n.translate(
Expand All @@ -113,7 +113,7 @@ export const getRecommendedQueries = ({
defaultMessage: 'Event rate over time',
}
),
queryString: `${fromCommand}\n | STATS count = COUNT(*), min_timestamp = MIN(${timeField}) // MIN(dateField) finds the earliest timestamp in the dataset.\n | EVAL event_rate = count / DATE_DIFF("seconds", min_timestamp, NOW()) // Calculates the event rate by dividing the total count of events by the time difference (in seconds) between the earliest event and the current time.\n | KEEP event_rate`,
queryString: `${fromCommand}\n | STATS count = COUNT(*), min_timestamp = MIN(${timeField}) /* MIN(dateField) finds the earliest timestamp in the dataset. */ \n | EVAL event_rate = count / DATE_DIFF("seconds", min_timestamp, NOW()) /* Calculates the event rate by dividing the total count of events by the time difference (in seconds) between the earliest event and the current time. */\n | KEEP event_rate`,
},
{
label: i18n.translate(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -465,7 +465,7 @@ export function checkFunctionArgMatchesDefinition(
const wrappedTypes: Array<(typeof validHit)['type']> = Array.isArray(validHit.type)
? validHit.type
: [validHit.type];
return wrappedTypes.some((ct) => ct === argType || ct === 'null' || ct === 'unknown');
return wrappedTypes.some((ct) => ct === argType || ct === 'null');
}
if (arg.type === 'inlineCast') {
const lowerArgType = argType?.toLowerCase();
Expand Down
Loading

0 comments on commit 7499c50

Please sign in to comment.