Merge branch 'main' of https://github.com/elastic/kibana into improve…

…-warn-feedback-after-data-view-change

# Conflicts:
#	src/plugins/discover/public/application/view_alert/view_alert_route.tsx

.bazelrc.common

@@ -49,11 +49,12 @@ query --incompatible_no_implicit_file_export
 # Log configs
 ## different from default
 common --color=yes
-common --noshow_progress
+common --show_progress
 common --show_task_finish
-build --noshow_loading_progress
-query --noshow_loading_progress
-build --show_result=0
+common --show_progress_rate_limit=10
+build --progress_report_interval=10
+build --show_loading_progress
+build --show_result=1
 
 # Specifies desired output mode for running tests.
 # Valid values are

.buildkite/disabled_jest_configs.json

@@ -1,3 +1,4 @@
 [
+  "x-pack/plugins/triggers_actions_ui/jest.config.js",
   "x-pack/plugins/watcher/jest.config.js"
 ]

.buildkite/ftr_configs.yml

@@ -33,6 +33,8 @@ disabled:
   - x-pack/test/security_solution_cypress/upgrade_config.ts
   - x-pack/test/security_solution_cypress/visual_config.ts
   - x-pack/test/threat_intelligence_cypress/visual_config.ts
+  - x-pack/test/threat_intelligence_cypress/cli_config_parallel.ts
+  - x-pack/test/threat_intelligence_cypress/config.ts
   - x-pack/test/functional_enterprise_search/with_host_configured.config.ts
   - x-pack/plugins/apm/ftr_e2e/ftr_config_open.ts
   - x-pack/plugins/apm/ftr_e2e/ftr_config_run.ts
@@ -260,6 +262,7 @@ enabled:
   - x-pack/test/security_functional/saml.config.ts
   - x-pack/test/security_functional/insecure_cluster_warning.config.ts
   - x-pack/test/security_functional/user_profiles.config.ts
+  - x-pack/test/security_functional/expired_session.config.ts
   - x-pack/test/security_solution_endpoint_api_int/config.ts
   - x-pack/test/security_solution_endpoint/config.ts
   - x-pack/test/session_view/basic/config.ts
@@ -279,3 +282,5 @@ enabled:
   - x-pack/performance/journeys/promotion_tracking_dashboard.ts
   - x-pack/performance/journeys/web_logs_dashboard.ts
   - x-pack/performance/journeys/data_stress_test_lens.ts
+  - x-pack/performance/journeys/ecommerce_dashboard_saved_search_only.ts
+  - x-pack/performance/journeys/ecommerce_dashboard_tsvb_gauge_only.ts

.buildkite/pipelines/es_snapshots/build.yml

@@ -1,5 +1,6 @@
 steps:
   - command: .buildkite/scripts/steps/es_snapshots/build.sh
     label: Build ES Snapshot
+    timeout_in_minutes: 30
     agents:
       queue: c2-8

.buildkite/pipelines/on_merge.yml

@@ -39,8 +39,8 @@ steps:
         - exit_status: '*'
           limit: 1
 
-  - command: .buildkite/scripts/steps/on_merge_ts_refs_api_docs.sh
-    label: Build TS Refs and Check Public API Docs
+  - command: .buildkite/scripts/steps/on_merge_api_docs.sh
+    label: Check Public API Docs
     key: public-api-docs
     agents:
       queue: n2-4-spot

.buildkite/pipelines/pull_request/threat_intelligence.yml

@@ -0,0 +1,12 @@
+steps:
+  - command: .buildkite/scripts/steps/functional/threat_intelligence.sh
+    label: 'Threat Intelligence Tests'
+    agents:
+      queue: ci-group-6
+    depends_on: build
+    timeout_in_minutes: 120
+    parallelism: 4
+    retry:
+      automatic:
+        - exit_status: '*'
+          limit: 1

.buildkite/pull_requests.json

@@ -37,6 +37,7 @@
       ],
       "always_require_ci_on_changed": [
         "^docs/developer/plugin-list.asciidoc$",
+        "^\\.github/CODEOWNERS$",
         "/plugins/[^/]+/readme\\.(md|asciidoc)$"
       ],
       "kibana_versions_check": true,

.buildkite/scripts/common/setup_bazel.sh

@@ -42,18 +42,7 @@ cat <<EOF >> $KIBANA_DIR/.bazelrc
 EOF
 fi
 
-if [[ "$BAZEL_CACHE_MODE" == "buildbuddy" ]]; then
-  echo "[bazel] enabling caching with Buildbuddy"
-cat <<EOF >> $KIBANA_DIR/.bazelrc
-  build --bes_results_url=https://app.buildbuddy.io/invocation/
-  build --bes_backend=grpcs://remote.buildbuddy.io
-  build --remote_cache=grpcs://remote.buildbuddy.io
-  build --remote_timeout=3600
-  build --remote_header=x-buildbuddy-api-key=$KIBANA_BUILDBUDDY_CI_API_KEY
-EOF
-fi
-
-if [[ "$BAZEL_CACHE_MODE" != @(gcs|populate-local-gcs|buildbuddy|none|) ]]; then
-  echo "invalid value for BAZEL_CACHE_MODE received ($BAZEL_CACHE_MODE), expected one of [gcs,populate-local-gcs|buildbuddy,none]"
+if [[ "$BAZEL_CACHE_MODE" != @(gcs|populate-local-gcs|none|) ]]; then
+  echo "invalid value for BAZEL_CACHE_MODE received ($BAZEL_CACHE_MODE), expected one of [gcs,populate-local-gcs|none]"
   exit 1
 fi

.buildkite/scripts/lifecycle/pre_command.sh

@@ -145,9 +145,6 @@ export SYNTHETICS_REMOTE_KIBANA_URL
   export TEST_FAILURES_ES_PASSWORD
 }
 
-KIBANA_BUILDBUDDY_CI_API_KEY=$(retry 5 5 vault read -field=value secret/kibana-issues/dev/kibana-buildbuddy-ci-api-key)
-export KIBANA_BUILDBUDDY_CI_API_KEY
-
 BAZEL_LOCAL_DEV_CACHE_CREDENTIALS_FILE="$HOME/.kibana-ci-bazel-remote-cache-local-dev.json"
 export BAZEL_LOCAL_DEV_CACHE_CREDENTIALS_FILE
 retry 5 5 vault read -field=service_account_json secret/kibana-issues/dev/kibana-ci-bazel-remote-cache-local-dev > "$BAZEL_LOCAL_DEV_CACHE_CREDENTIALS_FILE"

.buildkite/scripts/pipelines/pull_request/pipeline.ts

@@ -68,6 +68,17 @@ const uploadPipeline = (pipelineContent: string | object) => {
       pipeline.push(getPipeline('.buildkite/pipelines/pull_request/security_solution.yml'));
     }
 
+    if (
+      (await doAnyChangesMatch([
+        /^x-pack\/plugins\/threat_intelligence/,
+        /^x-pack\/test\/threat_intelligence_cypress/,
+        /^x-pack\/plugins\/security_solution\/public\/threat_intelligence/,
+      ])) ||
+      GITHUB_PR_LABELS.includes('ci:all-cypress-suites')
+    ) {
+      pipeline.push(getPipeline('.buildkite/pipelines/pull_request/threat_intelligence.yml'));
+    }
+
     if (
       (await doAnyChangesMatch([
         /^src\/plugins\/data/,

.buildkite/scripts/steps/functional/performance_playwright.sh

@@ -119,6 +119,14 @@ while read -r journey; do
   done
 done <<< "$journeys"
 
+echo "--- Upload journey step screenshots"
+JOURNEY_SCREENSHOTS_DIR="${KIBANA_DIR}/data/journey_screenshots"
+if [ -d "$JOURNEY_SCREENSHOTS_DIR" ]; then
+  cd "$JOURNEY_SCREENSHOTS_DIR"
+  buildkite-agent artifact upload "**/*fullscreen*.png"
+  cd "$KIBANA_DIR"
+fi
+
 echo "--- report/record failed journeys"
 if [ "${failedJourneys[*]}" != "" ]; then
   buildkite-agent meta-data set "failed-journeys" "$(printf "%s\n" "${failedJourneys[@]}")"

.buildkite/scripts/steps/functional/threat_intelligence.sh

@@ -0,0 +1,16 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+source .buildkite/scripts/steps/functional/common.sh
+
+export JOB=kibana-threat-intelligence-chrome
+export CLI_NUMBER=${CLI_NUMBER:-$((BUILDKITE_PARALLEL_JOB+1))}
+export CLI_COUNT=${CLI_COUNT:-$BUILDKITE_PARALLEL_JOB_COUNT}
+
+echo "--- Threat Intelligence tests (Chrome)"
+
+node scripts/functional_tests \
+  --debug --bail \
+  --kibana-install-dir "$KIBANA_BUILD_LOCATION" \
+  --config x-pack/test/threat_intelligence_cypress/cli_config_parallel.ts

.buildkite/scripts/steps/on_merge_api_docs.sh

@@ -0,0 +1,10 @@
+#!/usr/bin/env bash
+
+set -euo pipefail
+
+export DISABLE_BOOTSTRAP_VALIDATION=true
+
+.buildkite/scripts/bootstrap.sh
+
+echo "--- Build API Docs"
+node --max-old-space-size=12000 scripts/build_api_docs

.ci/Dockerfile

@@ -1,7 +1,7 @@
 # NOTE: This Dockerfile is ONLY used to run certain tasks in CI. It is not used to run Kibana or as a distributable.
 # If you're looking for the Kibana Docker image distributable, please see: src/dev/build/tasks/os_packages/docker_generator/templates/dockerfile.template.ts
 
-ARG NODE_VERSION=16.17.1
+ARG NODE_VERSION=16.18.1
 
 FROM node:${NODE_VERSION} AS base