Skip to content

Commit

Permalink
[Discover] Remove callout "Get the best look at your search results" …
Browse files Browse the repository at this point in the history
…and the grid tour (#192698)

- Closes #191940

This PR removes the callout and the tour which could be accessed only
from it.
  • Loading branch information
jughosta authored Sep 18, 2024
1 parent 61d0b7f commit 6b2bdf9
Show file tree
Hide file tree
Showing 20 changed files with 18 additions and 751 deletions.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,6 @@ import { DiscoverStateContainer } from '../../state_management/discover_state';
import { useDataState } from '../../hooks/use_data_state';
import { DocTableInfinite } from '../../../../components/doc_table/doc_table_infinite';
import { DocumentExplorerCallout } from '../document_explorer_callout';
import { DocumentExplorerUpdateCallout } from '../document_explorer_callout/document_explorer_update_callout';
import {
DISCOVER_TOUR_STEP_ANCHOR_IDS,
DiscoverTourProvider,
} from '../../../../components/discover_tour';
import {
getMaxAllowedSampleSize,
getAllowedSampleSize,
Expand Down Expand Up @@ -90,8 +85,6 @@ const progressStyle = css`
z-index: 2;
`;

const TOUR_STEPS = { expandButton: DISCOVER_TOUR_STEP_ANCHOR_IDS.expandDocument };

const DocTableInfiniteMemoized = React.memo(DocTableInfinite);
const DiscoverGridMemoized = React.memo(DiscoverGrid);

Expand Down Expand Up @@ -340,18 +333,6 @@ function DiscoverDocumentsComponent({
[currentColumns, documents?.esqlQueryColumns, documentState.interceptedWarnings]
);

const gridAnnouncementCallout = useMemo(() => {
if (hideAnnouncements || isLegacy) {
return null;
}

return !isEsqlMode ? (
<DiscoverTourProvider>
<DocumentExplorerUpdateCallout />
</DiscoverTourProvider>
) : null;
}, [hideAnnouncements, isLegacy, isEsqlMode]);

const loadingIndicator = useMemo(
() =>
isDataLoading ? (
Expand All @@ -373,12 +354,11 @@ function DiscoverDocumentsComponent({
bottomSection: (
<>
{callouts}
{gridAnnouncementCallout}
{loadingIndicator}
</>
),
}),
[viewModeToggle, callouts, gridAnnouncementCallout, loadingIndicator]
[viewModeToggle, callouts, loadingIndicator]
);

if (isDataViewLoading || (isEmptyDataResult && isDataLoading)) {
Expand Down Expand Up @@ -486,7 +466,6 @@ function DiscoverDocumentsComponent({
services={services}
totalHits={totalHits}
onFetchMoreRecords={onFetchMoreRecords}
componentsTourSteps={TOUR_STEPS}
externalCustomRenderers={cellRenderers}
customGridColumnsConfiguration={customGridColumnsConfiguration}
rowAdditionalLeadingControls={rowAdditionalLeadingControls}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import { PLUGIN_ID } from '../../../../../common';
import { useDiscoverServices } from '../../../../hooks/use_discover_services';
import { DataDocuments$ } from '../../state_management/discover_data_state_container';
import { FetchStatus, SidebarToggleState } from '../../../types';
import { DISCOVER_TOUR_STEP_ANCHOR_IDS } from '../../../../components/discover_tour';
import {
discoverSidebarReducer,
getInitialState,
Expand All @@ -48,11 +47,6 @@ const getCreationOptions: UnifiedFieldListSidebarContainerProps['getCreationOpti
showSidebarToggleButton: true,
disableFieldsExistenceAutoFetching: true,
buttonAddFieldVariant: 'toolbar',
buttonPropsToTriggerFlyout: {
contentProps: {
id: DISCOVER_TOUR_STEP_ANCHOR_IDS.addFields,
},
},
buttonAddFieldToWorkspaceProps: {
'aria-label': i18n.translate('discover.fieldChooser.discoverField.addFieldTooltip', {
defaultMessage: 'Add field as column',
Expand Down
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

This file was deleted.

Loading

0 comments on commit 6b2bdf9

Please sign in to comment.